Fix process tests on OpenBSD #225
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdksh (OpenBSD /bin/sh) behaves differently compared to most other shells: https://marc.info/?l=openbsd-tech&m=164153793509651&w=2 The same subprocess behavior can be achieved by a python script. Fixes process011 and process009 tests on OpenBSD.
I suspect this will be OK on other systems that use posix_spawn.
|
Since these are run by GHC's test suite and not the local one, @bgamari would you mind reviewing and signing off if you're happy with this change? Feel free to merge too if you'd like, or I can. |
|
Ping for the next release? |
snoyberg
approved these changes
Feb 9, 2022
|
Sorry, I thought I'd seen @bgamari sign off on this. I need to wait on his approval before merging. |
|
I'll try to test this in the GHC testsuite tomorrow. |
|
Looking at this now. |
|
Indeed the GHC testsuite passes when built against this branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.