Skip to content

Use cl-lib instead of cl. #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 23, 2014
Merged

Use cl-lib instead of cl. #339

merged 1 commit into from
Sep 23, 2014

Conversation

Fanael
Copy link
Contributor

@Fanael Fanael commented Sep 17, 2014

Fixes #161.

@purcell
Copy link
Member

purcell commented Sep 18, 2014

Yes, excellent! I'll need to double-check that the -pkg.el.in file is being processed by MELPA, so that the new dependency is included in the packages built there, but that shouldn't be a barrier to merging this PR.

I'll leave it to one of the more establish maintainers to approve the merge, though.

@purcell
Copy link
Member

purcell commented Sep 18, 2014

Note that the Travis build fails on Emacs 23, so there might be some hoops to jump through to get that working, since the build will now need to install cl-lib via package.el on that version.

@Fanael
Copy link
Contributor Author

Fanael commented Sep 22, 2014

Ping?

@purcell
Copy link
Member

purcell commented Sep 23, 2014

Hey @hvr, what do you think of this? Looks great to me.

@hvr
Copy link
Member

hvr commented Sep 23, 2014

@purcell I haven't had (and don't have right now) time to look at it, but want to trust your judgment on this... so let's merge (and adapt the travis job before that, it has a failure it seems)

PS: If it's too hard to restore emacs23 compat in the travis job, just kill it... everybody should upgrade to Emacs24 anyway =)

@purcell
Copy link
Member

purcell commented Sep 23, 2014

Okay, agreed. I'll see if there's a relatively straightforward way to get the Travis job working.

@purcell purcell merged commit c388f0a into haskell:master Sep 23, 2014
@purcell
Copy link
Member

purcell commented Sep 23, 2014

Great, merged. I've disabled the emacs23 build for now. It's possible we can do something with cask to get it working, but I'm reluctant to rush into adding more moving parts right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch to cl-lib
3 participants