Skip to content

Revert "Avoid impredicativity in Distribution.Simple.PreProcess (#5836)" #6553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 23, 2020
Merged

Revert "Avoid impredicativity in Distribution.Simple.PreProcess (#5836)" #6553

merged 1 commit into from
Feb 23, 2020

Conversation

RyanGlScott
Copy link
Member

This reverts commit 6a24235.

This commit is no longer needed after the removal of WithCallStackIO in 64532b8.


Please include the following checklist in your PR:

  • Patches conform to the coding conventions.
  • Any changes that could be relevant to users have been recorded in the changelog.
  • The documentation has been updated, if necessary.
  • If the change is docs-only, [ci skip] is used to avoid triggering the build bots.

Please also shortly describe how you tested your change. Bonus points for added tests!

This reverts commit 6a24235.

This commit is no longer needed after the removal of
`WithCallStackIO` in
64532b8.
@RyanGlScott
Copy link
Member Author

Hm, the macOS build is failing on Validate lib-suite here:

PackageTests/Configure/setup.test.hs                                                                              FAIL (2.52s)
$ /opt/ghc/8.8.1/bin/runghc-8.8.1 -- '--ghc-arg=-i' '--ghc-arg=-no-user-package-db' '--ghc-arg=-package-db' '--ghc-arg=/Users/runner/.cabal/store/ghc-8.8.1/package.db' '--ghc-arg=-package-db' '--ghc-arg=/Users/runner/runners/2.165.2/work/cabal/cabal/dist-newstyle-validate-ghc-8.8.1/packagedb/ghc-8.8.1' '--ghc-arg=-package-id' '--ghc-arg=Cabal-3.3.0.0-inplace' '--ghc-arg=-package-id' '--ghc-arg=sync-2.2.2-2f09e089' '--ghc-arg=-package-id' '--ghc-arg=base-4.13.0.0' '--ghc-arg=-package-id' '--ghc-arg=cabal-testsuite-3-inplace' '--ghc-arg=-package-id' '--ghc-arg=clck-0.8-e11eb1cc' '--ghc-arg=-package-id' '--ghc-arg=xcptns-0.10.4-941ff665' '--ghc-arg=-package-id' '--ghc-arg=filepath-1.4.2.1' '--ghc-arg=-package-id' '--ghc-arg=ptprs-pplctv-0.15.1.0-a44bb4db' '--ghc-arg=-package-id' '--ghc-arg=process-1.6.5.1' '--ghc-arg=-package-id' '--ghc-arg=transformers-0.5.6.2' PackageTests/Configure/setup.test.hs --builddir /Users/runner/runners/2.165.2/work/cabal/cabal/dist-newstyle-validate-ghc-8.8.1/build/x86_64-osx/ghc-8.8.1/cabal-testsuite-3 PackageTests/Configure/setup.test.hs --with-ghc ghc-8.8.1
stdout:
+ autoreconf -i
Can't exec "aclocal": No such file or directory at /usr/local/Cellar/autoconf/2.69/share/autoconf/Autom4te/FileUtils.pm line 326.
autoreconf: failed to run aclocal: No such file or directory

stderr:
*** Exception: Command autoreconf -i failed.
Output:
Can't exec "aclocal": No such file or directory at /usr/local/Cellar/autoconf/2.69/share/autoconf/Autom4te/FileUtils.pm line 326.
autoreconf: failed to run aclocal: No such file or directory



*** unexpected failure for PackageTests/Configure/setup.test.hs

I would be surprised if this were failing due to this patch, but then again, I cannot find a cabal issue about this, so I'm not sure.

@phadej
Copy link
Collaborator

phadej commented Feb 23, 2020

The master fails as well, for about ten days already.

I opened #6554 so you don't need to wonder.

@phadej phadej merged commit e6e4e62 into haskell:master Feb 23, 2020
@phadej phadej mentioned this pull request Jul 10, 2020
@phadej phadej added this to the 3.4.0.0-rc1 milestone Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants