Skip to content

Avoid impredicativity in Distribution.Simple.PreProcess #5836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 12, 2019
Merged

Avoid impredicativity in Distribution.Simple.PreProcess #5836

merged 2 commits into from
Jan 12, 2019

Conversation

RyanGlScott
Copy link
Member

Fixes #5833.


Please include the following checklist in your PR:

  • Patches conform to the coding conventions.
  • Any changes that could be relevant to users have been recorded in the changelog. (RGS: No public API changes.)
  • The documentation has been updated, if necessary.
  • If the change is docs-only, [ci skip] is used to avoid triggering the build bots. (RGS: Not a docs-only change.)

Please also shortly describe how you tested your change. Bonus points for added tests! (RGS: Distribution.Simple.PreProcess continues to build with old GHCs, as well as GHC HEAD plus this patch.)

Copy link
Member

@hvr hvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@RyanGlScott RyanGlScott merged commit 6a24235 into haskell:master Jan 12, 2019
phadej added a commit that referenced this pull request Feb 23, 2020
Revert "Avoid impredicativity in Distribution.Simple.PreProcess (#5836)"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants