Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changelogs are docs (backport #10354) #10370

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Sep 17, 2024

We don't mark changelogs as documentation, so CI unnecessarily does full checks when we add changelogs. Correct this.

NOTE: we only accept changelog files from top-level subdirectories. There are changelog files in package tests that must be considered "code" from the standpoint of CI.

Template B: This PR does not modify behaviour or interface

E.g. the PR only touches documentation or tests, does refactorings, etc.

Include the following checklist in your PR:

  • Patches conform to the coding conventions.
  • Is this a PR that fixes CI? If so, it will need to be backported to older cabal release branches (ask maintainers for directions).

This is an automatic backport of pull request #10354 done by [Mergify](https://mergify.com).

@mergify mergify bot added the conflicts label Sep 17, 2024
Copy link
Contributor Author

mergify bot commented Sep 17, 2024

Cherry-pick of 871c0d4 has failed:

On branch mergify/bp/3.12/pr-10354
Your branch is up to date with 'origin/3.12'.

You are currently cherry-picking commit 871c0d46a.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   .github/workflows/bootstrap.skip.yml
	modified:   .github/workflows/bootstrap.yml
	modified:   .github/workflows/validate.skip.yml

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	deleted by us:   .github/workflows/check-sdist.yml
	both modified:   .github/workflows/validate.yml

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot mentioned this pull request Sep 17, 2024
2 tasks
@mergify mergify bot added the backport label Sep 17, 2024
We don't mark changelogs as documentation, so CI unnecessarily
does full checks when we add changelogs. Correct this.

NOTE: we only accept changelog files from top-level subdirectories.
There are changelog files in various tests that must be considered
to be "code".

(cherry picked from commit 871c0d4)
@geekosaur geekosaur added the merge me Tell Mergify Bot to merge label Sep 17, 2024
@mergify mergify bot merged commit b6fb6f5 into 3.12 Sep 17, 2024
51 checks passed
@mergify mergify bot deleted the mergify/bp/3.12/pr-10354 branch September 17, 2024 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport merge me Tell Mergify Bot to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant