changelogs are docs #10354
Merged
changelogs are docs #10354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geekosaur
force-pushed
the
changelogs-are-docs
branch
from
701f670
to
5f9b068
Compare
|
@ffaf1 did you hit comment instead of approve by mistake? |
|
I think comment is the default
…On Sat, Sep 14, 2024, 16:40 Artem Pelenitsyn ***@***.***> wrote:
@ffaf1 <https://github.com/ffaf1> did you hit comment instead of approve
by mistake?
—
Reply to this email directly, view it on GitHub
<#10354 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAPRFIERJVBSIM34457MVB3ZWSNLBAVCNFSM6AAAAABOGN6YIGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNJRGE2DKMZRGE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
N.B.: I took the liberty of adding "needs-backport 3.14", but as it's now a bit too late for it to be relevant to the 3.14.0.0 release it should be backported afterward. 3.12 can be backported as soon as it's merged to |
ffaf1
approved these changes
Sep 15, 2024
mergify
bot
added
the
ready and waiting
|
@mergify backport 3.12 |
✅ Backports have been created
|
geekosaur
removed
merge me
|
Looks like I forgot some jobs that need to be updated; will fix shortly. |
geekosaur
force-pushed
the
changelogs-are-docs
branch
from
5f9b068
to
3546323
Compare
mergify
bot
added
ready and waiting
We don't mark changelogs as documentation, so CI unnecessarily does full checks when we add changelogs. Correct this. NOTE: we only accept changelog files from top-level subdirectories. There are changelog files in various tests that must be considered to be "code".
Mikolaj
force-pushed
the
changelogs-are-docs
branch
from
3546323
to
871c0d4
Compare
2 tasks
mergify bot
added a commit
that referenced
this pull request
Sep 17, 2024
changelogs are docs (backport #10354)
|
@mergify backport 3.14 |
✅ Backports have been created
|
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't mark changelogs as documentation, so CI unnecessarily does full checks when we add changelogs. Correct this.
NOTE: we only accept changelog files from top-level subdirectories. There are changelog files in package tests that must be considered "code" from the standpoint of CI.
Template B: This PR does not modify behaviour or interface
E.g. the PR only touches documentation or tests, does refactorings, etc.
Include the following checklist in your PR: