Skip to content

fix: Make newSemaphoreJobControl respect verbosity #10055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 30, 2024
Merged

fix: Make newSemaphoreJobControl respect verbosity #10055

merged 1 commit into from
May 30, 2024

Conversation

@wismill
Copy link
Collaborator

@wismill wismill commented May 24, 2024 •
edited
Loading

Template Α: This PR modifies behaviour or interface

Include the following checklist in your PR:

  • Patches conform to the coding conventions.
  • Any changes that could be relevant to users have been recorded in the changelog.
  • The documentation has been updated, if necessary.
  • Manual QA notes have been included.
  • Tests have been added. (Ask for help if you don’t know how to write them! Ask for an exemption if tests are too complex for too little coverage!)

This PR fixes the message “Created semaphore called cabal_semaphore_XXX with NNN slots.” appearing even with --verbosity=0.

@wismill wismill force-pushed the semaphore/verbosity branch from 4bf6f83 to 5ce8922 Compare May 24, 2024 13:49
@wismill wismill added the merge me Tell Mergify Bot to merge label May 25, 2024
@mergify mergify bot added the merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days label May 29, 2024
@Mikolaj Mikolaj force-pushed the semaphore/verbosity branch from 5ce8922 to 225d2b1 Compare May 29, 2024 07:34
@wismill
Copy link
Collaborator Author

wismill commented May 30, 2024

@Mikolaj not sure what is happening here

@ulysses4ever
Copy link
Collaborator

ulysses4ever commented May 30, 2024

@mergify refresh

@mergify
Copy link
Contributor

mergify bot commented May 30, 2024

refresh

✅ Pull request refreshed

@ulysses4ever
Copy link
Collaborator

ulysses4ever commented May 30, 2024

The Validate ubuntu-latest ghc-8.10.7 has had a transient failure. Rerunning now.

@mergify mergify bot merged commit f323d29 into haskell:master May 30, 2024
@wismill wismill deleted the semaphore/verbosity branch May 30, 2024 15:52
@ulysses4ever
Copy link
Collaborator

ulysses4ever commented May 30, 2024

@mergify backport 3.12

@mergify
Copy link
Contributor

mergify bot commented May 30, 2024 •
edited
Loading

backport 3.12

✅ Backports have been created

@mergify mergify bot mentioned this pull request May 30, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mpickering mpickering mpickering approved these changes

@geekosaur geekosaur geekosaur approved these changes

Assignees

No one assigned

Labels

cabal-install: other merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days merge me Tell Mergify Bot to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@wismill @ulysses4ever @mpickering @geekosaur @Mikolaj