Skip to content

Update for QuickCheck >= 2.10 #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Conversation

bgamari
Copy link
Contributor

@bgamari bgamari commented Jun 24, 2019

This fixes nearly all of the tests for compatibility with QuickCheck 2.10, allowing the testsuite to be run with GHC 8.6. The tests still failing are the following in the `P:

  • compare 7
  • scanl1
  • scanr
  • scanr1

Fixing these should merely involve adapting them to use ASCIIChar and ASCIIString instead of Char and String.

@sjakobi
Copy link
Member

sjakobi commented Dec 18, 2019

If this PR has been superseded by #179, can it be closed?

@Bodigrim
Copy link
Contributor

It seems to be superseded by #179 indeed (which includes commits from this PR). Test suite seems already working fine on CI. Could this PR be closed? @bgamari @cartazio

@cartazio
Copy link

Sounds good. I’ll close it for now

@cartazio cartazio closed this May 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants