Skip to content

Generics and TH support for lifted typeclasses #414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Generics and TH support for lifted typeclasses #414

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions Data/Aeson.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,9 +77,14 @@ module Data.Aeson
, GFromJSON(..)
, GToJSON(..)
, GToEncoding(..)
, Zero
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does one need to export these from Data.Aeson ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Need" is a strong word, but if GFromJSON/GToJSON/GToEncoding are exported from Data.Aeson, then I feel it makes sense to export Zero/One too, since it would now be pretty much impossible to write useful type signatures involving the former without using the latter (since you need things like GToJSON Zero (Rep a)).

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

, One
, genericToJSON
, genericLiftToJSON
, genericToEncoding
, genericLiftToEncoding
, genericParseJSON
, genericLiftParseJSON
, defaultOptions

-- * Inspecting @'Value's@
Expand Down
Loading