Generics and TH support for lifted typeclasses #414
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unfortunately #413 moves everything around, but I can rebase this after moving is merged; could review then on the way too. |
| , GFromJSON(..) | ||
| , GToJSON(..) | ||
| , GToEncoding(..) | ||
| , Zero |
There was a problem hiding this comment.
Does one need to export these from Data.Aeson ?
There was a problem hiding this comment.
"Need" is a strong word, but if GFromJSON/GToJSON/GToEncoding are exported from Data.Aeson, then I feel it makes sense to export Zero/One too, since it would now be pretty much impossible to write useful type signatures involving the former without using the latter (since you need things like GToJSON Zero (Rep a)).
|
@andrewthad I disagree: #415 |
|
@phadej Dang. You did that way faster than I thought was possible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because boilerplate makes me sad.
This adds the capability to automatically derive:
ToJSON1,ToJSON2,FromJSON1, andFromJSON2with Template HaskellToJSON1andFromJSON1via GHC generics (sadly, generics isn't expressive enough to coverToJSON2andFromJSON2)This code is somewhat old and had to rebased several times recently, so @andrewthad, @phadej, please make sure I didn't accidentally trample something you wrote.