Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

{-# ANN otations #-} cause interpreter to load. #654

Closed
phadej opened this issue Jul 23, 2018 · 1 comment
Closed

{-# ANN otations #-} cause interpreter to load. #654

phadej opened this issue Jul 23, 2018 · 1 comment
Labels
good first issue help wanted

Comments

@phadej
Copy link
Collaborator

phadej commented Jul 23, 2018

They were introduced in HLint patch. This

  • Slows compilation with TH-able GHC
  • Causes loud? warning (error?) on TH-less GHC
@bergmark
Copy link
Collaborator

Let's remove them then, I'm not sure if hlint is even doing anything because of ndmitchell/hlint#460

@bergmark bergmark mentioned this issue Jul 26, 2018
Closed
@phadej phadej mentioned this issue May 12, 2019
Merged
phadej added a commit to phadej/aeson that referenced this issue May 12, 2019
@phadej
Fix haskell#654: Remove ANNotations, and some cleanup
079e704 
- `make lint` is clean with HLint-2.1.17
phadej added a commit to phadej/aeson that referenced this issue May 12, 2019
@phadej
Fix haskell#654: Remove ANNotations, and some cleanup
fd5cb3b 
- `make lint` is clean with HLint-2.1.17
phadej added a commit to phadej/aeson that referenced this issue May 13, 2019
@phadej
Fix haskell#654: Remove ANNotations, and some cleanup
2e6873d 
- `make lint` is clean with HLint-2.1.17
- HLint.hs -> .hlint.yaml
bergmark added a commit that referenced this issue May 18, 2019
@bergmark
Merge pull request #699 from phadej/issue-654
2a3fd22 
Fix #654: Remove ANNotations, and some cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@phadej @bergmark