Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use haskell-ci #343

Merged
merged 5 commits into from
May 20, 2019
Merged

Use haskell-ci #343

merged 5 commits into from
May 20, 2019

Conversation

phadej
Copy link
Contributor

@phadej phadej commented May 10, 2019 •
edited
Loading

On top of #342

Temporarily disable 7.0 and 7.2 jobs, as there aren't
ansi-wl-pprint-0.6.8 with 7.0/7.2 support
https://matrix.hackage.haskell.org/#/package/ansi-wl-pprint

I'll add it back, as soon as
UnkindPartition/ansi-terminal#82
is decided upon

@phadej
Allow semigroups-0.19 and fix Monad(fail)
1a38782 
- semigroups-0.19 doesn't break anything in optparse-applicative
- fail isn't a method of Monad since base-4.13 (GHC-8.8)
  - Also the warning is removed, as it says
    -Wnoncanonical-monadfail-instances is deprecated: fail is no longer a method of Monad
@phadej phadej force-pushed the haskell-ci branch 2 times, most recently from 7ae73d3 to 92fd2df Compare May 10, 2019 21:10
@phadej
Regenerate .travis.yml
ad70813 
Temporarily disable 7.0 and 7.2 jobs, as there aren't
ansi-wl-pprint-0.6.8 with 7.0/7.2 support
https://matrix.hackage.haskell.org/#/package/ansi-wl-pprint

I'll add it back, as soon as
UnkindPartition/ansi-terminal#82
is decided upon
@phadej
Add .hlint.yaml, fix some hlint warns, ignore others
ad2fa7f 
Note: {-# ANN #-} start the GHCi interpreter (like TemplateHaskell!),
so I removed that.
@phadej
Move library sources into src/
9f90e4a 
This will enable more easier hlinting on CI
@phadej
Copy link
Contributor Author

phadej commented May 12, 2019

@HuwCampbell I released new version of ansi-wl-pprint reinstating GHC-7.0 support.

I also noted there was {-# ANN #-} pragma for HLint. GHC loads interpreter for them, which is comparable to using TemplateHaskell (GHC issue #13609, similar issue in aeson). I removed it, and added .hlint.yaml; which caused small cascade of changes:

  • move sources to src/
  • so we can hlint in CI
  • without moving to src/ we'd hlint the tests too, and there are some more warnings which I don't feel comfortable to clean up.

@hcampbell-tyro
Copy link

Is this running tests for GHC 8.8.1? QC is still failing no?

@phadej
Copy link
Contributor Author

phadej commented May 17, 2019

@hcampbell-tyro it does run tests

Test suite logged to: /tmp/dist-test.nq6a/dist-newstyle/build/x86_64-linux/ghc-8.8.0.20190424/optparse-applicative-0.14.3.0/t/tests/test/optparse-applicative-0.14.3.0-tests.log 
1 of 1 test suites (1 of 1 test cases) passed.

haskell-ci uses head.hackage patches when building GHC head and alpha releases.

@HuwCampbell HuwCampbell merged commit aac5994 into pcapriotti:master May 20, 2019
@HuwCampbell
Copy link
Collaborator

Thanks.

I'll look more into the haskell-ci script in the coming days, but it seems to cover our bases.

@HuwCampbell
Copy link
Collaborator

I'm now getting build failures on ghc-7.0.4. Care to assist?

@phadej
Copy link
Contributor Author

phadej commented Jun 8, 2019 via email

@phadej phadej deleted the haskell-ci branch June 8, 2019 16:14
@phadej
Copy link
Contributor Author

phadej commented Jun 10, 2019

CI will be fixed by itself when nick8325/quickcheck#262 is merged&released.

Until then you can either lift the requirement for using installed random https://github.com/haskell-CI/haskell-ci/blob/a517459b7a82ae70e0d08399a60871c3f0ec2d1d/cabal.haskell-ci#L39-L41, or disable running tests on GHC-7.0.4 https://github.com/haskell-CI/haskell-ci/blob/a517459b7a82ae70e0d08399a60871c3f0ec2d1d/cabal.haskell-ci#L15-L17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@phadej @hcampbell-tyro @HuwCampbell