Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix styling of links #271

Merged
merged 3 commits into from
Jun 28, 2023
Merged

Fix styling of links #271

merged 3 commits into from
Jun 28, 2023

Conversation

alt-romes
Copy link
Contributor

In trying to improve the appearence of the Haskell main webpage a little bit, I've

  1. Removed the underline of links that appear
    • inside buttons
    • in the navbar
  2. Changed the dotted underline to a solid underline

Screenshots:

Old:

Screenshot 2023-06-27 at 13 59 32 Screenshot 2023-06-27 at 13 59 42 Screenshot 2023-06-27 at 13 59 49

New:

Screenshot 2023-06-27 at 11 07 50 Screenshot 2023-06-27 at 11 07 40 Screenshot 2023-06-27 at 11 07 34

I suppose the dotted vs solid underline decision is more contentious, so I've added it as a separate commit we can also just drop.

Thanks!

Copy link
Member

@TikhonJelvis TikhonJelvis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Based on the screenshots I'd be fine with changing the dotted underline to a normal underline. Curious what other folks think.

@tomjaguarpaw
Copy link
Collaborator

I think we should also drop the underline entirely on the sponsor names and the video titles. They don't seems to serve any purpose to me and I think solid underline looks much worse there.

@TikhonJelvis
Copy link
Member

We generally need something more than just color to indicate links, both for accessibility reasons and because we use purple all over the place. The video titles seem sufficiently clear based on context so we could drop the underline there, but I'm not sure about the sponsor names.

@tomjaguarpaw
Copy link
Collaborator

Ah yes, I was thinking the whole sponsor rectangle was a link, but it's only the logo and name. Well, I think the full underline is far too obtrusive in the sponsor name link, but I'm not a graphic designer, so weight my opinion accordingly.

@TikhonJelvis
Copy link
Member

Yeah, I'm not sure either, but seems fine to keep it underlined for now.

@alt-romes Do you think getting rid of the underline for the videos makes sense? I'd lean in that direction, but I'm not 100% on it either :/. If it makes sense, could you add it in this PR?

@alt-romes
Copy link
Contributor Author

Yes, done:
Screenshot 2023-06-27 at 16 17 59

@alt-romes
Copy link
Contributor Author

alt-romes commented Jun 27, 2023

but I'm not a graphic designer

I wonder if it would make sense for the @haskellfoundation to invest in re-designing some parts of the website/branding. I was recently pleasantly surprised to see the mature/polished look of ocaml's website and learn/docs pages.

This not to say that the haskell website is immature, just that there's space to improve and OCaml seems to be a good reference.

(which prompted me to look for low hanging style fruit in the haskell website)

@tomjaguarpaw
Copy link
Collaborator

Looks good to me. @TikhonJelvis I'll let you carry this over the line.

@TikhonJelvis TikhonJelvis merged commit 680fb27 into haskell-infra:master Jun 28, 2023
1 check passed
@TikhonJelvis
Copy link
Member

Sweet. Thanks for the improvements @alt-romes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants