-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix styling of links #271
Fix styling of links #271
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Based on the screenshots I'd be fine with changing the dotted underline to a normal underline. Curious what other folks think.
I think we should also drop the underline entirely on the sponsor names and the video titles. They don't seems to serve any purpose to me and I think solid underline looks much worse there. |
We generally need something more than just color to indicate links, both for accessibility reasons and because we use purple all over the place. The video titles seem sufficiently clear based on context so we could drop the underline there, but I'm not sure about the sponsor names. |
Ah yes, I was thinking the whole sponsor rectangle was a link, but it's only the logo and name. Well, I think the full underline is far too obtrusive in the sponsor name link, but I'm not a graphic designer, so weight my opinion accordingly. |
Yeah, I'm not sure either, but seems fine to keep it underlined for now. @alt-romes Do you think getting rid of the underline for the videos makes sense? I'd lean in that direction, but I'm not 100% on it either :/. If it makes sense, could you add it in this PR? |
I wonder if it would make sense for the @haskellfoundation to invest in re-designing some parts of the website/branding. I was recently pleasantly surprised to see the mature/polished look of ocaml's website and learn/docs pages. This not to say that the haskell website is immature, just that there's space to improve and OCaml seems to be a good reference. (which prompted me to look for low hanging style fruit in the haskell website) |
Looks good to me. @TikhonJelvis I'll let you carry this over the line. |
Sweet. Thanks for the improvements @alt-romes! |
In trying to improve the appearence of the Haskell main webpage a little bit, I've
Screenshots:
Old:
New:
I suppose the dotted vs solid underline decision is more contentious, so I've added it as a separate commit we can also just drop.
Thanks!