-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Links look not that good (in Chrome), troubles with styles? #58
Comments
Yeah, some of those links look a bit off. We added the dotted underline to help visually distinguish links inside body text—the purple and black color scheme didn't have enough contrast otherwise, and a full underline looked rather dated. How can we visually distinguish the links in a way that looks better? If the main problem is that the video links specifically look bad, I imagine we could have some dedicated styling for the video cards specifically that makes it clear that they are clickable without needing the underline. |
Suggestion: This issue to be closed with a PR addressing the navigation link color contrast issue Why?
I'm happy to pick this up if the reframing and proposed mitigation sound good. |
The link styling was updated a few weeks ago in #271. The contrast issue is definitely worth fixing. Thanks for spotting that! Your suggested color for the navigation menu looks great to me. I was mostly thinking about distinguishing links in body text rather than the nav menu, and those seem fine with the solid underline that they have today. Having an underline for the navigation menu seems less important because it is clear those are links based on their position and layout. We could still do that though, and based on the screenshot above it would look fine. |
Perfect! And great thread in the linked issue, it would indeed be nice to have some input from a designer. Small, isolated fixes could introduce a lot of visual inconsistency. |
There are dotted underlines under links.
The text was updated successfully, but these errors were encountered: