Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links look not that good (in Chrome), troubles with styles? #58

Closed
metacortexplus opened this issue Jan 9, 2021 · 5 comments · Fixed by #276
Closed

Links look not that good (in Chrome), troubles with styles? #58

metacortexplus opened this issue Jan 9, 2021 · 5 comments · Fixed by #276

Comments

@metacortexplus
Copy link

metacortexplus commented Jan 9, 2021

There are dotted underlines under links.

Screenshot from 2021-01-09 10-24-18

@TikhonJelvis
Copy link
Member

Yeah, some of those links look a bit off.

We added the dotted underline to help visually distinguish links inside body text—the purple and black color scheme didn't have enough contrast otherwise, and a full underline looked rather dated.

How can we visually distinguish the links in a way that looks better?

If the main problem is that the video links specifically look bad, I imagine we could have some dedicated styling for the video cards specifically that makes it clear that they are clickable without needing the underline.

@ilyakooo0
Copy link

Some other browsers (like Safari) still render solid underlines.

I personally think solid underlines look a lot better than the dotted ones.

Screenshot 2021-05-10 at 13 10 43

@enmcarv
Copy link
Contributor

enmcarv commented Jul 18, 2023

Suggestion: This issue to be closed with a PR addressing the navigation link color contrast issue

Why?

  • I can't reproduce any dotted underlines using Chrome or Firefox.
  • The contrast between the nav links does not meet WCAG 2 AA contrast ratio requirements.
    • Mitigation: Darken until standard is met with #717171
    • Question: Do we think the links still need to be distinguished more? I think having them be bold or underlined with a solid line are both great options.

I'm happy to pick this up if the reframing and proposed mitigation sound good.

Screenshot from 2023-07-18 14-17-32

@TikhonJelvis
Copy link
Member

TikhonJelvis commented Jul 18, 2023

The link styling was updated a few weeks ago in #271.

The contrast issue is definitely worth fixing. Thanks for spotting that! Your suggested color for the navigation menu looks great to me.

I was mostly thinking about distinguishing links in body text rather than the nav menu, and those seem fine with the solid underline that they have today. Having an underline for the navigation menu seems less important because it is clear those are links based on their position and layout. We could still do that though, and based on the screenshot above it would look fine.

@enmcarv
Copy link
Contributor

enmcarv commented Jul 18, 2023

Perfect! And great thread in the linked issue, it would indeed be nice to have some input from a designer. Small, isolated fixes could introduce a lot of visual inconsistency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants