deer: implement Deserialize for core::num
#2378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2378 +/- ##
=======================================
Coverage 56.77% 56.78%
=======================================
Files 337 337
Lines 26015 26021 +6
Branches 421 421
=======================================
+ Hits 14769 14775 +6
Misses 11241 11241
Partials 5 5
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
TimDiekmann
requested changes
Apr 12, 2023
TimDiekmann
previously approved these changes
Apr 13, 2023
TimDiekmann
previously approved these changes
Apr 13, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
TimDiekmann
previously approved these changes
Apr 13, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
TimDiekmann
approved these changes
Apr 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌟 What is the purpose of this PR?
Implements Deserialize for:
core::num::Wrappingcore::num::SaturatingOrginally taken from #1875
🔗 Related links
deertype implementation #1700deerimplementDeserializefor built-in types (Part 2) #1875👂 Open Questions
Should
WrappingandSaturatingbe considered at deserialization time? Currently we just deserialize the value with the underlying value and then mapWrappingonto it. We will still fail if we supply256to an u8. This is currently whatserdedoes.Alternative would be only to implement
Wrappingon all primitive num types, and if a larger number is encountered we simply modulo it on wrapping or set it to the max.🔍 Has this modified a publishable library?
This PR: