Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Update <a> tags to LinkTo's #17866

Merged
merged 5 commits into from
Nov 11, 2022
Merged

UI: Update <a> tags to LinkTo's #17866

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d5a4d0e
chore: shared external link component, glimmerization
hashishaw Nov 9, 2022
765b76b
chore: update easy a tags
hashishaw Nov 9, 2022
5341ebf
chore: update other a tags
hashishaw Nov 10, 2022
caca85a
chore: lil cleanup
hashishaw Nov 10, 2022
504eee7
changelog
hashishaw Nov 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: update other a tags
  • Loading branch information
@hashishaw
hashishaw committed Nov 10, 2022
commit 5341ebf06f931dd32a811814fbf81e45691c5990
9 changes: 7 additions & 2 deletions ui/app/templates/components/namespace-link.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,9 @@
<a href={{this.namespaceLink}} class={{concat "is-block " this.class}} data-test-namespace-link={{this.normalizedNamespace}}>
<ExternalLink
@href={{this.namespaceLink}}
@sameTab={{true}}
class={{concat "is-block " this.class}}
data-test-namespace-link={{this.normalizedNamespace}}
>
{{#if (has-block)}}
{{yield}}
{{else}}
Expand All @@ -9,4 +14,4 @@
</span>
</div>
{{/if}}
</a>
</ExternalLink>
4 changes: 2 additions & 2 deletions ui/app/templates/components/pki/config-pki-ca.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,9 +208,9 @@
</p>
{{#each this.downloadHrefs as |dl|}}
<div class="box is-shadowless is-marginless is-fullwidth has-slim-padding">
<a data-test-ca-download-link href={{dl.url}} download={{dl.name}}>
<ExternalLink @href={{dl.url}} @sameTab={{true}} download={{dl.name}} data-test-ca-download-link>
{{dl.display}}
</a>
</ExternalLink>
</div>
{{/each}}

Expand Down
7 changes: 4 additions & 3 deletions ui/app/templates/components/raft-storage-overview.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,13 @@
<ul class="menu-list">
<li class="action">
{{#if this.useServiceWorker}}
<a
href="/v1/sys/storage/raft/snapshot"
<ExternalLink
@href="/v1/sys/storage/raft/snapshot"
@sameTab={{true}}
onclick={{queue (action "downloadViaServiceWorker") (action D.actions.close)}}
>
Download
</a>
</ExternalLink>
{{else}}
<button
type="button"
Expand Down
4 changes: 2 additions & 2 deletions ui/lib/core/addon/templates/components/replication-secondary-card.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,10 +85,10 @@
</div>
{{#if (and this.primaryUiUrl this.knownPrimaryClusterAddrs)}}
<div class="grid-item-top-right">
<a href={{concat this.primaryUiUrl "/ui/"}} class="toolbar-link" data-test-primary-link>
<ExternalLink @href={{concat this.primaryUiUrl "/ui/"}} class="toolbar-link" data-test-primary-link>
View primary cluster
<Icon @name="chevron-right" />
</a>
</ExternalLink>
</div>
{{/if}}
<div class="grid-item-second-row">
Expand Down