UI: Update <a> tags to LinkTo's #17866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zofskeez
reviewed
Nov 9, 2022
hashishaw
changed the title
zofskeez
approved these changes
Nov 10, 2022
Comment on lines
+18
to
+20
| get href() { | ||
| return this.args.href; | ||
| } |
There was a problem hiding this comment.
Can this arg be accessed directly in the template instead?
There was a problem hiding this comment.
This one we want to keep, because the DocLink and LearnLink extend this component, and their hrefs are always a getter not a passed param
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<a>tags have different behavior than<LinkTo>within our app with regards to keeping root users logged in on page load. This change is to make sure we're using<a>tags as minimally as possible. All the current implementations of these tags are legitimate (they correctly reload the page or link to an external site) but to consolidate their usage I created a newExternalLinkcomponent, and glimmerizedDocLinkandLearnLinkso they can extend this new component.Something I considered that is out of scope of this ticket, is using the HDS Links instead, but I think that should be follow-on work