Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: update formatting for go code and add CI check #19929

Conversation

modular-magician
Copy link
Collaborator

Some go files in the project were not formatted. Add a CI check which should fail when files are not formatted; a second commit will then pass with the gofmt -w fixes.

Failing check without all files formatted:
https://github.com/GoogleCloudPlatform/magic-modules/actions/runs/11391921639/job/31696780814?pr=12040

Release Note Template for Downstream PRs (will be copied)


Derived from GoogleCloudPlatform/magic-modules#12040

Co-authored-by: Scott Suarez <ScottSuarez@google.com>

[upstream:f9d373896d87faaf79e81d08da12dbe2be9a573d]

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit 1ee045f into hashicorp:main Oct 18, 2024
4 checks passed
@modular-magician modular-magician deleted the downstream-pr-f9d373896d87faaf79e81d08da12dbe2be9a573d branch November 17, 2024 02:53
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant