style: update formatting for go code and add CI check #12040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modular-magician
added
the
awaiting-approval
wyardley
force-pushed
the
wyardley/ci/gofmt
branch
from
20a26be to
24ede51
Compare
|
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
wyardley
force-pushed
the
wyardley/ci/gofmt
branch
from
24ede51 to
526bdcb
Compare
rileykarson
requested review from
ScottSuarez
and removed request for
rileykarson
wyardley
commented
Oct 17, 2024
wyardley
force-pushed
the
wyardley/ci/gofmt
branch
2 times, most recently
from
8335ecc to
9291018
Compare
|
/gcbrun |
ScottSuarez
requested changes
Oct 18, 2024
wyardley
force-pushed
the
wyardley/ci/gofmt
branch
from
9291018 to
1421c09
Compare
|
I assume |
ScottSuarez
reviewed
Oct 18, 2024
|
I needed to make some changes out of band to allow the build to go through. It should run now /gcbrun |
modular-magician
removed
the
awaiting-approval
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR hasn't generated any diffs, but I'll let you know if a future commit does. |
ScottSuarez
approved these changes
Oct 18, 2024
gontech
pushed a commit
to gontech/magic-modules
that referenced
this pull request
Oct 21, 2024
…tform#12040) Co-authored-by: Scott Suarez <ScottSuarez@google.com>
BBBmau
pushed a commit
to BBBmau/magic-modules
that referenced
this pull request
Oct 23, 2024
…tform#12040) Co-authored-by: Scott Suarez <ScottSuarez@google.com>
BBBmau
pushed a commit
to BBBmau/magic-modules
that referenced
this pull request
Oct 24, 2024
…tform#12040) Co-authored-by: Scott Suarez <ScottSuarez@google.com>
BBBmau
pushed a commit
to BBBmau/magic-modules
that referenced
this pull request
Nov 5, 2024
…tform#12040) Co-authored-by: Scott Suarez <ScottSuarez@google.com>
akshat-jindal-nit
pushed a commit
to akshat-jindal-nit/magic-modules
that referenced
this pull request
Nov 18, 2024
…tform#12040) Co-authored-by: Scott Suarez <ScottSuarez@google.com>
amanMahendroo
pushed a commit
to amanMahendroo/magic-modules
that referenced
this pull request
Dec 17, 2024
…tform#12040) Co-authored-by: Scott Suarez <ScottSuarez@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some go files in the project were not formatted. Add a CI check which should fail when files are not formatted; a second commit will then pass with the
gofmt -wfixes.Failing check without all files formatted:
https://github.com/GoogleCloudPlatform/magic-modules/actions/runs/11391921639/job/31696780814?pr=12040
Release Note Template for Downstream PRs (will be copied)