Enhance - all machine learning resource - bump API to `v2022-05-01` #18279

xuzhang3 · 2022-09-07T08:10:18Z

Fixes: #16177 #16836 #17170
API issue: Azure/azure-rest-api-specs#18601

This PR will bump the machine learning APIs from 2021-07-01 to 2022-05-01.
azurerm_machine_learning_workspace support new config: public_network_access_enabled and v1_legacy_mode
ping @stephybun as you renamed public_access_behind_virtual_network_enabled in azurerm_machine_learning_workspace - rename public_network_access_enabled #16288 and mark this property to be deprecate in v4 . There is a API breaking change after v2021-10-01(@deeikele to clarify if I'm wrong), allowPublicAccessWhenBehindVnet will be replaced by publicNetworkAccess. In this PR public_access_behind_virtual_network_enabled will be deprecated and replaced by public_network_access_enabled, also I removed the version judugment and put public_network_access_enabled in the general config.


=== RUN   TestAccComputeCluster_basic
=== PAUSE TestAccComputeCluster_basic
=== RUN   TestAccComputeCluster_complete
=== PAUSE TestAccComputeCluster_complete
=== RUN   TestAccComputeCluster_recreateVmSize
=== PAUSE TestAccComputeCluster_recreateVmSize
=== RUN   TestAccComputeCluster_requiresImport
=== PAUSE TestAccComputeCluster_requiresImport
=== RUN   TestAccComputeCluster_identity
--- PASS: TestAccComputeCluster_identity (1779.83s)
=== CONT  TestAccComputeCluster_basic
=== CONT  TestAccComputeCluster_recreateVmSize
=== CONT  TestAccComputeCluster_requiresImport
=== CONT  TestAccComputeCluster_complete
--- PASS: TestAccComputeCluster_complete (548.21s)
--- PASS: TestAccComputeCluster_basic (606.31s)
--- PASS: TestAccComputeCluster_requiresImport (635.06s)
--- PASS: TestAccComputeCluster_recreateVmSize (1064.32s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/machinelearning       2903.394s

=== RUN   TestAccComputeInstance_basic
=== PAUSE TestAccComputeInstance_basic
=== RUN   TestAccComputeInstance_complete
=== PAUSE TestAccComputeInstance_complete
=== RUN   TestAccComputeInstance_requiresImport
=== PAUSE TestAccComputeInstance_requiresImport
=== RUN   TestAccComputeInstance_identity
--- PASS: TestAccComputeInstance_identity (3617.08s)
=== CONT  TestAccComputeInstance_basic
=== CONT  TestAccComputeInstance_requiresImport
=== CONT  TestAccComputeInstance_complete
--- PASS: TestAccComputeInstance_complete (1219.26s)
--- PASS: TestAccComputeInstance_requiresImport (1311.09s)
--- PASS: TestAccComputeInstance_basic (1350.10s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/machinelearning       5009.971s

=== RUN   TestAccInferenceCluster_basic
=== PAUSE TestAccInferenceCluster_basic
=== RUN   TestAccInferenceCluster_privateBasic
=== PAUSE TestAccInferenceCluster_privateBasic
=== RUN   TestAccInferenceCluster_requiresImport
=== PAUSE TestAccInferenceCluster_requiresImport
=== RUN   TestAccInferenceCluster_completeCustomSSL
=== PAUSE TestAccInferenceCluster_completeCustomSSL
=== RUN   TestAccInferenceCluster_completeMicrosoftSSL
=== PAUSE TestAccInferenceCluster_completeMicrosoftSSL
=== RUN   TestAccInferenceCluster_completeProduction
=== PAUSE TestAccInferenceCluster_completeProduction
=== RUN   TestAccInferenceCluster_identity
--- PASS: TestAccInferenceCluster_identity (2359.46s)
=== CONT  TestAccInferenceCluster_basic
=== CONT  TestAccInferenceCluster_completeCustomSSL
=== CONT  TestAccInferenceCluster_requiresImport
=== CONT  TestAccInferenceCluster_completeProduction
=== CONT  TestAccInferenceCluster_privateBasic
=== CONT  TestAccInferenceCluster_completeMicrosoftSSL
--- PASS: TestAccInferenceCluster_basic (1041.43s)
--- PASS: TestAccInferenceCluster_requiresImport (1072.91s)
--- PASS: TestAccInferenceCluster_completeCustomSSL (1111.42s)
--- PASS: TestAccInferenceCluster_completeProduction (1151.63s)
--- PASS: TestAccInferenceCluster_completeMicrosoftSSL (1455.10s)
=== CONT  TestAccInferenceCluster_privateBasic
--- PASS: TestAccInferenceCluster_privateBasic (2034.70s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/machinelearning       4456.433s

=== RUN   TestAccSynapseSpark_basic
=== PAUSE TestAccSynapseSpark_basic
=== RUN   TestAccSynapseSpark_complete
=== PAUSE TestAccSynapseSpark_complete
=== RUN   TestAccSynapseSpark_requiresImport
=== PAUSE TestAccSynapseSpark_requiresImport
=== RUN   TestAccSynapseSpark_identity
--- PASS: TestAccSynapseSpark_identity (1942.22s)
=== CONT  TestAccSynapseSpark_basic
=== CONT  TestAccSynapseSpark_requiresImport
=== CONT  TestAccSynapseSpark_complete
--- PASS: TestAccSynapseSpark_complete (989.46s)
--- PASS: TestAccSynapseSpark_basic (1193.97s)
--- PASS: TestAccSynapseSpark_requiresImport (1290.35s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/machinelearning       3254.661s

=== RUN   TestAccMachineLearningWorkspaceDataSource_basic
=== PAUSE TestAccMachineLearningWorkspaceDataSource_basic
=== CONT  TestAccMachineLearningWorkspaceDataSource_basic
--- PASS: TestAccMachineLearningWorkspaceDataSource_basic (1905.25s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/machinelearning       1919.248s

=== RUN   TestAccMachineLearningWorkspace_basic
=== PAUSE TestAccMachineLearningWorkspace_basic
=== RUN   TestAccMachineLearningWorkspace_requiresImport
=== RUN   TestAccMachineLearningWorkspace_basicUpdate
=== PAUSE TestAccMachineLearningWorkspace_basicUpdate
=== RUN   TestAccMachineLearningWorkspace_complete
=== PAUSE TestAccMachineLearningWorkspace_complete
=== RUN   TestAccMachineLearningWorkspace_completeUpdate
=== RUN   TestAccMachineLearningWorkspace_userAssignedIdentity
=== PAUSE TestAccMachineLearningWorkspace_userAssignedIdentity
=== RUN   TestAccMachineLearningWorkspace_systemAssignedUserAssignedIdentity
=== PAUSE TestAccMachineLearningWorkspace_systemAssignedUserAssignedIdentity
=== RUN   TestAccMachineLearningWorkspace_identityUpdate
=== PAUSE TestAccMachineLearningWorkspace_identityUpdate
=== RUN   TestAccMachineLearningWorkspace_identityTypeUpdate
=== PAUSE TestAccMachineLearningWorkspace_identityTypeUpdate
=== RUN   TestAccMachineLearningWorkspace_userAssignedAndCustomManagedKey
=== PAUSE TestAccMachineLearningWorkspace_userAssignedAndCustomManagedKey
=== RUN   TestAccMachineLearningWorkspace_systemAssignedAndCustomManagedKey
=== PAUSE TestAccMachineLearningWorkspace_systemAssignedAndCustomManagedKey
=== CONT  TestAccMachineLearningWorkspace_basic
=== CONT  TestAccMachineLearningWorkspace_systemAssignedAndCustomManagedKey
=== CONT  TestAccMachineLearningWorkspace_userAssignedIdentity
=== CONT  TestAccMachineLearningWorkspace_complete
=== CONT  TestAccMachineLearningWorkspace_basicUpdate
=== CONT  TestAccMachineLearningWorkspace_completeUpdate
=== CONT  TestAccMachineLearningWorkspace_userAssignedAndCustomManagedKey
=== CONT  TestAccMachineLearningWorkspace_identityTypeUpdate
--- PASS: TestAccMachineLearningWorkspace_basic (517.36s)
=== CONT  TestAccMachineLearningWorkspace_requiresImport
--- PASS: TestAccMachineLearningWorkspace_userAssignedIdentity (566.79s)
=== CONT  TestAccMachineLearningWorkspace_identityUpdate
--- PASS: TestAccMachineLearningWorkspace_basicUpdate (696.34s)
=== CONT  TestAccMachineLearningWorkspace_systemAssignedUserAssignedIdentity
--- PASS: TestAccMachineLearningWorkspace_requiresImport (513.10s)
--- PASS: TestAccMachineLearningWorkspace_systemAssignedUserAssignedIdentity (445.93s)
--- PASS: TestAccMachineLearningWorkspace_identityTypeUpdate (1155.64s)
--- PASS: TestAccMachineLearningWorkspace_systemAssignedAndCustomManagedKey (2259.08s)
--- PASS: TestAccMachineLearningWorkspace_userAssignedAndCustomManagedKey (2285.39s)
--- PASS: TestAccMachineLearningWorkspace_completeUpdate (3162.84s)
PASS
ok    github.com/hashicorp/terraform-provider-azurerm/internal/services/machinelearning       3191.396s

* update testcase

mingweihe · 2022-09-08T22:06:27Z

internal/services/machinelearning/machine_learning_compute_instance_resource_test.go

+  application_insights_id       = azurerm_application_insights.test.id
+  key_vault_id                  = azurerm_key_vault.test.id
+  storage_account_id            = azurerm_storage_account.test.id
+  public_network_access_enabled = true


The type should be enum, not boolean, it's not like binary.
It could be many possible values, such as "Enabled", "Disabled", "EnabledForSpecificNetwork", etc.

Normally if the enum value only have enable/disable, we will convert it to boolean, if the possible values more then two, I will change it back.

currently afaik it only supports two values in nearly every resource. if another value is ever add we can always deprecate the property and add non boolean property

yes, please.

Could you please keep this to an enum type for consistency with the Azure APIs?

@katbyte @deeikele and @mingweihe are from MLW service team, they suggest we should keep the enum type consistecy with the AzureAPI and a potential type EnabledForSpecificNetwork will be added in the future.

@katbyte @deeikele and @mingweihe are from MLW service team, they suggest we should keep the enum type consistecy with the AzureAPI and a potential type EnabledForSpecificNetwork will be added in the future.

Exactly, I also synced up with the team, they mentioned even though the swagger's having two values for the properties, the new value will be added later.

I can understand terraform has its own code change policy, while this is really a particular case, keeping a mismatched type there is not suitable for future maintenance.

Meanwhile, I think it's good to follow Azure APIs mostly, enum type with two values auto-changing to boolean policy is interesting, but not that suitable here.

To amplify Mingwei's response boolean type is not appropriate here. Reference to enum implementation is found in Iot Hub (https://learn.microsoft.com/en-us/azure/iot-hub/iot-hub-public-network-access) selected IP ranges accepted value.

internal/services/machinelearning/machine_learning_workspace_resource.go

* public_access_behind_virtual_network_enabled deprecate switch

katbyte

as discussed internally LGTM ⚙️

github-actions · 2022-09-30T01:48:00Z

This functionality has been released in v3.25.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

github-actions · 2022-10-30T02:41:40Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

xuzhang3 added 18 commits June 23, 2022 13:43

migrate machine leanring computer to pandora SDK

f716119

upgrade MLW sdk from v2021-07-01 to v2022-05-01

cd777ed

* support v1_legacy_mode

0d55cf9

* update testcase

merge upstream

a7c25f0

update vendor

4d08775

update API ref

aefc5d8

delete test code

693a7ca

update identity expand/flatten

9a1d07b

update testcase

2b3d495

update property name

4dff195

update from upstream

b66e7cd

identity update test case

07df50f

Merge remote-tracking branch 'origin/main' into f/mlw_enhance

48b4f26

merge upstream

ac60919

update test case

1bc40de

merge upstream

549cecf

merge upstream

01ae761

update doc

315c809

github-actions bot added dependencies documentation service/machine-learning labels Sep 7, 2022

fix linter

9e57f11

mingweihe suggested changes Sep 8, 2022

View reviewed changes

github-actions bot added waiting-response and removed waiting-response labels Sep 9, 2022

katbyte requested changes Sep 15, 2022

View reviewed changes

github-actions bot added the waiting-response label Sep 15, 2022

* rename v1_legacy_mode to v1_legacy_mode_enabled

871febe

* public_access_behind_virtual_network_enabled deprecate switch

github-actions bot removed the waiting-response label Sep 16, 2022

merge upstream/main

7f853aa

katbyte approved these changes Sep 27, 2022

View reviewed changes

katbyte merged commit 2f542bb into hashicorp:main Sep 27, 2022

github-actions bot added this to the v3.25.0 milestone Sep 27, 2022

stephybun mentioned this pull request Oct 20, 2022

Fixing incorrect deprecation notice #16624

Closed

github-actions bot locked as resolved and limited conversation to collaborators Oct 30, 2022

xuzhang3 deleted the f/mlw_enhance branch August 14, 2024 02:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enhance - all machine learning resource - bump API to `v2022-05-01` #18279

Enhance - all machine learning resource - bump API to `v2022-05-01` #18279

xuzhang3 commented Sep 7, 2022

mingweihe Sep 8, 2022

xuzhang3 Sep 9, 2022

katbyte Sep 9, 2022

mingweihe Sep 9, 2022

deeikele Sep 9, 2022 •

edited

Loading

xuzhang3 Sep 13, 2022

mingweihe Sep 13, 2022 •

edited

Loading

deeikele Sep 27, 2022

katbyte left a comment

github-actions bot commented Sep 30, 2022

github-actions bot commented Oct 30, 2022

Enhance - all machine learning resource - bump API to v2022-05-01 #18279

Enhance - all machine learning resource - bump API to v2022-05-01 #18279

Conversation

xuzhang3 commented Sep 7, 2022

mingweihe Sep 8, 2022

Choose a reason for hiding this comment

xuzhang3 Sep 9, 2022

Choose a reason for hiding this comment

katbyte Sep 9, 2022

Choose a reason for hiding this comment

mingweihe Sep 9, 2022

Choose a reason for hiding this comment

deeikele Sep 9, 2022 • edited Loading

Choose a reason for hiding this comment

xuzhang3 Sep 13, 2022

Choose a reason for hiding this comment

mingweihe Sep 13, 2022 • edited Loading

Choose a reason for hiding this comment

deeikele Sep 27, 2022

Choose a reason for hiding this comment

katbyte left a comment

Choose a reason for hiding this comment

github-actions bot commented Sep 30, 2022

github-actions bot commented Oct 30, 2022

Enhance - all machine learning resource - bump API to `v2022-05-01` #18279

Enhance - all machine learning resource - bump API to `v2022-05-01` #18279

deeikele Sep 9, 2022 •

edited

Loading

mingweihe Sep 13, 2022 •

edited

Loading