Support for azure machinelearning workspace publicNetworkAccess and v1LegacyMode

[mingweihe]

Is there an existing issue for this?

• I have searched the existing issues

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

Hi terraform community,
I'm from the Azure machine learning workspace team, recently we've had some updates on properties listed below, please help make the corresponding changes. @mbfrahry I saw you had active update on the source file https://github.com/hashicorp/terraform-provider-azurerm/blob/9503c16eb96068725dd41007c72e3333c2d93b5b/internal/services/machinelearning/machine_learning_workspace_resource.go, please help take care, thanks a lot! Feel free to let me know if you or you team have questions.

Description

1. allowPublicAccessWhenBehindVnet(bool->true/false) is being deprecated, better to be removed.
2. The new property to replace allowPublicAccessWhenBehindVnet is publicNetworkAccess(enum->Enabled/Disabled)
3. A new property v1LegacyMode(bool->true/false) is added, which is for sdk/cli v1->v2 transition, it will prevent using v2 API service on public Azure Resource Manager if you set this parameter to true. Learn more at aka.ms/amlv2network

New or Affected Resource(s)/Data Source(s)

azurerm_machine_learning_workspace

Potential Terraform Configuration

# Machine Learning workspace config example
resource "azurerm_machine_learning_workspace" "default" {
  name                    = "mlw-${var.name}-${var.environment}"
  location                = azurerm_resource_group.default.location
  resource_group_name     = azurerm_resource_group.default.name
  application_insights_id = azurerm_application_insights.default.id
  key_vault_id            = azurerm_key_vault.default.id
  storage_account_id      = azurerm_storage_account.default.id
  container_registry_id   = azurerm_container_registry.default.id

  identity {
    type = "SystemAssigned"
  }

  # Args of use when using an Azure Private Link configuration
  public_network_access_enabled = false # default is true
  v1_legacy_mode = true # default is false
  image_build_compute_name      = var.image_build_compute_name
  depends_on = [
    azurerm_private_endpoint.kv_ple,
    azurerm_private_endpoint.st_ple_blob,
    azurerm_private_endpoint.storage_ple_file,
    azurerm_private_endpoint.cr_ple,
    azurerm_subnet.snet-training
  ]
}

References

https://docs.microsoft.com/en-us/cli/azure/ml/workspace?view=azure-cli-latest#az-ml-workspace-create-optional-parameters
http://aka.ms/amlv2network