-
Notifications
You must be signed in to change notification settings - Fork 9.7k
Add ARN-based resource identity to SSMContacts #44369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+391
−15
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
a3517ad
Changes for Resource Identity: aws_ssmcontacts_contact_channel
its2shar 56ee18e
r/aws_ssmcontacts_contact_channel: add resource identity
its2shar 9434d0e
Merge remote-tracking branch 'origin' into f-ri-ssmcontacts
its2shar 7d620a3
r/aws_ssmcontacts_contact_channel: add resource identity
its2shar 631858a
r/aws_ssmcontacts_contact_channel: add resource identity
its2shar 9ab04a1
r/aws_ssmcontacts_contact_channel: add resource identity
its2shar 36a8943
Serialize tests
its2shar 722c26d
Merge remote-tracking branch 'origin' into f-ri-ssmcontacts
its2shar 154c764
r/aws_ssmcontacts_contact_channel: add resource identity
its2shar 0a28569
r/aws_ssmcontacts_contact_channel: add resource identity
its2shar 6db622c
r/aws_ssmcontacts_contact_channel: add resource identity
its2shar 8c0e11a
r/aws_ssmcontacts_contact_channel: add resource identity
its2shar 5bf20cf
r/aws_ssmcontacts_contact_channel: add resource identity
its2shar a99bfc4
r/aws_ssmcontacts_contact_channel: add resource identity
its2shar 2c9f8d7
r/aws_ssmcontacts_contact_channel(doc): tidy import section
jar-b 0cf1b36
Merge branch 'main' into f-ri-ssmcontacts
jar-b 15c9498
r/aws_ssmcontacts_contact_channel(test): re-gen after merge, track ne…
jar-b 4f26cde
r/aws_ssmcontacts_contact_channel(test): fix for generated identity s…
jar-b 9b27de7
r/aws_ssmcontacts_contact_channel(test): contact channel does not sup…
jar-b File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
```release-note:enhancement | ||
resource/aws_ssmcontacts_contact_channel: Add resource identity support | ||
``` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
228 changes: 228 additions & 0 deletions
228
internal/service/ssmcontacts/contact_channel_identity_gen_test.go
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
36 changes: 36 additions & 0 deletions
36
internal/service/ssmcontacts/testdata/ContactChannel/basic/main_gen.tf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
# Copyright (c) HashiCorp, Inc. | ||
# SPDX-License-Identifier: MPL-2.0 | ||
|
||
resource "aws_ssmcontacts_contact_channel" "test" { | ||
contact_id = aws_ssmcontacts_contact.test.arn | ||
|
||
delivery_address { | ||
simple_address = "test@example.com" | ||
} | ||
|
||
name = var.rName | ||
type = "EMAIL" | ||
} | ||
|
||
resource "aws_ssmcontacts_contact" "test" { | ||
alias = "test-contact-for-${var.rName}" | ||
type = "PERSONAL" | ||
|
||
depends_on = [aws_ssmincidents_replication_set.test] | ||
} | ||
|
||
# testAccContactChannelConfig_base | ||
|
||
resource "aws_ssmincidents_replication_set" "test" { | ||
region { | ||
name = data.aws_region.current.region | ||
} | ||
} | ||
|
||
data "aws_region" "current" {} | ||
|
||
variable "rName" { | ||
description = "Name for resource" | ||
type = string | ||
nullable = false | ||
} |
46 changes: 46 additions & 0 deletions
46
internal/service/ssmcontacts/testdata/ContactChannel/basic_v6.14.1/main_gen.tf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,46 @@ | ||
# Copyright (c) HashiCorp, Inc. | ||
# SPDX-License-Identifier: MPL-2.0 | ||
|
||
resource "aws_ssmcontacts_contact_channel" "test" { | ||
contact_id = aws_ssmcontacts_contact.test.arn | ||
|
||
delivery_address { | ||
simple_address = "test@example.com" | ||
} | ||
|
||
name = var.rName | ||
type = "EMAIL" | ||
} | ||
|
||
resource "aws_ssmcontacts_contact" "test" { | ||
alias = "test-contact-for-${var.rName}" | ||
type = "PERSONAL" | ||
|
||
depends_on = [aws_ssmincidents_replication_set.test] | ||
} | ||
|
||
# testAccContactChannelConfig_base | ||
|
||
resource "aws_ssmincidents_replication_set" "test" { | ||
region { | ||
name = data.aws_region.current.region | ||
} | ||
} | ||
|
||
data "aws_region" "current" {} | ||
|
||
variable "rName" { | ||
description = "Name for resource" | ||
type = string | ||
nullable = false | ||
} | ||
terraform { | ||
required_providers { | ||
aws = { | ||
source = "hashicorp/aws" | ||
version = "6.14.1" | ||
} | ||
} | ||
} | ||
|
||
provider "aws" {} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.