Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
a3517ad
Changes for Resource Identity: aws_ssmcontacts_contact_channel
its2shar Sep 17, 2025
56ee18e
r/aws_ssmcontacts_contact_channel: add resource identity
its2shar Sep 19, 2025
9434d0e
Merge remote-tracking branch 'origin' into f-ri-ssmcontacts
its2shar Sep 19, 2025
7d620a3
r/aws_ssmcontacts_contact_channel: add resource identity
its2shar Sep 19, 2025
631858a
r/aws_ssmcontacts_contact_channel: add resource identity
its2shar Sep 19, 2025
9ab04a1
r/aws_ssmcontacts_contact_channel: add resource identity
its2shar Sep 19, 2025
36a8943
Serialize tests
its2shar Sep 24, 2025
722c26d
Merge remote-tracking branch 'origin' into f-ri-ssmcontacts
its2shar Sep 24, 2025
154c764
r/aws_ssmcontacts_contact_channel: add resource identity
its2shar Sep 24, 2025
0a28569
r/aws_ssmcontacts_contact_channel: add resource identity
its2shar Sep 24, 2025
6db622c
r/aws_ssmcontacts_contact_channel: add resource identity
its2shar Sep 24, 2025
8c0e11a
r/aws_ssmcontacts_contact_channel: add resource identity
its2shar Sep 24, 2025
5bf20cf
r/aws_ssmcontacts_contact_channel: add resource identity
its2shar Sep 25, 2025
a99bfc4
r/aws_ssmcontacts_contact_channel: add resource identity
its2shar Sep 25, 2025
2c9f8d7
r/aws_ssmcontacts_contact_channel(doc): tidy import section
jar-b Sep 25, 2025
0cf1b36
Merge branch 'main' into f-ri-ssmcontacts
jar-b Sep 25, 2025
15c9498
r/aws_ssmcontacts_contact_channel(test): re-gen after merge, track ne…
jar-b Sep 25, 2025
4f26cde
r/aws_ssmcontacts_contact_channel(test): fix for generated identity s…
jar-b Sep 25, 2025
9b27de7
r/aws_ssmcontacts_contact_channel(test): contact channel does not sup…
jar-b Sep 25, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .changelog/44369.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:enhancement
resource/aws_ssmcontacts_contact_channel: Add resource identity support
```
8 changes: 4 additions & 4 deletions internal/service/ssmcontacts/contact_channel.go
Original file line number Diff line number Diff line change
Expand Up @@ -20,17 +20,17 @@ import (
)

// @SDKResource("aws_ssmcontacts_contact_channel", name="Contact Channel")
// @ArnIdentity
// @Testing(identityRegionOverrideTest=false)
// @Testing(serialize=true)
// @Testing(preIdentityVersion="v6.14.1")
func ResourceContactChannel() *schema.Resource {
return &schema.Resource{
CreateWithoutTimeout: resourceContactChannelCreate,
ReadWithoutTimeout: resourceContactChannelRead,
UpdateWithoutTimeout: resourceContactChannelUpdate,
DeleteWithoutTimeout: resourceContactChannelDelete,

Importer: &schema.ResourceImporter{
StateContext: schema.ImportStatePassthroughContext,
},

Schema: map[string]*schema.Schema{
"activation_status": {
Type: schema.TypeString,
Expand Down
228 changes: 228 additions & 0 deletions internal/service/ssmcontacts/contact_channel_identity_gen_test.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions internal/service/ssmcontacts/service_package_gen.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

23 changes: 14 additions & 9 deletions internal/service/ssmcontacts/ssmcontacts_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,9 @@ func TestAccSSMContacts_serial(t *testing.T) {
acctest.CtDisappears: testAccContactChannel_disappears,
acctest.CtName: testAccContactChannel_name,
"type": testAccContactChannel_type,
"identity": testAccSSMContactsContactChannel_IdentitySerial,
// TODO: this should be included in the generated _IdentitySerial
"identityExistingResourceNoRefresh": testAccSSMContactsContactChannel_Identity_ExistingResource_NoRefresh_NoChange,
},
"ContactChannelDataSource": {
acctest.CtBasic: testAccContactChannelDataSource_basic,
Expand All @@ -53,15 +56,17 @@ func TestAccSSMContacts_serial(t *testing.T) {
"channelTargetInfo": testAccPlanDataSource_channelTargetInfo,
},
"RotationResource": {
acctest.CtBasic: testAccRotation_basic,
acctest.CtDisappears: testAccRotation_disappears,
"update": testAccRotation_updateRequiredFields,
"startTime": testAccRotation_startTime,
"contactIds": testAccRotation_contactIds,
"recurrence": testAccRotation_recurrence,
"tags": testAccSSMContactsRotation_tagsSerial,
"Identity": testAccSSMContactsRotation_IdentitySerial,
"Identity_RegionOverride": testAccSSMContactsRotation_Identity_RegionOverride,
acctest.CtBasic: testAccRotation_basic,
acctest.CtDisappears: testAccRotation_disappears,
"update": testAccRotation_updateRequiredFields,
"startTime": testAccRotation_startTime,
"contactIds": testAccRotation_contactIds,
"recurrence": testAccRotation_recurrence,
"tags": testAccSSMContactsRotation_tagsSerial,
"identity": testAccSSMContactsRotation_IdentitySerial,
// TODO: these should be included in the generated _IdentitySerial
"identityExistingResourceNoRefresh": testAccSSMContactsRotation_Identity_ExistingResource_NoRefresh_NoChange,
"identityRegionOverride": testAccSSMContactsRotation_Identity_RegionOverride,
},
"RotationDataSource": {
acctest.CtBasic: testAccRotationDataSource_basic,
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
# Copyright (c) HashiCorp, Inc.
# SPDX-License-Identifier: MPL-2.0

resource "aws_ssmcontacts_contact_channel" "test" {
contact_id = aws_ssmcontacts_contact.test.arn

delivery_address {
simple_address = "test@example.com"
}

name = var.rName
type = "EMAIL"
}

resource "aws_ssmcontacts_contact" "test" {
alias = "test-contact-for-${var.rName}"
type = "PERSONAL"

depends_on = [aws_ssmincidents_replication_set.test]
}

# testAccContactChannelConfig_base

resource "aws_ssmincidents_replication_set" "test" {
region {
name = data.aws_region.current.region
}
}

data "aws_region" "current" {}

variable "rName" {
description = "Name for resource"
type = string
nullable = false
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
# Copyright (c) HashiCorp, Inc.
# SPDX-License-Identifier: MPL-2.0

resource "aws_ssmcontacts_contact_channel" "test" {
contact_id = aws_ssmcontacts_contact.test.arn

delivery_address {
simple_address = "test@example.com"
}

name = var.rName
type = "EMAIL"
}

resource "aws_ssmcontacts_contact" "test" {
alias = "test-contact-for-${var.rName}"
type = "PERSONAL"

depends_on = [aws_ssmincidents_replication_set.test]
}

# testAccContactChannelConfig_base

resource "aws_ssmincidents_replication_set" "test" {
region {
name = data.aws_region.current.region
}
}

data "aws_region" "current" {}

variable "rName" {
description = "Name for resource"
type = string
nullable = false
}
terraform {
required_providers {
aws = {
source = "hashicorp/aws"
version = "6.14.1"
}
}
}

provider "aws" {}
Loading
Loading