-
Notifications
You must be signed in to change notification settings - Fork 9.7k
Add ARN-based resource identity to SSMContacts #44369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Community GuidelinesThis comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀 Voting for Prioritization
Pull Request Authors
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to create a changelog:
.changelog/<pr-number>.txt
internal/service/ssmcontacts/testdata/tmpl/contact_channel_tags.gtpl
Outdated
Show resolved
Hide resolved
# testAccContactChannelConfig_base | ||
|
||
data "aws_ssmincidents_replication_set" "test" {} No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't match the base config from the standard tests. It creates a replication set resource, e.g.
func testAccContactChannelConfig_base() string {
return fmt.Sprintf(`
resource "aws_ssmincidents_replication_set" "test" {
region {
name = %[1]q
}
}
`, acctest.Region())
}
This discrepancy is causing the acceptance tests to fail.
=== RUN TestAccSSMContacts_serial/ContactChannelResource/identity_ExistingResource
contact_channel_identity_gen_test.go:125: Step 1/2 error: Error running pre-apply plan: exit status 1
Error: reading SSMIncidents Replication Set: empty result
with data.aws_ssmincidents_replication_set.test,
on main_gen.tf line 24, in data "aws_ssmincidents_replication_set" "test":
24: data "aws_ssmincidents_replication_set" "test" {}
"identity_Basic": testAccSSMContactsContactChannel_Identity_Basic, | ||
"identity_ExistingResource": testAccSSMContactsContactChannel_Identity_ExistingResource, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets remove the _
here for consistency with other test names.
"identity_Basic": testAccSSMContactsContactChannel_Identity_Basic, | |
"identity_ExistingResource": testAccSSMContactsContactChannel_Identity_ExistingResource, | |
"identityBasic": testAccSSMContactsContactChannel_Identity_Basic, | |
"identityExistingResource": testAccSSMContactsContactChannel_Identity_ExistingResource, |
type = "PERSONAL" | ||
|
||
depends_on = [data.aws_ssmincidents_replication_set.test] | ||
{{- template "tags" . }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exclude the tags template for any resources which are not the primary subject of the test case.
{{- template "tags" . }} |
Description
Add resource identity to ARN-based resources in SSMContacts. This includes:
Relations
Relates #42983
Relates #42984
Output from Acceptance Testing