Skip to content

r/aws_cognito_managed_login_branding: New resource. #43817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 59 commits into from
Sep 4, 2025
Merged

r/aws_cognito_managed_login_branding: New resource. #43817

merged 59 commits into from
Sep 4, 2025

Conversation

@ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Aug 11, 2025 •
edited
Loading

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Description

New resource aws_cognito_managed_login_branding.

Relations

Closes #42580.
Closes #33721.
Relates #42757.

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccCognitoIDPManagedLoginBranding_' PKG=cognitoidp ACCTEST_PARALLELISM=2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.24.6 test ./internal/service/cognitoidp/... -v -count 1 -parallel 2  -run=TestAccCognitoIDPManagedLoginBranding_ -timeout 360m -vet=off
2025/09/04 10:12:24 Creating Terraform AWS Provider (SDKv2-style)...
2025/09/04 10:12:24 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccCognitoIDPManagedLoginBranding_basic
=== PAUSE TestAccCognitoIDPManagedLoginBranding_basic
=== RUN   TestAccCognitoIDPManagedLoginBranding_disappears
=== PAUSE TestAccCognitoIDPManagedLoginBranding_disappears
=== RUN   TestAccCognitoIDPManagedLoginBranding_asset
=== PAUSE TestAccCognitoIDPManagedLoginBranding_asset
=== RUN   TestAccCognitoIDPManagedLoginBranding_settings
=== PAUSE TestAccCognitoIDPManagedLoginBranding_settings
=== RUN   TestAccCognitoIDPManagedLoginBranding_updateFromBasic
=== PAUSE TestAccCognitoIDPManagedLoginBranding_updateFromBasic
=== RUN   TestAccCognitoIDPManagedLoginBranding_updateToBasic
=== PAUSE TestAccCognitoIDPManagedLoginBranding_updateToBasic
=== RUN   TestAccCognitoIDPManagedLoginBranding_updateSettings
=== PAUSE TestAccCognitoIDPManagedLoginBranding_updateSettings
=== CONT  TestAccCognitoIDPManagedLoginBranding_basic
=== CONT  TestAccCognitoIDPManagedLoginBranding_updateFromBasic
--- PASS: TestAccCognitoIDPManagedLoginBranding_basic (20.35s)
=== CONT  TestAccCognitoIDPManagedLoginBranding_updateSettings
--- PASS: TestAccCognitoIDPManagedLoginBranding_updateFromBasic (29.59s)
=== CONT  TestAccCognitoIDPManagedLoginBranding_asset
--- PASS: TestAccCognitoIDPManagedLoginBranding_updateSettings (28.61s)
=== CONT  TestAccCognitoIDPManagedLoginBranding_settings
--- PASS: TestAccCognitoIDPManagedLoginBranding_asset (20.17s)
=== CONT  TestAccCognitoIDPManagedLoginBranding_updateToBasic
--- PASS: TestAccCognitoIDPManagedLoginBranding_settings (19.69s)
=== CONT  TestAccCognitoIDPManagedLoginBranding_disappears
--- PASS: TestAccCognitoIDPManagedLoginBranding_updateToBasic (27.97s)
--- PASS: TestAccCognitoIDPManagedLoginBranding_disappears (14.31s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cognitoidp	88.778s
% make testacc TESTARGS='-run=TestAccOpenSearchServerlessSecurityPolicyDataSource_' PKG=opensearchserverless
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.24.6 test ./internal/service/opensearchserverless/... -v -count 1 -parallel 20  -run=TestAccOpenSearchServerlessSecurityPolicyDataSource_ -timeout 360m -vet=off
2025/08/13 15:56:52 Creating Terraform AWS Provider (SDKv2-style)...
2025/08/13 15:56:52 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccOpenSearchServerlessSecurityPolicyDataSource_basic
=== PAUSE TestAccOpenSearchServerlessSecurityPolicyDataSource_basic
=== CONT  TestAccOpenSearchServerlessSecurityPolicyDataSource_basic
--- PASS: TestAccOpenSearchServerlessSecurityPolicyDataSource_basic (11.50s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/opensearchserverless	17.153s
% make testacc TESTARGS='-run=TestAccOpenSearchServerlessAccessPolicy_\|TestAccOpenSearchServerlessLifecyclePolicy_\|TestAccOpenSearchServerlessSecurityPolicy_' PKG=opensearchserverless ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.24.6 test ./internal/service/opensearchserverless/... -v -count 1 -parallel 3  -run=TestAccOpenSearchServerlessAccessPolicy_\|TestAccOpenSearchServerlessLifecyclePolicy_\|TestAccOpenSearchServerlessSecurityPolicy_ -timeout 360m -vet=off
2025/08/13 15:59:31 Creating Terraform AWS Provider (SDKv2-style)...
2025/08/13 15:59:31 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccOpenSearchServerlessAccessPolicy_basic
=== PAUSE TestAccOpenSearchServerlessAccessPolicy_basic
=== RUN   TestAccOpenSearchServerlessAccessPolicy_update
=== PAUSE TestAccOpenSearchServerlessAccessPolicy_update
=== RUN   TestAccOpenSearchServerlessAccessPolicy_disappears
=== PAUSE TestAccOpenSearchServerlessAccessPolicy_disappears
=== RUN   TestAccOpenSearchServerlessLifecyclePolicy_basic
=== PAUSE TestAccOpenSearchServerlessLifecyclePolicy_basic
=== RUN   TestAccOpenSearchServerlessLifecyclePolicy_disappears
=== PAUSE TestAccOpenSearchServerlessLifecyclePolicy_disappears
=== RUN   TestAccOpenSearchServerlessLifecyclePolicy_update
=== PAUSE TestAccOpenSearchServerlessLifecyclePolicy_update
=== RUN   TestAccOpenSearchServerlessSecurityPolicy_basic
=== PAUSE TestAccOpenSearchServerlessSecurityPolicy_basic
=== RUN   TestAccOpenSearchServerlessSecurityPolicy_update
=== PAUSE TestAccOpenSearchServerlessSecurityPolicy_update
=== RUN   TestAccOpenSearchServerlessSecurityPolicy_disappears
=== PAUSE TestAccOpenSearchServerlessSecurityPolicy_disappears
=== RUN   TestAccOpenSearchServerlessSecurityPolicy_string
=== PAUSE TestAccOpenSearchServerlessSecurityPolicy_string
=== RUN   TestAccOpenSearchServerlessSecurityPolicy_stringUpdate
=== PAUSE TestAccOpenSearchServerlessSecurityPolicy_stringUpdate
=== CONT  TestAccOpenSearchServerlessAccessPolicy_basic
=== CONT  TestAccOpenSearchServerlessSecurityPolicy_basic
=== CONT  TestAccOpenSearchServerlessSecurityPolicy_string
--- PASS: TestAccOpenSearchServerlessSecurityPolicy_basic (13.98s)
=== CONT  TestAccOpenSearchServerlessSecurityPolicy_stringUpdate
--- PASS: TestAccOpenSearchServerlessAccessPolicy_basic (14.37s)
=== CONT  TestAccOpenSearchServerlessSecurityPolicy_disappears
--- PASS: TestAccOpenSearchServerlessSecurityPolicy_string (21.25s)
=== CONT  TestAccOpenSearchServerlessSecurityPolicy_update
--- PASS: TestAccOpenSearchServerlessSecurityPolicy_disappears (11.01s)
=== CONT  TestAccOpenSearchServerlessLifecyclePolicy_basic
--- PASS: TestAccOpenSearchServerlessSecurityPolicy_stringUpdate (17.69s)
=== CONT  TestAccOpenSearchServerlessLifecyclePolicy_update
--- PASS: TestAccOpenSearchServerlessLifecyclePolicy_basic (12.35s)
=== CONT  TestAccOpenSearchServerlessLifecyclePolicy_disappears
--- PASS: TestAccOpenSearchServerlessSecurityPolicy_update (17.91s)
=== CONT  TestAccOpenSearchServerlessAccessPolicy_disappears
--- PASS: TestAccOpenSearchServerlessLifecyclePolicy_disappears (10.74s)
=== CONT  TestAccOpenSearchServerlessAccessPolicy_update
--- PASS: TestAccOpenSearchServerlessLifecyclePolicy_update (17.28s)
--- PASS: TestAccOpenSearchServerlessAccessPolicy_disappears (10.73s)
--- PASS: TestAccOpenSearchServerlessAccessPolicy_update (29.07s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/opensearchserverless	82.820s
% make testacc TESTARGS='-run=TestAccBedrockAgentFlow_\|TestAccBedrockAgentPrompt_' PKG=bedrockagent ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.24.6 test ./internal/service/bedrockagent/... -v -count 1 -parallel 3  -run=TestAccBedrockAgentFlow_\|TestAccBedrockAgentPrompt_ -timeout 360m -vet=off
2025/08/13 16:04:22 Creating Terraform AWS Provider (SDKv2-style)...
2025/08/13 16:04:22 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccBedrockAgentFlow_basic
=== PAUSE TestAccBedrockAgentFlow_basic
=== RUN   TestAccBedrockAgentFlow_disappears
=== PAUSE TestAccBedrockAgentFlow_disappears
=== RUN   TestAccBedrockAgentFlow_withEncryptionKey
=== PAUSE TestAccBedrockAgentFlow_withEncryptionKey
=== RUN   TestAccBedrockAgentFlow_tags
=== PAUSE TestAccBedrockAgentFlow_tags
=== RUN   TestAccBedrockAgentFlow_withDefinition
=== PAUSE TestAccBedrockAgentFlow_withDefinition
=== RUN   TestAccBedrockAgentFlow_withPromptResource
=== PAUSE TestAccBedrockAgentFlow_withPromptResource
=== RUN   TestAccBedrockAgentPrompt_basic
=== PAUSE TestAccBedrockAgentPrompt_basic
=== RUN   TestAccBedrockAgentPrompt_withEncryption
=== PAUSE TestAccBedrockAgentPrompt_withEncryption
=== RUN   TestAccBedrockAgentPrompt_variants
=== PAUSE TestAccBedrockAgentPrompt_variants
=== RUN   TestAccBedrockAgentPrompt_extraFields
=== PAUSE TestAccBedrockAgentPrompt_extraFields
=== RUN   TestAccBedrockAgentPrompt_disappears
=== PAUSE TestAccBedrockAgentPrompt_disappears
=== RUN   TestAccBedrockAgentPrompt_tags
=== PAUSE TestAccBedrockAgentPrompt_tags
=== CONT  TestAccBedrockAgentFlow_basic
=== CONT  TestAccBedrockAgentPrompt_basic
=== CONT  TestAccBedrockAgentPrompt_extraFields
--- PASS: TestAccBedrockAgentPrompt_basic (14.80s)
=== CONT  TestAccBedrockAgentPrompt_variants
--- PASS: TestAccBedrockAgentFlow_basic (24.48s)
=== CONT  TestAccBedrockAgentFlow_tags
--- PASS: TestAccBedrockAgentPrompt_variants (10.36s)
=== CONT  TestAccBedrockAgentFlow_withPromptResource
--- PASS: TestAccBedrockAgentPrompt_extraFields (29.47s)
=== CONT  TestAccBedrockAgentFlow_withDefinition
--- PASS: TestAccBedrockAgentFlow_withPromptResource (14.22s)
=== CONT  TestAccBedrockAgentFlow_withEncryptionKey
--- PASS: TestAccBedrockAgentFlow_withDefinition (14.26s)
=== CONT  TestAccBedrockAgentPrompt_tags
--- PASS: TestAccBedrockAgentFlow_withEncryptionKey (15.48s)
=== CONT  TestAccBedrockAgentPrompt_withEncryption
--- PASS: TestAccBedrockAgentFlow_tags (34.94s)
=== CONT  TestAccBedrockAgentFlow_disappears
--- PASS: TestAccBedrockAgentPrompt_withEncryption (14.97s)
=== CONT  TestAccBedrockAgentPrompt_disappears
--- PASS: TestAccBedrockAgentFlow_disappears (11.95s)
--- PASS: TestAccBedrockAgentPrompt_tags (32.45s)
--- PASS: TestAccBedrockAgentPrompt_disappears (10.75s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/bedrockagent	86.121s
% make testacc TESTARGS='-run=TestAccKendraDataSource_Configuration_templateConfiguration' PKG=kendra
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.24.6 test ./internal/service/kendra/... -v -count 1 -parallel 20  -run=TestAccKendraDataSource_Configuration_templateConfiguration -timeout 360m -vet=off
2025/08/13 16:11:03 Creating Terraform AWS Provider (SDKv2-style)...
2025/08/13 16:11:03 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccKendraDataSource_Configuration_templateConfiguration
=== PAUSE TestAccKendraDataSource_Configuration_templateConfiguration
=== CONT  TestAccKendraDataSource_Configuration_templateConfiguration
--- PASS: TestAccKendraDataSource_Configuration_templateConfiguration (1845.25s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/kendra	1850.546s
% make testacc TESTARGS='-run=TestAccCloudControlResource' PKG=cloudcontrol ACCTEST_PARALLELISM=3   
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.24.6 test ./internal/service/cloudcontrol/... -v -count 1 -parallel 3  -run=TestAccCloudControlResource -timeout 360m -vet=off
2025/08/14 11:18:12 Creating Terraform AWS Provider (SDKv2-style)...
2025/08/14 11:18:12 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccCloudControlResourceDataSource_basic
=== PAUSE TestAccCloudControlResourceDataSource_basic
=== RUN   TestAccCloudControlResource_basic
=== PAUSE TestAccCloudControlResource_basic
=== RUN   TestAccCloudControlResource_disappears
=== PAUSE TestAccCloudControlResource_disappears
=== RUN   TestAccCloudControlResource_DesiredState_booleanValueAdded
=== PAUSE TestAccCloudControlResource_DesiredState_booleanValueAdded
=== RUN   TestAccCloudControlResource_DesiredState_booleanValueRemoved
=== PAUSE TestAccCloudControlResource_DesiredState_booleanValueRemoved
=== RUN   TestAccCloudControlResource_DesiredState_booleanValueUpdate
=== PAUSE TestAccCloudControlResource_DesiredState_booleanValueUpdate
=== RUN   TestAccCloudControlResource_DesiredState_createOnly
=== PAUSE TestAccCloudControlResource_DesiredState_createOnly
=== RUN   TestAccCloudControlResource_DesiredState_integerValueAdded
=== PAUSE TestAccCloudControlResource_DesiredState_integerValueAdded
=== RUN   TestAccCloudControlResource_DesiredState_integerValueRemoved
=== PAUSE TestAccCloudControlResource_DesiredState_integerValueRemoved
=== RUN   TestAccCloudControlResource_DesiredState_integerValueUpdate
=== PAUSE TestAccCloudControlResource_DesiredState_integerValueUpdate
=== RUN   TestAccCloudControlResource_DesiredState_invalidPropertyName
=== PAUSE TestAccCloudControlResource_DesiredState_invalidPropertyName
=== RUN   TestAccCloudControlResource_DesiredState_invalidPropertyValue
=== PAUSE TestAccCloudControlResource_DesiredState_invalidPropertyValue
=== RUN   TestAccCloudControlResource_DesiredState_objectValueAdded
=== PAUSE TestAccCloudControlResource_DesiredState_objectValueAdded
=== RUN   TestAccCloudControlResource_DesiredState_objectValueRemoved
=== PAUSE TestAccCloudControlResource_DesiredState_objectValueRemoved
=== RUN   TestAccCloudControlResource_DesiredState_objectValueUpdate
=== PAUSE TestAccCloudControlResource_DesiredState_objectValueUpdate
=== RUN   TestAccCloudControlResource_DesiredState_stringValueAdded
=== PAUSE TestAccCloudControlResource_DesiredState_stringValueAdded
=== RUN   TestAccCloudControlResource_DesiredState_stringValueRemoved
=== PAUSE TestAccCloudControlResource_DesiredState_stringValueRemoved
=== RUN   TestAccCloudControlResource_DesiredState_stringValueUpdate
=== PAUSE TestAccCloudControlResource_DesiredState_stringValueUpdate
=== RUN   TestAccCloudControlResource_resourceSchema
=== PAUSE TestAccCloudControlResource_resourceSchema
=== RUN   TestAccCloudControlResource_lambdaFunction
=== PAUSE TestAccCloudControlResource_lambdaFunction
=== CONT  TestAccCloudControlResourceDataSource_basic
=== CONT  TestAccCloudControlResource_DesiredState_invalidPropertyName
=== CONT  TestAccCloudControlResource_DesiredState_booleanValueUpdate
--- PASS: TestAccCloudControlResource_DesiredState_invalidPropertyName (3.00s)
=== CONT  TestAccCloudControlResource_DesiredState_booleanValueAdded
--- PASS: TestAccCloudControlResourceDataSource_basic (20.25s)
=== CONT  TestAccCloudControlResource_DesiredState_booleanValueRemoved
--- PASS: TestAccCloudControlResource_DesiredState_booleanValueUpdate (22.72s)
=== CONT  TestAccCloudControlResource_DesiredState_stringValueAdded
--- PASS: TestAccCloudControlResource_DesiredState_booleanValueAdded (20.96s)
=== CONT  TestAccCloudControlResource_lambdaFunction
--- PASS: TestAccCloudControlResource_DesiredState_booleanValueRemoved (19.69s)
=== CONT  TestAccCloudControlResource_resourceSchema
--- PASS: TestAccCloudControlResource_DesiredState_stringValueAdded (20.02s)
=== CONT  TestAccCloudControlResource_DesiredState_stringValueUpdate
--- PASS: TestAccCloudControlResource_resourceSchema (18.22s)
=== CONT  TestAccCloudControlResource_DesiredState_stringValueRemoved
--- PASS: TestAccCloudControlResource_DesiredState_stringValueUpdate (20.18s)
=== CONT  TestAccCloudControlResource_basic
--- PASS: TestAccCloudControlResource_DesiredState_stringValueRemoved (20.62s)
=== CONT  TestAccCloudControlResource_DesiredState_objectValueRemoved
--- PASS: TestAccCloudControlResource_basic (17.97s)
=== CONT  TestAccCloudControlResource_DesiredState_objectValueUpdate
--- PASS: TestAccCloudControlResource_lambdaFunction (89.51s)
=== CONT  TestAccCloudControlResource_DesiredState_integerValueRemoved
--- PASS: TestAccCloudControlResource_DesiredState_objectValueRemoved (39.79s)
=== CONT  TestAccCloudControlResource_DesiredState_integerValueUpdate
--- PASS: TestAccCloudControlResource_DesiredState_objectValueUpdate (48.06s)
=== CONT  TestAccCloudControlResource_disappears
--- PASS: TestAccCloudControlResource_DesiredState_integerValueRemoved (32.95s)
=== CONT  TestAccCloudControlResource_DesiredState_integerValueAdded
--- PASS: TestAccCloudControlResource_disappears (19.38s)
=== CONT  TestAccCloudControlResource_DesiredState_createOnly
--- PASS: TestAccCloudControlResource_DesiredState_integerValueUpdate (32.76s)
=== CONT  TestAccCloudControlResource_DesiredState_objectValueAdded
--- PASS: TestAccCloudControlResource_DesiredState_integerValueAdded (26.05s)
=== CONT  TestAccCloudControlResource_DesiredState_invalidPropertyValue
--- PASS: TestAccCloudControlResource_DesiredState_invalidPropertyValue (4.56s)
--- PASS: TestAccCloudControlResource_DesiredState_createOnly (33.58s)
--- PASS: TestAccCloudControlResource_DesiredState_objectValueAdded (39.35s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cloudcontrol	196.095s

ewbankkit added 19 commits August 4, 2025 12:16
@ewbankkit
r/aws_cognito_managed_login_branding: New resource.
7062213
@ewbankkit
r/aws_cognito_managed_login_branding: Documentation.
7fc99ff
@ewbankkit
Update prefixes for 'cognitoidp' resource names.
201428a
@ewbankkit
r/aws_cognito_managed_login_branding: Update example.
a6d7b9b
@ewbankkit
'use_cognito_provided_values' is Computed.
ba52073
@ewbankkit
Merge branch 'main' into f-r/aws_cognito_managed_login_branding
505c84f
@ewbankkit
Change import alias.
001304d
@ewbankkit
Support more formats in 'SmithyDocumentFromString' and 'SmithyDocumen…
8a06d57 
…tToString'.
@ewbankkit
SmithyJSON -- use 'jsontypes.Normalized'.
a10f96d
@ewbankkit
Add 'internal/smithy' package.
c1b8b7c
@ewbankkit
Rename some functions.
a4346d6
@ewbankkit
Flattening is unmarshalling.
daa4481
@ewbankkit
Rename file.
bca35ea
@ewbankkit
Expansion of SmithJSON working.
eb5b28e
@ewbankkit
SmithyJSON.StringSemanticEquals: Implement.
a0b66ad
@ewbankkit
r/aws_opensearchserverless_access_policy: Use 'jsontypes.Normalized'.
fe54d29
@ewbankkit
r/aws_opensearchserverless_lifecycle_policy: Use 'jsontypes.Normalized'.
6feb031
@ewbankkit
r/aws_opensearchserverless_security_policy: Use 'jsontypes.Normalized'.
f54be1e
@ewbankkit
Corrections.
a6aa6b7
@github-actions
Copy link
Contributor

github-actions bot commented Aug 11, 2025

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. generators Relates to code generators. github_actions Pull requests that update Github_actions code service/cognitoidp Issues and PRs that pertain to the cognitoidp service. service/controltower Issues and PRs that pertain to the controltower service. service/bedrockagent Issues and PRs that pertain to the bedrockagent service. size/XL Managed by automation to categorize the size of a PR. labels Aug 11, 2025
@ewbankkit
Acceptance test output:
50dcc80 
% make testacc TESTARGS='-run=TestAccCognitoIDPManagedLoginBranding_settings' PKG=cognitoidp
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.24.6 test ./internal/service/cognitoidp/... -v -count 1 -parallel 20  -run=TestAccCognitoIDPManagedLoginBranding_settings -timeout 360m -vet=off
2025/09/03 16:40:44 Creating Terraform AWS Provider (SDKv2-style)...
2025/09/03 16:40:44 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccCognitoIDPManagedLoginBranding_settings
=== PAUSE TestAccCognitoIDPManagedLoginBranding_settings
=== CONT  TestAccCognitoIDPManagedLoginBranding_settings
--- PASS: TestAccCognitoIDPManagedLoginBranding_settings (20.11s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cognitoidp	25.621s
@ewbankkit ewbankkit added the new-resource Introduces a new resource. label Sep 3, 2025
@ewbankkit ewbankkit marked this pull request as ready for review September 4, 2025 14:02
jar-b
jar-b approved these changes Sep 4, 2025
View reviewed changes
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@ewbankkit ewbankkit merged commit ad94254 into main Sep 4, 2025
67 checks passed
@ewbankkit ewbankkit deleted the f-r/aws_cognito_managed_login_branding branch September 4, 2025 16:36
@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2025

Warning

This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions bot added this to the v6.12.0 milestone Sep 4, 2025
terraform-aws-provider bot pushed a commit that referenced this pull request Sep 4, 2025
Update CHANGELOG.md for #43817
75125af
@mikeokner
Copy link

mikeokner commented Sep 4, 2025

Nice, I was literally just looking for a way to do this today! 🚀

@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Sep 4, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2025

This functionality has been released in v6.12.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@jar-b jar-b mentioned this pull request Sep 5, 2025
Closed
@sdroa
Copy link

sdroa commented Sep 8, 2025 •
edited
Loading

@ewbankkit just moving from awscc to aws right now, so happy to hear it's finally on the provider 🙏 .

Would you happen to confirm to me, that I can keep the same settings json structure we had for awscc?

settings = jsonencode(full settings json variable..)

I had a variable with the full json we were using with awscc, and by changing the provider, I plan to keep the same.

Thanks in advance.

@sdroa
Copy link

sdroa commented Sep 8, 2025

Leaving a small issue associated to this PR: #44188 🙏

Thanks again for this resource, we'll put it to great use!

marcinbelczewski pushed a commit to marcinbelczewski/terraform-provider-aws that referenced this pull request Sep 15, 2025
Update CHANGELOG.md for hashicorp#43817
a4efd7e
@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2025

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jar-b jar-b jar-b approved these changes

@breathingdust breathingdust Awaiting requested review from breathingdust breathingdust is a code owner

@justinretzolk justinretzolk Awaiting requested review from justinretzolk justinretzolk is a code owner

Assignees

No one assigned

Labels

documentation Introduces or discusses updates to documentation. flex Pertains to FLatteners and EXpanders. generators Relates to code generators. github_actions Pull requests that update Github_actions code new-resource Introduces a new resource. repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. service/bedrockagent Issues and PRs that pertain to the bedrockagent service. service/cloudcontrol Issues and PRs that pertain to the cloudcontrol service. service/cognitoidp Issues and PRs that pertain to the cognitoidp service. service/controltower Issues and PRs that pertain to the controltower service. service/kendra Issues and PRs that pertain to the kendra service. service/opensearchserverless Issues and PRs that pertain to the opensearchserverless service. size/XL Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.

Projects

None yet

Milestone

v6.12.0

Development

Successfully merging this pull request may close these issues.

Support for Cognito managed login branding [Enhancement]: Validate OpenSearch Serverless JSON arguments

5 participants

@ewbankkit @winem @mikeokner @sdroa @jar-b