Skip to content

Conversation

@tabito-hara
Copy link
Contributor

@tabito-hara tabito-hara commented May 24, 2025

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Description

memo

  • JSON normalization
  • asset ForceNew
  • waiter not implemented

Relations

Closes #42580

References

https://docs.aws.amazon.com/cognito-user-identity-pools/latest/APIReference/API_ManagedLoginBrandingType.html

Output from Acceptance Testing

$ make testacc TESTS=TestAccCognitoIDPManagedLoginBranding_ PKG=cognitoidp               
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.9 test ./internal/service/cognitoidp/... -v -count 1 -parallel 20 -run='TestAccCognitoIDPManagedLoginBranding_'  -timeout 360m -vet=off
2025/05/24 23:35:17 Initializing Terraform AWS Provider...
=== RUN   TestAccCognitoIDPManagedLoginBranding_basic
=== PAUSE TestAccCognitoIDPManagedLoginBranding_basic
=== RUN   TestAccCognitoIDPManagedLoginBranding_asset
=== PAUSE TestAccCognitoIDPManagedLoginBranding_asset
=== RUN   TestAccCognitoIDPManagedLoginBranding_settings
=== PAUSE TestAccCognitoIDPManagedLoginBranding_settings
=== RUN   TestAccCognitoIDPManagedLoginBranding_disappears
=== PAUSE TestAccCognitoIDPManagedLoginBranding_disappears
=== CONT  TestAccCognitoIDPManagedLoginBranding_basic
=== CONT  TestAccCognitoIDPManagedLoginBranding_settings
=== CONT  TestAccCognitoIDPManagedLoginBranding_disappears
=== CONT  TestAccCognitoIDPManagedLoginBranding_asset
--- PASS: TestAccCognitoIDPManagedLoginBranding_disappears (24.47s)
--- PASS: TestAccCognitoIDPManagedLoginBranding_basic (26.73s)
--- PASS: TestAccCognitoIDPManagedLoginBranding_settings (50.63s)
--- PASS: TestAccCognitoIDPManagedLoginBranding_asset (63.07s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/cognitoidp 67.565s

@github-actions
Copy link
Contributor

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. generators Relates to code generators. service/cognitoidp Issues and PRs that pertain to the cognitoidp service. size/XL Managed by automation to categorize the size of a PR. labels May 24, 2025
@github-actions github-actions bot added repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. github_actions Pull requests that update Github_actions code labels May 24, 2025
@tabito-hara tabito-hara force-pushed the f-aws_cognito_managed_login_branding branch from b82633c to 27bf6e3 Compare May 24, 2025 16:28
@tabito-hara tabito-hara force-pushed the f-aws_cognito_managed_login_branding branch from 27bf6e3 to a47b8b9 Compare May 24, 2025 16:55
@tabito-hara
Copy link
Contributor Author

I realized I need to reconsider several issues (including schema design), especially because UpdateManagedLoginBranding uses a PATCH model.

This PR is being closed for now and will be resubmitted later.

@github-actions github-actions bot removed the needs-triage Waiting for first response or review from a maintainer. label May 25, 2025
@github-actions
Copy link
Contributor

Warning

This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@tabito-hara tabito-hara deleted the f-aws_cognito_managed_login_branding branch May 25, 2025 12:30
@github-actions
Copy link
Contributor

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

documentation Introduces or discusses updates to documentation. generators Relates to code generators. github_actions Pull requests that update Github_actions code repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. service/cognitoidp Issues and PRs that pertain to the cognitoidp service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support for Cognito managed login branding

1 participant