Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resource: aws_ec2_transit_gateway_default_route_table_propagation #39517

Merged
merged 246 commits into from
Sep 30, 2024

Conversation

drewtul
Copy link
Contributor

@drewtul drewtul commented Sep 27, 2024

Description

Add aws_ec2_transit_gateway_default_route_table_propagation for setting the default propagation route table on a transit gateway.

Relations

Depends on #39496
Closes #35085

References

Output from Acceptance Testing

%  make testacc TESTS='TestAccTransitGateway_serial/DefaultRouteTablePropagation_' PKG=ec2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.1 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccTransitGateway_serial/DefaultRouteTablePropagation_'  -timeout 360m
=== RUN   TestAccTransitGateway_serial
=== PAUSE TestAccTransitGateway_serial
=== CONT  TestAccTransitGateway_serial
=== RUN   TestAccTransitGateway_serial/DefaultRouteTablePropagation_basic
=== PAUSE TestAccTransitGateway_serial/DefaultRouteTablePropagation_basic
=== RUN   TestAccTransitGateway_serial/DefaultRouteTablePropagation_disappears
=== PAUSE TestAccTransitGateway_serial/DefaultRouteTablePropagation_disappears
=== CONT  TestAccTransitGateway_serial/DefaultRouteTablePropagation_basic
=== CONT  TestAccTransitGateway_serial/DefaultRouteTablePropagation_disappears
--- PASS: TestAccTransitGateway_serial (0.00s)
    --- PASS: TestAccTransitGateway_serial/DefaultRouteTablePropagation_basic (180.25s)
    --- PASS: TestAccTransitGateway_serial/DefaultRouteTablePropagation_disappears (180.47s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        185.203s

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. generators Relates to code generators. service/transitgateway Issues and PRs that pertain to the transitgateway service. needs-triage Waiting for first response or review from a maintainer. partner Contribution from a partner. labels Sep 27, 2024
@drewtul drewtul marked this pull request as ready for review September 27, 2024 15:02
@drewtul drewtul requested a review from a team as a code owner September 27, 2024 15:02
@ewbankkit ewbankkit added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Sep 27, 2024
# Conflicts:
#	internal/service/ec2/exports_test.go
#	internal/service/ec2/service_package_gen.go
#	internal/service/ec2/transitgateway_default_route_table_association_test.go
% make testacc TESTARGS='-run=TestAccSecurityHub_serial/StandardsControlAssociation' PKG=securityhub
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.1 test ./internal/service/securityhub/... -v -count 1 -parallel 20  -run=TestAccSecurityHub_serial/StandardsControlAssociation -timeout 360m
=== RUN   TestAccSecurityHub_serial
=== PAUSE TestAccSecurityHub_serial
=== CONT  TestAccSecurityHub_serial
=== RUN   TestAccSecurityHub_serial/StandardsControlAssociationsDataSource
=== RUN   TestAccSecurityHub_serial/StandardsControlAssociationsDataSource/basic
=== RUN   TestAccSecurityHub_serial/StandardsControlAssociation
=== RUN   TestAccSecurityHub_serial/StandardsControlAssociation/basic
--- PASS: TestAccSecurityHub_serial (78.24s)
    --- PASS: TestAccSecurityHub_serial/StandardsControlAssociationsDataSource (35.03s)
        --- PASS: TestAccSecurityHub_serial/StandardsControlAssociationsDataSource/basic (35.03s)
    --- PASS: TestAccSecurityHub_serial/StandardsControlAssociation (43.21s)
        --- PASS: TestAccSecurityHub_serial/StandardsControlAssociation/basic (43.21s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/securityhub	83.662s
Copy link

Thank you for your contribution! 🚀

Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the go.mod or go.sum files and commit them into this pull request.

Additional details:

  • Check open pull requests with the dependencies label to view other dependency updates.
  • If this pull request includes an update the AWS Go SDK (or any other dependency) version, only updates submitted via dependabot will be merged. This pull request will need to remove these changes and will need to be rebased after the existing dependency update via dependabot has been merged for this pull request to be reviewed.
  • If this pull request is for supporting a new AWS service:
    • Ensure the new AWS service changes are following the Contributing Guide section on new services, in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split.
    • If this pull request is already a separate pull request from the above item, you can ignore this message.

Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccTransitGateway_serial/^DefaultRouteTablePropagation_' PKG=ec2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.1 test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccTransitGateway_serial/^DefaultRouteTablePropagation_ -timeout 360m
=== RUN   TestAccTransitGateway_serial
=== PAUSE TestAccTransitGateway_serial
=== CONT  TestAccTransitGateway_serial
=== RUN   TestAccTransitGateway_serial/DefaultRouteTablePropagation_basic
=== PAUSE TestAccTransitGateway_serial/DefaultRouteTablePropagation_basic
=== RUN   TestAccTransitGateway_serial/DefaultRouteTablePropagation_disappears
=== PAUSE TestAccTransitGateway_serial/DefaultRouteTablePropagation_disappears
=== RUN   TestAccTransitGateway_serial/DefaultRouteTablePropagation_disappearsTransitGateway
=== PAUSE TestAccTransitGateway_serial/DefaultRouteTablePropagation_disappearsTransitGateway
=== CONT  TestAccTransitGateway_serial/DefaultRouteTablePropagation_basic
=== CONT  TestAccTransitGateway_serial/DefaultRouteTablePropagation_disappearsTransitGateway
=== CONT  TestAccTransitGateway_serial/DefaultRouteTablePropagation_disappears
--- PASS: TestAccTransitGateway_serial (0.00s)
    --- PASS: TestAccTransitGateway_serial/DefaultRouteTablePropagation_disappearsTransitGateway (167.76s)
    --- PASS: TestAccTransitGateway_serial/DefaultRouteTablePropagation_disappears (189.94s)
    --- PASS: TestAccTransitGateway_serial/DefaultRouteTablePropagation_basic (219.44s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	225.160s

@ewbankkit
Copy link
Contributor

@drewtul Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit ff0657c into hashicorp:main Sep 30, 2024
46 checks passed
@github-actions github-actions bot added this to the v5.70.0 milestone Sep 30, 2024
@drewtul drewtul deleted the f-tgw-default-route-table-propagation branch September 30, 2024 15:45
Copy link

github-actions bot commented Oct 4, 2024

This functionality has been released in v5.70.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

github-actions bot commented Nov 4, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-resource Introduces a new resource. partner Contribution from a partner. service/transitgateway Issues and PRs that pertain to the transitgateway service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Resources]: Default TGW association and propagation route table settings
2 participants