-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Resource: aws_ec2_transit_gateway_default_route_table_propagation #39517
New Resource: aws_ec2_transit_gateway_default_route_table_propagation #39517
Conversation
Community NoteVoting for Prioritization
For Submitters
|
# Conflicts: # internal/service/ec2/exports_test.go # internal/service/ec2/service_package_gen.go # internal/service/ec2/transitgateway_default_route_table_association_test.go
% make testacc TESTARGS='-run=TestAccSecurityHub_serial/StandardsControlAssociation' PKG=securityhub make: Verifying source code with gofmt... ==> Checking that code complies with gofmt requirements... TF_ACC=1 go1.23.1 test ./internal/service/securityhub/... -v -count 1 -parallel 20 -run=TestAccSecurityHub_serial/StandardsControlAssociation -timeout 360m === RUN TestAccSecurityHub_serial === PAUSE TestAccSecurityHub_serial === CONT TestAccSecurityHub_serial === RUN TestAccSecurityHub_serial/StandardsControlAssociationsDataSource === RUN TestAccSecurityHub_serial/StandardsControlAssociationsDataSource/basic === RUN TestAccSecurityHub_serial/StandardsControlAssociation === RUN TestAccSecurityHub_serial/StandardsControlAssociation/basic --- PASS: TestAccSecurityHub_serial (78.24s) --- PASS: TestAccSecurityHub_serial/StandardsControlAssociationsDataSource (35.03s) --- PASS: TestAccSecurityHub_serial/StandardsControlAssociationsDataSource/basic (35.03s) --- PASS: TestAccSecurityHub_serial/StandardsControlAssociation (43.21s) --- PASS: TestAccSecurityHub_serial/StandardsControlAssociation/basic (43.21s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/securityhub 83.662s
Thank you for your contribution! 🚀 Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the Additional details:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccTransitGateway_serial/^DefaultRouteTablePropagation_' PKG=ec2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.1 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run=TestAccTransitGateway_serial/^DefaultRouteTablePropagation_ -timeout 360m
=== RUN TestAccTransitGateway_serial
=== PAUSE TestAccTransitGateway_serial
=== CONT TestAccTransitGateway_serial
=== RUN TestAccTransitGateway_serial/DefaultRouteTablePropagation_basic
=== PAUSE TestAccTransitGateway_serial/DefaultRouteTablePropagation_basic
=== RUN TestAccTransitGateway_serial/DefaultRouteTablePropagation_disappears
=== PAUSE TestAccTransitGateway_serial/DefaultRouteTablePropagation_disappears
=== RUN TestAccTransitGateway_serial/DefaultRouteTablePropagation_disappearsTransitGateway
=== PAUSE TestAccTransitGateway_serial/DefaultRouteTablePropagation_disappearsTransitGateway
=== CONT TestAccTransitGateway_serial/DefaultRouteTablePropagation_basic
=== CONT TestAccTransitGateway_serial/DefaultRouteTablePropagation_disappearsTransitGateway
=== CONT TestAccTransitGateway_serial/DefaultRouteTablePropagation_disappears
--- PASS: TestAccTransitGateway_serial (0.00s)
--- PASS: TestAccTransitGateway_serial/DefaultRouteTablePropagation_disappearsTransitGateway (167.76s)
--- PASS: TestAccTransitGateway_serial/DefaultRouteTablePropagation_disappears (189.94s)
--- PASS: TestAccTransitGateway_serial/DefaultRouteTablePropagation_basic (219.44s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 225.160s
@drewtul Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.70.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Add
aws_ec2_transit_gateway_default_route_table_propagation
for setting the default propagation route table on a transit gateway.Relations
Depends on #39496
Closes #35085
References
Output from Acceptance Testing