-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Resource: aws_ec2_transit_gateway_default_route_table_association #39496
Merged
ewbankkit
merged 12 commits into
hashicorp:main
from
drewtul:f-tgw-default-route-table-association
Sep 27, 2024
Merged
New Resource: aws_ec2_transit_gateway_default_route_table_association #39496
ewbankkit
merged 12 commits into
hashicorp:main
from
drewtul:f-tgw-default-route-table-association
Sep 27, 2024
+487
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Community NoteVoting for Prioritization
For Submitters
|
github-actions
bot
added
documentation
Introduces or discusses updates to documentation.
tests
PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
generators
Relates to code generators.
service/transitgateway
Issues and PRs that pertain to the transitgateway service.
needs-triage
Waiting for first response or review from a maintainer.
partner
Contribution from a partner.
labels
Sep 26, 2024
I believe the failing checks are false positives for this change at least. |
drewtul
force-pushed
the
f-tgw-default-route-table-association
branch
from
September 26, 2024 14:00
abf0743
to
a35e385
Compare
drewtul
force-pushed
the
f-tgw-default-route-table-association
branch
from
September 27, 2024 08:17
a35e385
to
bf4fcf9
Compare
ewbankkit
removed
the
needs-triage
Waiting for first response or review from a maintainer.
label
Sep 27, 2024
github-actions
bot
added
the
prioritized
Part of the maintainer teams immediate focus. To be addressed within the current quarter.
label
Sep 27, 2024
ewbankkit
approved these changes
Sep 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccTransitGateway_serial/^DefaultRouteTableAssociation_' PKG=ec2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.1 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run=TestAccTransitGateway_serial/^DefaultRouteTableAssociation_ -timeout 360m
=== RUN TestAccTransitGateway_serial
=== PAUSE TestAccTransitGateway_serial
=== CONT TestAccTransitGateway_serial
=== RUN TestAccTransitGateway_serial/DefaultRouteTableAssociation_basic
=== PAUSE TestAccTransitGateway_serial/DefaultRouteTableAssociation_basic
=== RUN TestAccTransitGateway_serial/DefaultRouteTableAssociation_disappears
=== PAUSE TestAccTransitGateway_serial/DefaultRouteTableAssociation_disappears
=== RUN TestAccTransitGateway_serial/DefaultRouteTableAssociation_disappearsTransitGateway
=== PAUSE TestAccTransitGateway_serial/DefaultRouteTableAssociation_disappearsTransitGateway
=== CONT TestAccTransitGateway_serial/DefaultRouteTableAssociation_basic
=== CONT TestAccTransitGateway_serial/DefaultRouteTableAssociation_disappearsTransitGateway
=== CONT TestAccTransitGateway_serial/DefaultRouteTableAssociation_disappears
--- PASS: TestAccTransitGateway_serial (0.00s)
--- PASS: TestAccTransitGateway_serial/DefaultRouteTableAssociation_disappearsTransitGateway (176.18s)
--- PASS: TestAccTransitGateway_serial/DefaultRouteTableAssociation_basic (238.99s)
--- PASS: TestAccTransitGateway_serial/DefaultRouteTableAssociation_disappears (240.07s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 245.675s
% make golangci-lint PKG=ec2
make: golangci-lint Checks / 1 of 3...
make: golangci-lint Checks / 2 of 3...
WARN [config_reader] The configuration option `linters.errcheck.ignore` is deprecated, please use `linters.errcheck.exclude-functions`.
make: golangci-lint Checks / 3 of 3... |
@drewtul Thanks for the contribution 🎉 👏. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
Introduces or discusses updates to documentation.
generators
Relates to code generators.
new-resource
Introduces a new resource.
partner
Contribution from a partner.
prioritized
Part of the maintainer teams immediate focus. To be addressed within the current quarter.
service/transitgateway
Issues and PRs that pertain to the transitgateway service.
tests
PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
New resource
aws_ec2_transit_gateway_default_route_table_association
that allows you to manage setting the default route table for associations on a transit gateway.Relations
Relates #35085 creates one of the two resources required to fix this.
References
Output from Acceptance Testing