Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

waf: up aws_wafregional_web_acl_association create timeout to 5 minutes #32329

Merged
merged 2 commits into from
Jul 6, 2023

Conversation

midgleyc
Copy link

@midgleyc midgleyc commented Jul 1, 2023

Description

Increase creation timeout value from 2 to 5 minutes to prevent WAFUnavailableEntityException for WAFClassic ACL association.

Relations

Closes #32103

References

The same as #17545 but for wafregional.

Output from Acceptance Testing

$ make testacc TESTS=TestAccWAFRegionalWebACLAssociation_ PKG=wafregional

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/wafregional/... -v -count 1 -parallel 20 -run='TestAccWAFRegionalWebACLAssociation_'  -timeout 180m
=== RUN   TestAccWAFRegionalWebACLAssociation_basic
=== PAUSE TestAccWAFRegionalWebACLAssociation_basic
=== RUN   TestAccWAFRegionalWebACLAssociation_disappears
=== PAUSE TestAccWAFRegionalWebACLAssociation_disappears
=== RUN   TestAccWAFRegionalWebACLAssociation_multipleAssociations
=== PAUSE TestAccWAFRegionalWebACLAssociation_multipleAssociations
=== RUN   TestAccWAFRegionalWebACLAssociation_ResourceARN_apiGatewayStage
=== PAUSE TestAccWAFRegionalWebACLAssociation_ResourceARN_apiGatewayStage
=== CONT  TestAccWAFRegionalWebACLAssociation_basic
=== CONT  TestAccWAFRegionalWebACLAssociation_multipleAssociations
=== CONT  TestAccWAFRegionalWebACLAssociation_ResourceARN_apiGatewayStage
=== CONT  TestAccWAFRegionalWebACLAssociation_disappears
--- PASS: TestAccWAFRegionalWebACLAssociation_ResourceARN_apiGatewayStage (74.01s)
--- PASS: TestAccWAFRegionalWebACLAssociation_disappears (187.69s)
--- PASS: TestAccWAFRegionalWebACLAssociation_multipleAssociations (197.08s)
--- PASS: TestAccWAFRegionalWebACLAssociation_basic (199.73s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/wafregional        199.843s

@github-actions
Copy link

github-actions bot commented Jul 1, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added service/wafregional Issues and PRs that pertain to the wafregional service. size/XS Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. labels Jul 1, 2023
@midgleyc midgleyc marked this pull request as ready for review July 1, 2023 09:48
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @midgleyc 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@justinretzolk justinretzolk added timeouts Pertains to timeout increases. bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Jul 6, 2023
Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, @midgleyc, it looks good 🚀

@gdavison gdavison merged commit 99fe553 into hashicorp:main Jul 6, 2023
@github-actions github-actions bot added this to the v5.7.0 milestone Jul 6, 2023
@midgleyc midgleyc deleted the b-waf-classic-timeout branch July 7, 2023 09:05
@github-actions
Copy link

github-actions bot commented Jul 7, 2023

This functionality has been released in v5.7.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Aug 7, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/wafregional Issues and PRs that pertain to the wafregional service. size/XS Managed by automation to categorize the size of a PR. timeouts Pertains to timeout increases.
Projects
None yet
3 participants