Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] Prevent useless strings creations during applyCollectionDiff #1181

Closed
wants to merge 1 commit into from

Conversation

freedge
Copy link

@freedge freedge commented Mar 29, 2023

before:

image

following this change my terraform plan goes from 120s to 100s.

this is more a fyi as this pr is made against v1.17.2 (as used on my provider) but the main branch seems to use the same logic.

@hashicorp-cla
Copy link

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes

Have you signed the CLA already but the status is still pending? Recheck it.

@bflad
Copy link
Contributor

bflad commented Mar 29, 2023

Hi @freedge 👋 Thank you for submitting this. Please note that terraform-plugin-sdk v1 has been end-of-life since July 31, 2021, therefore we are not accepting any changes to that code since it will never be released. Peeking at the changes, they appear fairly trivial in nature so we would consider something like this for v2, if you're interested. There is a terraform-plugin-sdk v2 upgrade guide available, although depending on the provider size, it may be worth skipping over to terraform-plugin-framework instead at this point.

@bflad bflad closed this Mar 29, 2023
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants