Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate to more recent terraform-plugin-sdk #377

Open
freedge opened this issue Mar 29, 2023 · 1 comment
Open

migrate to more recent terraform-plugin-sdk #377

freedge opened this issue Mar 29, 2023 · 1 comment

Comments

@freedge
Copy link

freedge commented Mar 29, 2023

Is your feature request related to a problem?

indeed related to a problem, panos_address_objects is horribly slow with a large number of addresses
One of the reason is hashicorp/terraform#32940
Other reason come from the terraform-provider-panos process exec'ed from terraform, it spends considerable time computing diffs. I dug a bit and there are improvements doable in terraform-plugin-sdk such as hashicorp/terraform-plugin-sdk#1181 but it's not really doable without first migrating to a recent version of terraform-plugin-sdk. The terraform-provider-panos main branch currently uses terraform-plugin-sdk v1.17.2 from 2 years ago.

Describe the solution you'd like

Migrate to a more recent version of terraform-plugin-sdk so we can benefit from fixes and maybe submit some more.

Describe alternatives you've considered

not using panos_address_objects or reducing the set size as suggested in the doc

Additional context

terraform plan and apply take dozen of minutes and we are trying to improve this.

Note there is some migration work to do, for example github.com/hashicorp/terraform-plugin-sdk/helper/hashcode does not exist anymore.

There are more info on the migration steps in hashicorp/terraform-plugin-sdk#1181 (comment)

@welcome-to-palo-alto-networks

🎉 Thanks for opening your first issue here! Welcome to the community!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant