-
Notifications
You must be signed in to change notification settings - Fork 101
list: framework changes to support list with sdkv2 resources #1198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
87c3bcf
to
5e9481a
Compare
25b4b87
to
9f7f784
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff @stephybun! Left some initial thoughts
Test coverage might be a bit lacking, but I'll look into this in a separate PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀 - all of the comments are pkg doc related / nits and can be addressed later if preferred
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Throwing in an approve since Austin already approved and your commit since then only improved comments and strings.
a72f2a1
to
aea7a09
Compare
Description
Inspired by
#1176
hashicorp/terraform-plugin-mux#316
https://github.com/hashicorp/terraform-plugin-framework/tree/av/linked-resources