Skip to content

Conversation

stephybun
Copy link
Member

@stephybun stephybun force-pushed the f/list-spike-sdkv2 branch 2 times, most recently from 87c3bcf to 5e9481a Compare August 20, 2025 10:47
@stephybun stephybun marked this pull request as ready for review August 22, 2025 10:58
@stephybun stephybun requested a review from a team as a code owner August 22, 2025 10:58
Copy link
Member

@austinvalle austinvalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff @stephybun! Left some initial thoughts

@stephybun
Copy link
Member Author

Test coverage might be a bit lacking, but I'll look into this in a separate PR

@stephybun stephybun requested a review from austinvalle August 26, 2025 09:16
austinvalle
austinvalle previously approved these changes Aug 27, 2025
Copy link
Member

@austinvalle austinvalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 - all of the comments are pkg doc related / nits and can be addressed later if preferred

Copy link
Member

@ansgarm ansgarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Throwing in an approve since Austin already approved and your commit since then only improved comments and strings.

@stephybun stephybun merged commit e39d577 into main Aug 28, 2025
37 checks passed
@stephybun stephybun deleted the f/list-spike-sdkv2 branch August 28, 2025 10:30
@austinvalle austinvalle added this to the v1.16.0 milestone Sep 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants