Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove most Netlify configuration #6194

Merged
merged 1 commit into from
Aug 22, 2019
Merged

Conversation

backspace
Copy link
Contributor

@backspace backspace commented Aug 22, 2019

This removes the in-repository Netlify configuration. There are now two
sites backed by the repository, so we must now use the web UI to
control the build settings, as having the configuration in-repository
overrides the web UI settings.

The build settings for the two sites are below, as of this commit. See
the extra step in nomad-ui site’s build step that copies the _redirects
file to the correct destination so things are properly forwarded when
you visit the deployment.

nomad-ui:

base directory: ui
build command: ember build && mkdir -p ui-dist/ui && mv dist/* ui-dist/ui/ && cp ../.netlify/ui-redirects ui-dist/_redirects
publish directory: ui/ui-dist

nomad-website:

base directory: website
build command: bundle exec middleman build
publish directory: website/build

@backspace backspace changed the title Change Netlify configuration Remove most Netlify configuration Aug 22, 2019
Copy link
Contributor

@DingoEatingFuzz DingoEatingFuzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

I kicked the tires on both Netlify checks and it worked as advertised.

@backspace backspace merged commit 10e675c into master Aug 22, 2019
@backspace backspace deleted the f-netlify-ui-and-website-redux branch August 22, 2019 20:54
@github-actions
Copy link

github-actions bot commented Feb 3, 2023

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants