Switch deployment to netlify #4679
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvin-huang
reviewed
Sep 14, 2018
website/deploy/variables.tf
Outdated
| @@ -0,0 +1,14 @@ | |||
| variable "name" { | |||
| default = "consul-www" | |||
jescalan
force-pushed
the
je.netlify-deploy
branch
from
2a185a9 to
1981235
Compare
|
Doing a little PR cleanup here... I'm going to close this, as the deployment configuration was changed considerably in #6194 |
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a terraform script added that provisions Netlify's configuration. This has been tested previously and is working nicely, PRs are also going out to all other project sites. Any of the variables are absolutely up for change if need be.
The Makefile has been updated to use Netlify's build image directly. The first run, this takes a bit longer to download due to it being larger than the hashicorp-middleman image, Netlify being a larger service that can deploy many types of sites. However, on subsequent runs its pretty quick and carries the additional benefit of cacheing dependencies between builds.
This PR also removes of all old deploy script pieces that I could find. If there are any I missed please let me know and I'll remove them.
We will be setting this up on HashiCorp's internal TFE instance to keep track of state and serve as a bit of a buffer to Netlify config changes, which can easily cause downtime if not done carefully.