Badge, Icon: convert to gts format #3434
Closed
+71
−101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
shleewhite
commented
Dec 10, 2025
shleewhite
commented
Dec 10, 2025
shleewhite
force-pushed
the
spike/convert-badge-gts
branch
from
96847e6 to
006a7c0
Compare
shleewhite
changed the title
shleewhite
force-pushed
the
spike/convert-badge-gts
branch
from
2314d56 to
f3eda91
Compare
aklkv
reviewed
Dec 16, 2025
| // temporary fix until the prettier plugin works with `.gts/gjs` files | ||
| // https://github.com/ember-template-lint/ember-template-lint-plugin-prettier/issues/268 | ||
| { | ||
| files: ['**/*.{gjs,gts}'], |
Collaborator
There was a problem hiding this comment.
this part can be removed once all hbs files are removed
3 tasks
Contributor
Author
|
I broke out the infra changes into their own PR: #3443 Ill simplify this PR to just be the component changes when that has merged. |
shleewhite
force-pushed
the
spike/convert-badge-gts
branch
from
f3eda91 to
63a2635
Compare
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
If merged, this PR would convert the first two Helios components to the
.gtsformat:BadgeandIcon. Changes include:components.tsfileNOTE
I am not sure why there are 4 VRT tests that are consistently failing. Looking at the diff, I can't see why anything is different. It seems to be caused by the
Iconcomponent, but it doesnt happen every time the component is used.I tried adding squishies because maybe it is a whitespace problem? But that doesn't seem to do anything. I can revert that change if we want.
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.
📋 PCI review checklist
Examples of changes to controls include access controls, encryption, logging, etc.
Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.