Skip to content

Conversation

@KristinLBradley
Copy link
Contributor

@KristinLBradley KristinLBradley commented Nov 25, 2025

WIP: Testing modifications to Button focus styles to standardize and to optimize for easier "Carbonization"

Previews:


📌 Summary

If merged, this PR modifies the focus styles of Buttons...

🛠️ Detailed description

  1. From the ticket: "the focus of the Primary HDS button has a slightly different implementation than the other HDS buttons (different offset of the ring)"
  • Testing modification of Primary Button focus styles to follow implementation of other Button variants. (Safe focus ring offset, etc.)
  • UPDATE: Visual style differences to standardize Primary Button are on hold until there's time for closer review.
  1. From the ticket: "the focus for the Carbon buttons is applied as two inset/inner shadows, with two different colors. - This is a completely different approach than ours"
  • Testing modification of Button styles to use either box-shadow or outline together with border-color instead of a pseudo-element, more compatible with Carbon's implementation.

📸 Screenshots

PROPOSED STANDARDIZATION OF “PRIMARY” FOCUS STYLE

CURRENT FOCUS STYLE
image

STANDARDIZED FOCUS STYLE
Modified to follow styling of other Button variant focus styles
image

🔗 External links

Jira tickets:


👀 Component checklist

💬 Please consider using conventional comments when reviewing this PR.

📋 PCI review checklist
  • If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
  • If applicable, I've worked with GRC to document the impact of any changes to security controls.
    Examples of changes to controls include access controls, encryption, logging, etc.
  • If applicable, I've worked with GRC to ensure compliance due to a significant change to the in-scope PCI environment.
    Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.

didoo added 30 commits November 5, 2025 16:34
…ith references to Carbon tokens, for testing
…h missing references when using Carbon tokens with theming logic
…ng references and filtering when theming is applied
@didoo didoo force-pushed the project-solar/phase-1/HDS-5202-5203-5204/dry-run-foundations branch from 2e4a003 to cb62d03 Compare December 3, 2025 21:54
didoo added 2 commits December 3, 2025 21:56
…1/00_carbon-animation-easing-format

[Project Solar / Phase 1 / Engineering Follow-ups] Fix logic to extract Carbon animation easing tokens
…9/00_standardize-carbon-font-size

[Project Solar / Phase 1 / Engineering Follow-ups] Normalize `font-size` units in Carbon design tokens
Base automatically changed from project-solar/phase-1/HDS-5202-5203-5204/dry-run-foundations to project-solar/phase-1-main-feature-branch December 5, 2025 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants