-
Notifications
You must be signed in to change notification settings - Fork 49
[Project Solar / Phase 1 / Engineering Follow-ups] Normalize font-size units in Carbon design tokens
#3400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
font-size units in Carbon design tokensfont-size units in Carbon design tokens
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
font-size units in Carbon design tokensfont-size units in Carbon design tokens
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 2 out of 3 changed files in this pull request and generated no new comments.
8c67ca4
into
project-solar/phase-1-main-feature-branch
📌 Summary
Per @dchyun code review comment, there was an issue in the generated tokens, due to the fact that the
font-sizeunits for Carbon design tokens are inrem, while the HDS tokens are inpx. This leads to incorrect output in some of the files:We want to normalize the size to avoid these issues.
🛠️ Detailed description
In this PR I have:
font-sizefromremtopxfor extracted Carbon tokens🔗 External links
Jira ticket: https://hashicorp.atlassian.net/browse/HDS-5679
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.
📋 PCI review checklist
Examples of changes to controls include access controls, encryption, logging, etc.
Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.