Skip to content

Conversation

@didoo
Copy link
Contributor

@didoo didoo commented Dec 3, 2025

📌 Summary

Per @dchyun code review comment, there was an issue in the generated tokens, due to the fact that the font-size units for Carbon design tokens are in rem, while the HDS tokens are in px. This leads to incorrect output in some of the files:

aaa

We want to normalize the size to avoid these issues.

🛠️ Detailed description

In this PR I have:

  • turned on the option to convert font-size from rem to px for extracted Carbon tokens
  • re-extracted the carbon tokens

🔗 External links

Jira ticket: https://hashicorp.atlassian.net/browse/HDS-5679


👀 Component checklist

💬 Please consider using conventional comments when reviewing this PR.

📋 PCI review checklist
  • If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
  • If applicable, I've worked with GRC to document the impact of any changes to security controls.
    Examples of changes to controls include access controls, encryption, logging, etc.
  • If applicable, I've worked with GRC to ensure compliance due to a significant change to the in-scope PCI environment.
    Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.

@didoo didoo requested a review from a team as a code owner December 3, 2025 16:48
@vercel
Copy link

vercel bot commented Dec 3, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
hds-showcase Ready Ready Preview Dec 3, 2025 4:52pm
hds-website Ready Ready Preview Dec 3, 2025 4:52pm

@didoo didoo changed the title Settings [Project Solar / Phase 1 / Engineering Follow-ups] Normalize font-size units in Carbon design tokens [Project Solar / Phase 1 / Engineering Follow-ups] Normalize font-size units in Carbon design tokens Dec 3, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@didoo didoo changed the title [Project Solar / Phase 1 / Engineering Follow-ups] Normalize font-size units in Carbon design tokens [Project Solar / Phase 1 / Engineering Follow-ups] Normalize font-size units in Carbon design tokens Dec 3, 2025
@didoo didoo requested a review from dchyun December 3, 2025 21:58
@didoo didoo requested a review from Copilot December 3, 2025 22:03
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 3 changed files in this pull request and generated no new comments.

@didoo didoo merged commit 8c67ca4 into project-solar/phase-1-main-feature-branch Dec 3, 2025
18 checks passed
@didoo didoo deleted the project-solar/phase-1/HDS-5679/00_standardize-carbon-font-size branch December 3, 2025 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants