Skip to content

Update ember-try matrix #3202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zamoore merged 3 commits into from
Oct 1, 2025
Merged

Update ember-try matrix #3202

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
aac9f20
removed 3.28 from test matrix
zamoore Sep 18, 2025
ad31e68
remove 3.28 from CI test matrix
zamoore Sep 18, 2025
a6b9823
adde changeset
zamoore Oct 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fluffy-places-ask.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@hashicorp/design-system-components": major
---

Removed support for Ember 3.28. New minimum support target is Ember 4.12.
7 changes: 3 additions & 4 deletions .github/workflows/ci-components.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ on:
pull_request: {}

env:
NODE_VERSION: '22.x'
NODE_VERSION: "22.x"

concurrency:
group: ci-components-${{ github.head_ref || github.ref }}
Expand All @@ -28,7 +28,7 @@ jobs:
run: ./.github/scripts/filter_changed_files.sh "packages/components" "packages/flight-icons/catalog.json" "showcase" ".github/workflows/ci-components.yml" "packages/tokens"

test:
name: 'Tests'
name: "Tests"
runs-on: ubuntu-latest
needs: [conditional-skip]
if: needs.conditional-skip.outputs.trigger-ci == 'true'
Expand Down Expand Up @@ -63,13 +63,12 @@ jobs:
try-scenarios:
name: ${{ matrix.try-scenario }}
runs-on: ubuntu-latest
needs: 'test'
needs: "test"

strategy:
fail-fast: false
matrix:
try-scenario:
- ember-lts-3.28
- ember-lts-4.12
# - ember-release
- ember-beta
Expand Down
32 changes: 0 additions & 32 deletions showcase/config/ember-try.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,20 +13,6 @@ module.exports = async function () {
command: 'ember test --filter="integration" --reporter xunit',
packageManager: 'pnpm',
scenarios: [
{
name: 'ember-lts-3.28',
allowedToFail: true,
npm: {
devDependencies: {
'@ember/test-helpers': '^2.0.0',
'ember-a11y-testing': '^5.2.1',
'ember-cli': '~3.28.0',
'ember-qunit': '^6.0.0',
'ember-resolver': '^8.1.0',
'ember-source': '~3.28.11',
},
},
},
{
name: 'ember-lts-4.12',
npm: {
Expand Down Expand Up @@ -59,24 +45,6 @@ module.exports = async function () {
},
},
},
{
name: 'ember-classic',
env: {
EMBER_OPTIONAL_FEATURES: JSON.stringify({
'application-template-wrapper': true,
'default-async-observers': false,
'template-only-glimmer-components': false,
}),
},
npm: {
devDependencies: {
'ember-source': '~3.28.0',
},
ember: {
edition: 'classic',
},
},
},
embroiderSafe(),
embroiderOptimized(),
],
Expand Down