-
Notifications
You must be signed in to change notification settings - Fork 49
Update ember-try matrix
#3202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ember-try matrix
#3202
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
603cbd2 to
6d406bd
Compare
|
Looks good to me! Just one other place to update. We should remove the
Also, found another 3.28 related task not related to this. Just calling it out for visibility. There is this comment in the |
Hey Dylan, it is removed there. Thanks for the review! |
@zamoore removed where? will it be done in a separate PR? |
Ahhh no I meant the |
My bad. I was referring to the github action. We can address the comment you found after the 5.0.0 release or as part of it. Going to omit it from this PR. |
@zamoore If possible, better to address it in this release (so we can revert it if we test and find it doesn't work). Not sure if there is a ticket associated, in case you can create a new one.
π |
7c0bc36 to
81a4cea
Compare
42e1aaa to
468a8bc
Compare
0c008ef to
68cd4a0
Compare
41d21f9 to
a6b9823
Compare
|
Created HDS-5534 to review the need for |

π Summary
If merged, this PR drops
3.28from theember-trytest configuration.π οΈ Detailed description
We are removing support for Ember
3.x.xin version5.0.0of Helios.π External links
Jira ticket: HDS-4946
π Component checklist
π¬ Please consider using conventional comments when reviewing this PR.
π PCI review checklist
Examples of changes to controls include access controls, encryption, logging, etc.
Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.