-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: throttled tx metrics #16130
feat: throttled tx metrics #16130
Conversation
Signed-off-by: Kim Rader <kim.rader@swirldslabs.com>
…ent the metric whenever a tx fails due to throttling. Signed-off-by: Kim Rader <kim.rader@swirldslabs.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #16130 +/- ##
=============================================
+ Coverage 58.12% 58.27% +0.15%
- Complexity 19828 19904 +76
=============================================
Files 2728 2730 +2
Lines 100009 100100 +91
Branches 10333 10338 +5
=============================================
+ Hits 58129 58338 +209
+ Misses 38260 38137 -123
- Partials 3620 3625 +5
|
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
Signed-off-by: Kim Rader <kim.rader@swirldslabs.com>
Node: HAPI Test (Restart) Results5 tests 0 ✅ 0s ⏱️ For more details on these parsing errors and failures, see this check. Results for commit 9f6e013. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM TY @kimbor
Signed-off-by: Kim Rader <kim.rader@swirldslabs.com>
Signed-off-by: Kim Rader <kim.rader@swirldslabs.com>
…era-services into 16035-throttled-tx-metrics
hedera-node/hedera-app/src/main/java/com/hedera/node/app/workflows/OpWorkflowMetrics.java
Outdated
Show resolved
Hide resolved
hedera-node/hedera-app/src/main/java/com/hedera/node/app/workflows/ingest/IngestChecker.java
Show resolved
Hide resolved
...ode/hedera-app/src/test/java/com/hedera/node/app/workflows/handle/DispatchProcessorTest.java
Show resolved
Hide resolved
Signed-off-by: Kim Rader <kim.rader@swirldslabs.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Tyvm @kimbor, I've wanted more insight into this for awhile! 🙏
Signed-off-by: Kim Rader <kim.rader@swirldslabs.com>
Signed-off-by: Kim Rader <kim.rader@swirldslabs.com>
Description:
This PR creates a new set of metrics to track when transactions and queries are throttled.
Counter
is used as the metric type. This type of metric will only ever increase. Calculation will be done on the Grafana side to translate this number into events per second.Related issue(s):
Fixes #16035