Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: throttled tx metrics #16130

Merged
merged 11 commits into from
Oct 25, 2024
Merged

feat: throttled tx metrics #16130

merged 11 commits into from
Oct 25, 2024

Conversation

kimbor
Copy link
Member

@kimbor kimbor commented Oct 23, 2024

Description:
This PR creates a new set of metrics to track when transactions and queries are throttled.

Counter is used as the metric type. This type of metric will only ever increase. Calculation will be done on the Grafana side to translate this number into events per second.

Related issue(s):
Fixes #16035

Signed-off-by: Kim Rader <kim.rader@swirldslabs.com>
…ent the metric whenever a tx fails due to throttling.

Signed-off-by: Kim Rader <kim.rader@swirldslabs.com>
@kimbor kimbor added this to the v0.56 milestone Oct 23, 2024
@kimbor kimbor self-assigned this Oct 23, 2024
@kimbor kimbor requested a review from a team as a code owner October 23, 2024 22:11
@kimbor kimbor requested a review from derektriley October 23, 2024 22:11
@kimbor kimbor changed the title 16035 throttled tx metrics feat: throttled tx metrics Oct 23, 2024
@kimbor kimbor marked this pull request as draft October 23, 2024 22:13
Copy link

codecov bot commented Oct 23, 2024

Codecov Report

Attention: Patch coverage is 84.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 58.27%. Comparing base (59843dd) to head (166650f).
Report is 6 commits behind head on develop.

Files with missing lines Patch % Lines
...m/hedera/node/app/workflows/OpWorkflowMetrics.java 78.57% 1 Missing and 2 partials ⚠️
...edera/node/app/workflows/ingest/IngestChecker.java 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #16130      +/-   ##
=============================================
+ Coverage      58.12%   58.27%   +0.15%     
- Complexity     19828    19904      +76     
=============================================
  Files           2728     2730       +2     
  Lines         100009   100100      +91     
  Branches       10333    10338       +5     
=============================================
+ Hits           58129    58338     +209     
+ Misses         38260    38137     -123     
- Partials        3620     3625       +5     
Files with missing lines Coverage Δ
...a/node/app/workflows/handle/DispatchProcessor.java 92.85% <100.00%> (+0.17%) ⬆️
...ra/node/app/workflows/query/QueryWorkflowImpl.java 88.23% <100.00%> (+0.09%) ⬆️
...edera/node/app/workflows/ingest/IngestChecker.java 74.11% <80.00%> (+0.30%) ⬆️
...m/hedera/node/app/workflows/OpWorkflowMetrics.java 88.23% <78.57%> (-4.27%) ⬇️

... and 16 files with indirect coverage changes

Impacted file tree graph

Copy link

codacy-production bot commented Oct 23, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.13% (target: -1.00%) 96.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (59843dd) 99826 61612 61.72%
Head commit (166650f) 99840 (+14) 61749 (+137) 61.85% (+0.13%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#16130) 25 24 96.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Signed-off-by: Kim Rader <kim.rader@swirldslabs.com>
@kimbor kimbor marked this pull request as ready for review October 23, 2024 22:50
Copy link

github-actions bot commented Oct 23, 2024

Node: HAPI Test (Restart) Results

5 tests   0 ✅  0s ⏱️
6 suites  0 💤
9 files    5 ❌
3 errors

For more details on these parsing errors and failures, see this check.

Results for commit 9f6e013.

♻️ This comment has been updated with latest results.

@kimbor kimbor requested a review from david-bakin-sl October 24, 2024 12:49
povolev15
povolev15 previously approved these changes Oct 24, 2024
Copy link
Contributor

@povolev15 povolev15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM TY @kimbor

Signed-off-by: Kim Rader <kim.rader@swirldslabs.com>
Signed-off-by: Kim Rader <kim.rader@swirldslabs.com>
…era-services into 16035-throttled-tx-metrics
@kimbor kimbor requested a review from povolev15 October 25, 2024 15:29
Signed-off-by: Kim Rader <kim.rader@swirldslabs.com>
Signed-off-by: Kim Rader <kim.rader@swirldslabs.com>
povolev15
povolev15 previously approved these changes Oct 25, 2024
@kimbor kimbor requested a review from mhess-swl October 25, 2024 17:33
mhess-swl
mhess-swl previously approved these changes Oct 25, 2024
Copy link
Member

@mhess-swl mhess-swl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tyvm @kimbor, I've wanted more insight into this for awhile! 🙏

Signed-off-by: Kim Rader <kim.rader@swirldslabs.com>
@kimbor kimbor merged commit 5ff5941 into develop Oct 25, 2024
48 of 49 checks passed
@kimbor kimbor deleted the 16035-throttled-tx-metrics branch October 25, 2024 18:55
Evdokia-Georgieva pushed a commit that referenced this pull request Oct 31, 2024
Signed-off-by: Kim Rader <kim.rader@swirldslabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Metric for tracking throttled transactions
3 participants