Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metric for tracking throttled transactions #16035

Closed
netopyr opened this issue Oct 18, 2024 · 2 comments · Fixed by #16130
Closed

Metric for tracking throttled transactions #16035

netopyr opened this issue Oct 18, 2024 · 2 comments · Fixed by #16130
Assignees
Milestone

Comments

@netopyr
Copy link
Contributor

netopyr commented Oct 18, 2024

Create metrics (Counter) for each transaction type and query type that track how often transactions of that type were throttled.

@netopyr netopyr converted this from a draft issue Oct 18, 2024
@netopyr
Copy link
Contributor Author

netopyr commented Oct 18, 2024

I believe the places where the metrics should be increased are these (please validate, though):

@netopyr netopyr added this to the v0.56 milestone Oct 18, 2024
@david-bakin-sl
Copy link
Member

david-bakin-sl commented Oct 21, 2024

There is already a metric for gas consumption so you can tell when the gas throttle was reached, but you don't get a count of transactions rejected because of the gas throttle.

This is by way of remiinder that for each of ContractCreate/ContractCall/EthereumTransactions we should be able to see two separate metrics: #TXs rejected due to TPS throttle, and #TXs rejected due to gas throttle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants