-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: 15438: Eliminate busy loop in HalfDiskHashMap.endWriting() #15439
Conversation
Signed-off-by: Artem Ananev <artem.ananev@swirldslabs.com>
...m-sdk/swirlds-merkledb/src/main/java/com/swirlds/merkledb/files/hashmap/HalfDiskHashMap.java
Outdated
Show resolved
Hide resolved
...m-sdk/swirlds-merkledb/src/main/java/com/swirlds/merkledb/files/hashmap/HalfDiskHashMap.java
Show resolved
Hide resolved
...m-sdk/swirlds-merkledb/src/main/java/com/swirlds/merkledb/files/hashmap/HalfDiskHashMap.java
Show resolved
Hide resolved
...m-sdk/swirlds-merkledb/src/main/java/com/swirlds/merkledb/files/hashmap/HalfDiskHashMap.java
Show resolved
Hide resolved
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #15439 +/- ##
=============================================
+ Coverage 58.22% 58.25% +0.02%
- Complexity 21573 21599 +26
=============================================
Files 2779 2781 +2
Lines 109151 109325 +174
Branches 11163 11181 +18
=============================================
+ Hits 63554 63686 +132
- Misses 41738 41774 +36
- Partials 3859 3865 +6
|
Signed-off-by: Artem Ananev <artem.ananev@swirldslabs.com>
...m-sdk/swirlds-merkledb/src/main/java/com/swirlds/merkledb/files/hashmap/HalfDiskHashMap.java
Outdated
Show resolved
Hide resolved
...m-sdk/swirlds-merkledb/src/main/java/com/swirlds/merkledb/files/hashmap/HalfDiskHashMap.java
Show resolved
Hide resolved
Signed-off-by: Artem Ananev <artem.ananev@swirldslabs.com>
Signed-off-by: Artem Ananev <artem.ananev@swirldslabs.com>
Signed-off-by: Artem Ananev <artem.ananev@swirldslabs.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pending performance testing.
...m-sdk/swirlds-merkledb/src/main/java/com/swirlds/merkledb/files/hashmap/HalfDiskHashMap.java
Show resolved
Hide resolved
...m-sdk/swirlds-merkledb/src/main/java/com/swirlds/merkledb/files/hashmap/HalfDiskHashMap.java
Outdated
Show resolved
Hide resolved
...m-sdk/swirlds-merkledb/src/main/java/com/swirlds/merkledb/files/hashmap/HalfDiskHashMap.java
Show resolved
Hide resolved
...m-sdk/swirlds-merkledb/src/main/java/com/swirlds/merkledb/files/hashmap/HalfDiskHashMap.java
Show resolved
Hide resolved
…le CPUs Signed-off-by: Artem Ananev <artem.ananev@swirldslabs.com>
9aa566d
* develop: (22 commits) test: New HAPI test for TokenAirdrop transaction (#15348) test: unit test verifySyncInvalidEd25519() is not stable (#15534) chore: add `TracerBinding` interface for `TransactionExecutors`. (#15480) chore: Add missing javadocs in Consensus Service (#15299) fix: Validate `CustomFees` input arrays in `UpdateTokenCustomFeesDecoder` (#15520) feat: migrate event serialization to protobuf (#15417) fix: 15494: Improve VirtualLeafRecord serialization to bytes during flushes (#15512) docs: tss block signing proposal (#15160) fix: 15438: Eliminate busy loop in HalfDiskHashMap.endWriting() (#15439) build: cleanup settings.gradle.kts / remove build.gradle.kts (#15470) test: fix CryptographyTests (#15529) fix: recreate block hash from state (#15444) docs: Proposal Process Update - Specify post-acceptance non-material update procedure (#15447) chore: testnet event hashing (#15432) fix: 15167: Remove timeout from reconnect/rehash Iterators (#15468) chore: remove snapshot ops (#15462) feat: Add TokenUpdateNFTs as a smart contract operation v2 (#15445) feat: introduce PbjRecordHasher and RosterUtils.hash(Roster) (#15457) fix: Precision loss for gas calculation of HTS system contracts v2 (#15446) chore: correct the variable name in roster.proto (#15465) ... # Conflicts: # hedera-node/hedera-smart-contract-service-impl/src/main/java/com/hedera/node/app/service/contract/impl/exec/scope/HandleHederaOperations.java
Fix summary:
HDHM.endWriting()
is reimplemented using fork-join pool and tasksendWriting()
is well covered by existing testsFixes: #15438
Signed-off-by: Artem Ananev artem.ananev@swirldslabs.com