Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate event serialization to protobuf #15417

Merged
merged 12 commits into from
Sep 18, 2024

Conversation

lpetrovic05
Copy link
Member

closes #15205
closes #15202

Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>
Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>
Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>
Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>
@lpetrovic05 lpetrovic05 added this to the v0.55 milestone Sep 10, 2024
@lpetrovic05 lpetrovic05 self-assigned this Sep 10, 2024
Copy link

codecov bot commented Sep 10, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 58.17%. Comparing base (7a4616b) to head (f87e956).
Report is 17 commits behind head on develop.

Files with missing lines Patch % Lines
.../platform/event/preconsensus/PcesFileIterator.java 54.54% 3 Missing and 2 partials ⚠️
...a/com/swirlds/platform/system/events/CesEvent.java 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #15417      +/-   ##
=============================================
- Coverage      58.22%   58.17%   -0.06%     
+ Complexity     21573    21556      -17     
=============================================
  Files           2779     2780       +1     
  Lines         109151   109117      -34     
  Branches       11163    11163              
=============================================
- Hits           63554    63478      -76     
- Misses         41738    41778      +40     
- Partials        3859     3861       +2     
Files with missing lines Coverage Δ
...common/io/streams/SerializableDataInputStream.java 85.96% <100.00%> (+1.49%) ⬆️
...ommon/io/streams/SerializableDataOutputStream.java 66.25% <100.00%> (+0.86%) ⬆️
...wirlds/platform/event/EventSerializationUtils.java 75.00% <100.00%> (-12.86%) ⬇️
...java/com/swirlds/platform/event/PlatformEvent.java 89.18% <100.00%> (-1.17%) ⬇️
...rm/event/preconsensus/PcesBirthRoundMigration.java 93.24% <100.00%> (ø)
...s/platform/event/preconsensus/PcesFileVersion.java 100.00% <100.00%> (ø)
...s/platform/event/preconsensus/PcesMutableFile.java 86.48% <100.00%> (ø)
...swirlds/platform/gossip/shadowgraph/SyncUtils.java 80.70% <100.00%> (ø)
.../swirlds/platform/system/events/EventMetadata.java 98.18% <100.00%> (-0.10%) ⬇️
.../swirlds/platform/system/events/UnsignedEvent.java 63.63% <100.00%> (ø)
... and 4 more

... and 12 files with indirect coverage changes

Impacted file tree graph

Copy link

codacy-production bot commented Sep 10, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.05% (target: -1.00%) 95.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (7a4616b) 108968 67303 61.76%
Head commit (f87e956) 108934 (-34) 67229 (-74) 61.72% (-0.05%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#15417) 60 57 95.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>
s
Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>
Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>
s
Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>
mxtartaglia-sl
mxtartaglia-sl previously approved these changes Sep 11, 2024
Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>
s
Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>
@lpetrovic05 lpetrovic05 merged commit 0fea101 into develop Sep 18, 2024
58 of 60 checks passed
@lpetrovic05 lpetrovic05 deleted the 15205-D-migrate-event-serialization branch September 18, 2024 10:21
netopyr added a commit that referenced this pull request Sep 19, 2024
* develop: (22 commits)
  test: New HAPI test for TokenAirdrop transaction (#15348)
  test: unit test verifySyncInvalidEd25519() is not stable (#15534)
  chore: add `TracerBinding` interface for `TransactionExecutors`. (#15480)
  chore: Add missing javadocs in Consensus Service (#15299)
  fix: Validate `CustomFees` input arrays in `UpdateTokenCustomFeesDecoder` (#15520)
  feat: migrate event serialization to protobuf (#15417)
  fix: 15494: Improve VirtualLeafRecord serialization to bytes during flushes (#15512)
  docs: tss block signing proposal (#15160)
  fix: 15438: Eliminate busy loop in HalfDiskHashMap.endWriting() (#15439)
  build: cleanup settings.gradle.kts / remove build.gradle.kts (#15470)
  test: fix CryptographyTests (#15529)
  fix: recreate block hash from state (#15444)
  docs: Proposal Process Update - Specify post-acceptance non-material update procedure (#15447)
  chore: testnet event hashing (#15432)
  fix: 15167: Remove timeout from reconnect/rehash Iterators (#15468)
  chore: remove snapshot ops (#15462)
  feat: Add TokenUpdateNFTs as a smart contract operation v2 (#15445)
  feat: introduce PbjRecordHasher and RosterUtils.hash(Roster) (#15457)
  fix: Precision loss for gas calculation of HTS system contracts v2 (#15446)
  chore: correct the variable name in roster.proto (#15465)
  ...

# Conflicts:
#	hedera-node/hedera-smart-contract-service-impl/src/main/java/com/hedera/node/app/service/contract/impl/exec/scope/HandleHederaOperations.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate event gossiping to protobuf Migrate PCES stream to protobuf
5 participants