Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added support for batch request feature to WS server (#2461) #2475

Merged
merged 7 commits into from
May 13, 2024
Merged

feat: added support for batch request feature to WS server (#2461) #2475

merged 7 commits into from
May 13, 2024

Conversation

quiet-node
Copy link
Member

@quiet-node quiet-node commented May 10, 2024 •
edited
Loading

Description:

  • adds support for batch request feature to WS server
  • adds WS neccessary config variables to configurations.md
  • added two new predefined errors, WS_BATCH_REQUESTS_DISABLED and WS_BATCH_REQUESTS_AMOUNT_MAX_EXCEEDED, to JsonRpcError object
  • added e2e tests to cover the new feature

Todo: #2474

Fixes #2461

Result

  • wscat:
image
  • postman
image image

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@quiet-node quiet-node self-assigned this May 10, 2024
@quiet-node quiet-node added enhancement New feature or request P1 dev tools Features enabling dev tool integration labels May 10, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 10, 2024 •
edited
Loading

Tests

    2 files  147 suites   13s ⏱️
819 tests 818 ✔️ 1 💤 0 ❌
831 runs  830 ✔️ 1 💤 0 ❌

Results for commit 6d5da4e.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 10, 2024 •
edited
Loading

Acceptance Tests

  18 files  271 suites   23m 53s ⏱️
583 tests 577 ✔️ 3 💤 3 ❌
967 runs  953 ✔️ 9 💤 5 ❌

Results for commit 6d5da4e.

♻️ This comment has been updated with latest results.

@quiet-node quiet-node force-pushed the 2461-cannot-send-batch-requests-to-ws-server branch from 3c008bc to 718bc02 Compare May 10, 2024 22:29
AlfredoG87
AlfredoG87 previously approved these changes May 11, 2024
View reviewed changes
Copy link
Collaborator

@AlfredoG87 AlfredoG87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG. just a few nits! 👍

docs/configuration.md Outdated Show resolved Hide resolved
packages/ws-server/src/webSocketServer.ts Outdated Show resolved Hide resolved
packages/ws-server/src/webSocketServer.ts Outdated Show resolved Hide resolved
packages/ws-server/src/webSocketServer.ts Outdated Show resolved Hide resolved
AlfredoG87
AlfredoG87 previously approved these changes May 11, 2024
View reviewed changes
Copy link
Collaborator

@AlfredoG87 AlfredoG87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@quiet-node
chore: added WS flags to configurations
b778039 
Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com>
@quiet-node
feat: added predefined errors, WS_BATCH_REQUESTS_DISABLED & WS_BATCH_…
e063c92 
…REQUESTS_AMOUNT_MAX_EXCEEDED

Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com>
@quiet-node quiet-node force-pushed the 2461-cannot-send-batch-requests-to-ws-server branch from 405f5d6 to 549e863 Compare May 11, 2024 06:30
AlfredoG87
AlfredoG87 previously approved these changes May 11, 2024
View reviewed changes
@quiet-node
feat: added batch request feature to WS server
ea9d305 
Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com>
@quiet-node
test: added e2e test for batch requests feature
46eda44 
Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com>
@quiet-node
fix: updated logging and fixed typo
7713857 
Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com>
@quiet-node
fix: enabled WS_BATCH_REQUESTS_ENABLED by default
3d56a56 
Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com>
@quiet-node
fix: moved validation logic to getRequestResult()
6d5da4e 
Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com>
@quiet-node quiet-node force-pushed the 2461-cannot-send-batch-requests-to-ws-server branch from 9410e7e to 6d5da4e Compare May 13, 2024 14:43
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 13, 2024

Quality Gate Passed Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

AlfredoG87
AlfredoG87 approved these changes May 13, 2024
View reviewed changes
Copy link
Collaborator

@AlfredoG87 AlfredoG87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@quiet-node quiet-node merged commit a1d7632 into main May 13, 2024
33 checks passed
@quiet-node quiet-node deleted the 2461-cannot-send-batch-requests-to-ws-server branch May 13, 2024 16:01
@quiet-node quiet-node added this to the 0.48.0 milestone May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlfredoG87 AlfredoG87 AlfredoG87 approved these changes

@ebadiere ebadiere Awaiting requested review from ebadiere ebadiere is a code owner

@georgi-l95 georgi-l95 Awaiting requested review from georgi-l95 georgi-l95 is a code owner

@Ivo-Yankov Ivo-Yankov Awaiting requested review from Ivo-Yankov Ivo-Yankov is a code owner

@lukelee-sl lukelee-sl Awaiting requested review from lukelee-sl lukelee-sl is a code owner

Assignees

@quiet-node quiet-node

Labels
dev tools Features enabling dev tool integration enhancement New feature or request P1
Projects
None yet
Milestone
0.48.0
Development

Successfully merging this pull request may close these issues.

Cannot send batch requests via WS endpoints
2 participants
@quiet-node @AlfredoG87