Improve metrics and add rate limit for the batch request feature in WS server #2474
Assignees
Labels
enhancement
New feature or request
Comments
2 tasks
quiet-node
added a commit
that referenced
this issue
May 16, 2024
…ture in ws server (#2474) (#2487) * feat: added shouldRateLimitOnMethod() to connectionLimiter Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com> * feat: applied shouldRateLimitOnMethod() on batch requests Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com> * feat: applied shouldRateLimitOnMethod() on single requests Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com> * feat: added methodsCounter metric for batch_requests Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com> * fix: skipped rateLimit for eth_subscribe and eth_unsubscribe Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com> * test: added acceptancetest for rate limiter in the WS Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com> * test: enabled test_ws_server in ratelimiter CI Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com> --------- Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com>
quiet-node
added a commit
that referenced
this issue
May 21, 2024
…ture in ws server (#2474) (#2487) * feat: added shouldRateLimitOnMethod() to connectionLimiter Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com> * feat: applied shouldRateLimitOnMethod() on batch requests Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com> * feat: applied shouldRateLimitOnMethod() on single requests Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com> * feat: added methodsCounter metric for batch_requests Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com> * fix: skipped rateLimit for eth_subscribe and eth_unsubscribe Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com> * test: added acceptancetest for rate limiter in the WS Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com> * test: enabled test_ws_server in ratelimiter CI Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com> --------- Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com>
quiet-node
added a commit
that referenced
this issue
May 21, 2024
feat: improved metrics and added rate limit for the batch request feature in ws server (#2474) (#2487) * feat: added shouldRateLimitOnMethod() to connectionLimiter * feat: applied shouldRateLimitOnMethod() on batch requests * feat: applied shouldRateLimitOnMethod() on single requests * feat: added methodsCounter metric for batch_requests * fix: skipped rateLimit for eth_subscribe and eth_unsubscribe * test: added acceptancetest for rate limiter in the WS * test: enabled test_ws_server in ratelimiter CI --------- Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Problem
Currently, batch request feature lack of metrics and is not rate limited.
Solution
Improve metrics and add rate limit for the batch request feature in WS server
Alternatives
No response
The text was updated successfully, but these errors were encountered: