fix: add flag for fsnetman to delete PVCs on uninstall #693

jeromy-cannon · 2024-01-24T21:20:02Z

Description

This pull request changes the following:

add flag for fsnetman to delete PVCs on uninstall
fixed inconsistent Kind failures in GitHub workflows

Related Issues

Closes CLI: fsnetman needs to delete PV and PVC on chart uninstall #543

Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>

github-actions · 2024-01-25T17:07:38Z

Unit Test Results

  26 files ±0   26 suites ±0 55s ⏱️ ±0s
109 tests ±0 105 ✔️ ±0 4 💤 ±0 0 ❌ ±0
110 runs ±0 106 ✔️ ±0 4 💤 ±0 0 ❌ ±0

Results for commit fb4598f. ± Comparison against base commit b2250cb.

♻️ This comment has been updated with latest results.

codecov · 2024-01-25T17:10:42Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b2250cb) 67.51% compared to head (fb4598f) 67.51%.

Additional details and impacted files

@@            Coverage Diff            @@
##               main     #693   +/-   ##
=========================================
  Coverage     67.51%   67.51%           
  Complexity      339      339           
=========================================
  Files            64       64           
  Lines          1336     1336           
  Branches        157      157           
=========================================
  Hits            902      902           
  Misses          371      371           
  Partials         63       63

Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>

…cally Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>

Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>

sonarqubecloud · 2024-01-25T22:51:26Z

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

## [0.18.0](v0.17.0...v0.18.0) (2024-01-26) ### Features * **cli:** use kubernetes javascript client instead of invoking kubctl CLI ([#673](#673)) ([b2250cb](b2250cb)) * switch from envoy gateway to services/ingress ([#672](#672)) ([e44e5b2](e44e5b2)) * use Acme Lets Encrypt cluster issuer for TLS in Hedera Explorer ([#677](#677)) ([f3b3028](f3b3028)) ### Bug Fixes * add flag for fsnetman to delete PVCs on uninstall ([#693](#693)) ([13b423a](13b423a))

swirlds-automation · 2024-01-26T15:34:09Z

🎉 This PR is included in version 0.18.0 🎉

The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot 📦🚀

swirlds-automation · 2024-01-29T06:14:58Z

🎉 This PR is included in version 0.18.0 🎉

The release is available on:

npm package (@release-0.18.x dist-tag)
GitHub release

Your semantic-release bot 📦🚀

commit c48943b Author: Jeromy Cannon <jeromy@swirldslabs.com> Date: Fri Jan 26 21:07:50 2024 +0000 more info to help debug Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com> commit deb9e55 Author: Jeromy Cannon <jeromy@swirldslabs.com> Date: Fri Jan 26 20:28:51 2024 +0000 force node image for kind Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com> commit 0f6052d Author: Jeromy Cannon <jeromy@swirldslabs.com> Date: Fri Jan 26 20:01:18 2024 +0000 remove single threading of workflows Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com> commit 05ac373 Author: Jeromy Cannon <jeromy@swirldslabs.com> Date: Fri Jan 26 19:57:24 2024 +0000 downgrade kind to v0.19.0 Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com> commit 78e994a Author: Jeromy Cannon <jeromy@swirldslabs.com> Date: Fri Jan 26 19:37:52 2024 +0000 update test to get away from old deprecated repo Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com> commit e973a0d Author: Jeromy Cannon <jeromy@swirldslabs.com> Date: Fri Jan 26 18:53:11 2024 +0000 updated helm caching workflow step Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com> commit 28a7529 Author: Jeromy Cannon <jeromy@swirldslabs.com> Date: Fri Jan 26 17:43:55 2024 +0000 updates based on parameter changes Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com> commit c38a194 Author: Jeromy Cannon <jeromy@swirldslabs.com> Date: Fri Jan 26 17:37:34 2024 +0000 fixed bug with set-json Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com> commit ba87c3c Author: Jeromy Cannon <jeromy@swirldslabs.com> Date: Fri Jan 26 17:17:02 2024 +0000 enablePrometheusSvcMonitor Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com> commit 2eedc70 Author: Jeromy Cannon <jeromy@swirldslabs.com> Date: Fri Jan 26 17:16:44 2024 +0000 remove unused cloud.s3/gcs.enabled Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com> commit 244b6b4 Author: Jeromy Cannon <jeromy@swirldslabs.com> Date: Fri Jan 26 17:04:37 2024 +0000 Revert "fix charts to properly use cloud.s3/gcs.enabled settings" This reverts commit 173ac33. Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com> commit 110b950 Author: Jeromy Cannon <jeromy@swirldslabs.com> Date: Fri Jan 26 16:55:33 2024 +0000 fix charts to properly use cloud.s3/gcs.enabled settings Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com> commit b5a8fd0 Author: Jeromy Cannon <jeromy@swirldslabs.com> Date: Fri Jan 26 15:13:28 2024 +0000 add hederaExplorerTlsLoadBalancerIp and hederaExplorerTlsHostName Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com> commit 91d163e Author: Jeromy Cannon <jeromy@swirldslabs.com> Date: Fri Jan 26 14:53:26 2024 +0000 update cluster issuer type Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com> commit 55fb30e Author: Jeromy Cannon <jeromy@swirldslabs.com> Date: Fri Jan 26 14:15:55 2024 +0000 remove acmeClusterIssuer Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com> commit 2d8458c Author: Jeromy Cannon <jeromy@swirldslabs.com> Date: Fri Jan 26 14:14:09 2024 +0000 removed tlsClusterIssuerNamespace Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com> commit 17cc975 Author: Jeromy Cannon <jeromy@swirldslabs.com> Date: Fri Jan 26 14:12:18 2024 +0000 removed self signed cluster issuer Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com> commit 8f37d96 Author: Jeromy Cannon <jeromy@swirldslabs.com> Date: Fri Jan 26 14:09:06 2024 +0000 flag reminder TODO for this PR Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com> commit 86931fc Author: Jeromy Cannon <jeromy@swirldslabs.com> Date: Fri Jan 26 14:07:34 2024 +0000 remove enableTls Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com> commit 7dada78 Author: Jeromy Cannon <jeromy@swirldslabs.com> Date: Fri Jan 26 13:50:52 2024 +0000 remove Envoy Gateway references in fsnetman Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com> commit 99c255a Merge: 0e1ac7a fc7ff7d Author: Lenin Mehedy <lenin.mehedy@swirldslabs.com> Date: Fri Jan 26 17:07:00 2024 +1100 Merge branch 'kind-setup-experiement' into 670-cli-rename-the-existing-chart-command commit 0e1ac7a Author: Lenin Mehedy <lenin.mehedy@swirldslabs.com> Date: Fri Jan 26 13:44:24 2024 +1100 style: fix spotless error Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com> commit ac7ae5c Author: Lenin Mehedy <lenin.mehedy@swirldslabs.com> Date: Fri Jan 26 13:33:18 2024 +1100 ci: ensure we pull correct kindest/node image before fsnetman e2e tests Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com> commit 0a74d51 Author: Lenin Mehedy <lenin.mehedy@swirldslabs.com> Date: Fri Jan 26 13:24:38 2024 +1100 ci: let jest force exit rather than hanging on errors Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com> commit fc7ff7d Author: Lenin Mehedy <lenin.mehedy@swirldslabs.com> Date: Fri Jan 26 12:19:19 2024 +1100 ci: add dependencies Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com> commit d4851c8 Author: Lenin Mehedy <lenin.mehedy@swirldslabs.com> Date: Fri Jan 26 12:09:57 2024 +1100 ci: fsnetman should depend on chart tests Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com> commit 68ebf98 Author: Lenin Mehedy <lenin.mehedy@swirldslabs.com> Date: Fri Jan 26 11:59:10 2024 +1100 ci: fix if check Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com> commit 96d8ee0 Author: Lenin Mehedy <lenin.mehedy@swirldslabs.com> Date: Fri Jan 26 12:31:16 2024 +1100 fix: add missing lines Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com> commit d8af4b8 Author: Lenin Mehedy <lenin.mehedy@swirldslabs.com> Date: Fri Jan 26 11:21:31 2024 +1100 ci: rename variables for clarity Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com> commit ee3c7d1 Author: Lenin Mehedy <lenin.mehedy@swirldslabs.com> Date: Fri Jan 26 11:10:12 2024 +1100 ci: fix changed file check Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com> commit f412c4e Author: Lenin Mehedy <lenin.mehedy@swirldslabs.com> Date: Fri Jan 26 11:03:51 2024 +1100 ci: attempt to fix access to input arg Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com> commit b4fdfb0 Author: Lenin Mehedy <lenin.mehedy@swirldslabs.com> Date: Fri Jan 26 10:54:27 2024 +1100 ci: do not run java unit tests if no relevant files are changed Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com> commit 69ddc8a Merge: d5cf3be 13b423a Author: Lenin Mehedy <lenin.mehedy@swirldslabs.com> Date: Fri Jan 26 10:05:04 2024 +1100 Merge branch 'main' into 670-cli-rename-the-existing-chart-command Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com> # Conflicts: # .github/workflows/zxc-compile-code.yaml # .github/workflows/zxc-fsnetman-tests.yaml # .github/workflows/zxc-helm-chart-tests.yaml # fullstack-network-manager/src/commands/network.mjs commit 13b423a Author: Jeromy Cannon <jeromy@swirldslabs.com> Date: Thu Jan 25 22:56:19 2024 +0000 fix: add flag for fsnetman to delete PVCs on uninstall (#693) Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com> commit d5cf3be Author: Lenin Mehedy <lenin.mehedy@swirldslabs.com> Date: Fri Jan 26 09:51:58 2024 +1100 ci: output docker info for debugging Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com> commit 526d22f Author: Lenin Mehedy <lenin.mehedy@swirldslabs.com> Date: Fri Jan 26 08:27:17 2024 +1100 ci: use node_image: kindest/node:v1.27.1 Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com> commit 9eeb733 Author: Lenin Mehedy <lenin.mehedy@swirldslabs.com> Date: Thu Jan 25 10:48:27 2024 +1100 fix: command name Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com> commit b6121dc Author: Lenin Mehedy <lenin.mehedy@swirldslabs.com> Date: Thu Jan 25 10:46:19 2024 +1100 fix: update command description for consistency Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com> commit c5fd507 Author: Lenin Mehedy <lenin.mehedy@swirldslabs.com> Date: Thu Jan 25 10:46:02 2024 +1100 fix: rename chart command to network Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com> commit b2250cb Author: Lenin Mehedy <lenin.mehedy@swirldslabs.com> Date: Thu Jan 25 10:04:25 2024 +1100 feat(cli): use kubernetes javascript client instead of invoking kubctl CLI (#673) Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com> commit 1772906 Author: Jeromy Cannon <jeromy@swirldslabs.com> Date: Wed Jan 24 17:25:22 2024 +0000 chore: switch back to acme-cluster-issuer from repo now that changes have be… (#691) Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com> commit f1191e4 Author: Jeromy Cannon <jeromy@swirldslabs.com> Date: Wed Jan 24 16:28:21 2024 +0000 chore: feedback from PR review for hedera-explorer chart changes (#690) Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com> Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>

jeromy-cannon self-assigned this Jan 24, 2024

jeromy-cannon force-pushed the 00543-fsnetman-pvc-deletes branch from 7a9c287 to 9446ce7 Compare January 24, 2024 21:21

jeromy-cannon requested a review from leninmehedy January 24, 2024 21:22

jeromy-cannon marked this pull request as ready for review January 24, 2024 21:23

leninmehedy approved these changes Jan 24, 2024

View reviewed changes

Base automatically changed from 605-kubernetes-javascript-client to main January 24, 2024 23:04

jeromy-cannon force-pushed the 00543-fsnetman-pvc-deletes branch 4 times, most recently from 5980f63 to 84a0c28 Compare January 25, 2024 15:53

nathanklick closed this Jan 25, 2024

nathanklick reopened this Jan 25, 2024

fix: add flag for fsnetman to delete PVCs on uninstall

65d7392

Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>

nathanklick force-pushed the 00543-fsnetman-pvc-deletes branch from 84a0c28 to 65d7392 Compare January 25, 2024 17:00

jeromy-cannon added 14 commits January 25, 2024 18:58

kick off build

bab415e

Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>

bump kind version

87ca4cf

Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>

ensure a consistent version of containerd and dockerd

f770bee

Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>

remove check from copy/paste

8dfca23

Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>

sudo apt-get update

2b607da

Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>

kindest/node:v1.27.1

ab2b530

Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>

sledgehammer

7de6dd9

Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>

removed fs.inotify

92edc9a

Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>

remove export

32c0629

Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>

update all workflows for consistency

893d1c1

Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>

spotless and another docker prune

498543c

Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>

docker prune switch

e6835d7

Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>

updated to not run docker prune inside of script that could be run lo…

8dd0778

…cally Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>

updated because dev-cluster.yaml doesn't match setup-e2e.sh

33b60d6

Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>

corrected based on setup kind action

fb4598f

Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>

jeromy-cannon merged commit 13b423a into main Jan 25, 2024
19 checks passed

jeromy-cannon deleted the 00543-fsnetman-pvc-deletes branch January 25, 2024 22:56

swirlds-automation added the released label Jan 26, 2024

swirlds-automation added the released on @0.18.x label Jan 29, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: add flag for fsnetman to delete PVCs on uninstall #693

fix: add flag for fsnetman to delete PVCs on uninstall #693

jeromy-cannon commented Jan 24, 2024 •

edited

Loading

github-actions bot commented Jan 25, 2024 •

edited

Loading

codecov bot commented Jan 25, 2024 •

edited

Loading

sonarqubecloud bot commented Jan 25, 2024

swirlds-automation commented Jan 26, 2024

swirlds-automation commented Jan 29, 2024

fix: add flag for fsnetman to delete PVCs on uninstall #693

fix: add flag for fsnetman to delete PVCs on uninstall #693

Conversation

jeromy-cannon commented Jan 24, 2024 • edited Loading

Description

Related Issues

github-actions bot commented Jan 25, 2024 • edited Loading

Unit Test Results

codecov bot commented Jan 25, 2024 • edited Loading

Codecov Report

sonarqubecloud bot commented Jan 25, 2024

Quality Gate passed

swirlds-automation commented Jan 26, 2024

swirlds-automation commented Jan 29, 2024

jeromy-cannon commented Jan 24, 2024 •

edited

Loading

github-actions bot commented Jan 25, 2024 •

edited

Loading

codecov bot commented Jan 25, 2024 •

edited

Loading