Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): use kubernetes javascript client instead of invoking kubctl CLI #673

Merged
merged 39 commits into from
Jan 24, 2024

Conversation

leninmehedy
Copy link
Member

@leninmehedy leninmehedy commented Jan 18, 2024

Description

This pull request changes the following:

  • Used kubernetes javascript client instead of invoking kubctl CLI (A new class K8 is created)
  • Removed old Kubectl class and replace references to kubectl with k8
  • Removed dependency on kubectl

Breaking change

  • We no longer allow creating/deleting cluster using fsnetman (we assume user has created cluster already and associated kubernetes context is available locally)
  • Refactored config manager to cache the config (We may need to revisit it later...)
  • Removed dependency on kind

Related Issues

Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
…r for cli args

Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
User is expected to bring their own kubernetes cluster

Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
…ter tracking

Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>

# Conflicts:
#	fullstack-network-manager/package-lock.json
#	fullstack-network-manager/package.json
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Copy link

github-actions bot commented Jan 24, 2024

Unit Test Results

  26 files  ±0    26 suites  ±0   58s ⏱️ -1s
109 tests ±0  105 ✔️ ±0  4 💤 ±0  0 ±0 
110 runs  ±0  106 ✔️ ±0  4 💤 ±0  0 ±0 

Results for commit 0933869. ± Comparison against base commit 1772906.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Jan 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1772906) 67.51% compared to head (0933869) 67.51%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #673   +/-   ##
=========================================
  Coverage     67.51%   67.51%           
  Complexity      339      339           
=========================================
  Files            64       64           
  Lines          1336     1336           
  Branches        157      157           
=========================================
  Hits            902      902           
  Misses          371      371           
  Partials         63       63           

Impacted file tree graph

Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
@leninmehedy leninmehedy force-pushed the 605-kubernetes-javascript-client branch from 3a99309 to af5e7a4 Compare January 24, 2024 06:20
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
@leninmehedy leninmehedy marked this pull request as ready for review January 24, 2024 07:31
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
@jeromy-cannon
Copy link
Contributor

FYI, should it set the create namespace flag during the chart install? see below:

 pwd
/Users/user/source/full-stack-testing/charts
❯ kind delete cluster
Deleting cluster "kind" ...
Deleted nodes: ["kind-control-plane"]
❯ kind create cluster
Creating cluster "kind" ...
 ✓ Ensuring node image (kindest/node:v1.27.3) 🖼
 ✓ Preparing nodes 📦
 ✓ Writing configuration 📜
 ✓ Starting control-plane 🕹️
 ✓ Installing CNI 🔌
 ✓ Installing StorageClass 💾
Set kubectl context to "kind-kind"
You can now use your cluster with:

kubectl cluster-info --context kind-kind

Have a nice day! 👋
❯
❯ git status
On branch 605-kubernetes-javascript-client
Your branch is up to date with 'origin/605-kubernetes-javascript-client'.

Untracked files:
  (use "git add <file>..." to include in what will be committed)
	x.yaml

nothing added to commit but untracked files present (use "git add" to track)
❯ fsnetman cluster setup -d .

-------------------------------------------------------------------------------
*** Fullstack Network Manager (FsNetMan) ***
Version			: 0.17.0
Kubernetes Context	: kind-kind
Kubernetes Cluster	: kind-kind
-------------------------------------------------------------------------------

(node:94160) [DEP0040] DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead.
(Use `node --trace-deprecation ...` to show where the warning was created)
✔ Initialize
✔ Prepare chart values [7s]
✔ Install 'fullstack-cluster-setup' chart [17s]


 *** Installed Charts ***
-------------------------------------------------------------------------------
 - fullstack-cluster-setup [fullstack-cluster-setup-0.17.0]
❯ fsnetman chart install -d .

-------------------------------------------------------------------------------
*** Fullstack Network Manager (FsNetMan) ***
Version			: 0.17.0
Kubernetes Context	: kind-kind
Kubernetes Cluster	: kind-kind
-------------------------------------------------------------------------------

(node:94285) [DEP0040] DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead.
(Use `node --trace-deprecation ...` to show where the warning was created)
✖ namespace fst-user does not exist
◼ Install chart 'fullstack-deployment'
◼ Waiting for network pods to be ready
ERROR Error installing chart fullstack-deployment
 ~/s/full-stack-testing/charts  605-kubernetes-javascript-client ?1 

Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
@leninmehedy
Copy link
Member Author

FYI, should it set the create namespace flag during the chart install? see below:

yes, just added --create-namespace to the helm command to let it create it

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@leninmehedy leninmehedy merged commit b2250cb into main Jan 24, 2024
19 checks passed
@leninmehedy leninmehedy deleted the 605-kubernetes-javascript-client branch January 24, 2024 23:04
swirlds-automation added a commit that referenced this pull request Jan 26, 2024
## [0.18.0](v0.17.0...v0.18.0) (2024-01-26)

### Features

* **cli:** use kubernetes javascript client instead of invoking kubctl CLI ([#673](#673)) ([b2250cb](b2250cb))
* switch from envoy gateway to services/ingress ([#672](#672)) ([e44e5b2](e44e5b2))
* use Acme Lets Encrypt cluster issuer for TLS in Hedera Explorer ([#677](#677)) ([f3b3028](f3b3028))

### Bug Fixes

* add flag for fsnetman to delete PVCs on uninstall ([#693](#693)) ([13b423a](13b423a))
@swirlds-automation
Copy link
Contributor

🎉 This PR is included in version 0.18.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@swirlds-automation
Copy link
Contributor

🎉 This PR is included in version 0.18.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

jeromy-cannon added a commit that referenced this pull request Jan 29, 2024
commit c48943b
Author: Jeromy Cannon <jeromy@swirldslabs.com>
Date:   Fri Jan 26 21:07:50 2024 +0000

    more info to help debug

    Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>

commit deb9e55
Author: Jeromy Cannon <jeromy@swirldslabs.com>
Date:   Fri Jan 26 20:28:51 2024 +0000

    force node image for kind

    Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>

commit 0f6052d
Author: Jeromy Cannon <jeromy@swirldslabs.com>
Date:   Fri Jan 26 20:01:18 2024 +0000

    remove single threading of workflows

    Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>

commit 05ac373
Author: Jeromy Cannon <jeromy@swirldslabs.com>
Date:   Fri Jan 26 19:57:24 2024 +0000

    downgrade kind to v0.19.0

    Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>

commit 78e994a
Author: Jeromy Cannon <jeromy@swirldslabs.com>
Date:   Fri Jan 26 19:37:52 2024 +0000

    update test to get away from old deprecated repo

    Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>

commit e973a0d
Author: Jeromy Cannon <jeromy@swirldslabs.com>
Date:   Fri Jan 26 18:53:11 2024 +0000

    updated helm caching workflow step

    Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>

commit 28a7529
Author: Jeromy Cannon <jeromy@swirldslabs.com>
Date:   Fri Jan 26 17:43:55 2024 +0000

    updates based on parameter changes

    Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>

commit c38a194
Author: Jeromy Cannon <jeromy@swirldslabs.com>
Date:   Fri Jan 26 17:37:34 2024 +0000

    fixed bug with set-json

    Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>

commit ba87c3c
Author: Jeromy Cannon <jeromy@swirldslabs.com>
Date:   Fri Jan 26 17:17:02 2024 +0000

    enablePrometheusSvcMonitor

    Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>

commit 2eedc70
Author: Jeromy Cannon <jeromy@swirldslabs.com>
Date:   Fri Jan 26 17:16:44 2024 +0000

    remove unused cloud.s3/gcs.enabled

    Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>

commit 244b6b4
Author: Jeromy Cannon <jeromy@swirldslabs.com>
Date:   Fri Jan 26 17:04:37 2024 +0000

    Revert "fix charts to properly use cloud.s3/gcs.enabled settings"

    This reverts commit 173ac33.

    Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>

commit 110b950
Author: Jeromy Cannon <jeromy@swirldslabs.com>
Date:   Fri Jan 26 16:55:33 2024 +0000

    fix charts to properly use cloud.s3/gcs.enabled settings

    Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>

commit b5a8fd0
Author: Jeromy Cannon <jeromy@swirldslabs.com>
Date:   Fri Jan 26 15:13:28 2024 +0000

    add hederaExplorerTlsLoadBalancerIp and hederaExplorerTlsHostName

    Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>

commit 91d163e
Author: Jeromy Cannon <jeromy@swirldslabs.com>
Date:   Fri Jan 26 14:53:26 2024 +0000

    update cluster issuer type

    Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>

commit 55fb30e
Author: Jeromy Cannon <jeromy@swirldslabs.com>
Date:   Fri Jan 26 14:15:55 2024 +0000

    remove acmeClusterIssuer

    Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>

commit 2d8458c
Author: Jeromy Cannon <jeromy@swirldslabs.com>
Date:   Fri Jan 26 14:14:09 2024 +0000

    removed tlsClusterIssuerNamespace

    Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>

commit 17cc975
Author: Jeromy Cannon <jeromy@swirldslabs.com>
Date:   Fri Jan 26 14:12:18 2024 +0000

    removed self signed cluster issuer

    Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>

commit 8f37d96
Author: Jeromy Cannon <jeromy@swirldslabs.com>
Date:   Fri Jan 26 14:09:06 2024 +0000

    flag reminder TODO for this PR

    Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>

commit 86931fc
Author: Jeromy Cannon <jeromy@swirldslabs.com>
Date:   Fri Jan 26 14:07:34 2024 +0000

    remove enableTls

    Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>

commit 7dada78
Author: Jeromy Cannon <jeromy@swirldslabs.com>
Date:   Fri Jan 26 13:50:52 2024 +0000

    remove Envoy Gateway references in fsnetman

    Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>

commit 99c255a
Merge: 0e1ac7a fc7ff7d
Author: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Date:   Fri Jan 26 17:07:00 2024 +1100

    Merge branch 'kind-setup-experiement' into 670-cli-rename-the-existing-chart-command

commit 0e1ac7a
Author: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Date:   Fri Jan 26 13:44:24 2024 +1100

    style: fix spotless error

    Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>

commit ac7ae5c
Author: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Date:   Fri Jan 26 13:33:18 2024 +1100

    ci: ensure we pull correct kindest/node image before fsnetman e2e tests

    Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>

commit 0a74d51
Author: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Date:   Fri Jan 26 13:24:38 2024 +1100

    ci: let jest force exit rather than hanging on errors

    Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>

commit fc7ff7d
Author: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Date:   Fri Jan 26 12:19:19 2024 +1100

    ci: add dependencies

    Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>

commit d4851c8
Author: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Date:   Fri Jan 26 12:09:57 2024 +1100

    ci: fsnetman should depend on chart tests

    Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>

commit 68ebf98
Author: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Date:   Fri Jan 26 11:59:10 2024 +1100

    ci: fix if check

    Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>

commit 96d8ee0
Author: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Date:   Fri Jan 26 12:31:16 2024 +1100

    fix: add missing lines

    Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>

commit d8af4b8
Author: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Date:   Fri Jan 26 11:21:31 2024 +1100

    ci: rename variables for clarity

    Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>

commit ee3c7d1
Author: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Date:   Fri Jan 26 11:10:12 2024 +1100

    ci: fix changed file check

    Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>

commit f412c4e
Author: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Date:   Fri Jan 26 11:03:51 2024 +1100

    ci: attempt to fix access to input arg

    Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>

commit b4fdfb0
Author: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Date:   Fri Jan 26 10:54:27 2024 +1100

    ci: do not run java unit tests if no relevant files are changed

    Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>

commit 69ddc8a
Merge: d5cf3be 13b423a
Author: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Date:   Fri Jan 26 10:05:04 2024 +1100

    Merge branch 'main' into 670-cli-rename-the-existing-chart-command

    Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>

    # Conflicts:
    #	.github/workflows/zxc-compile-code.yaml
    #	.github/workflows/zxc-fsnetman-tests.yaml
    #	.github/workflows/zxc-helm-chart-tests.yaml
    #	fullstack-network-manager/src/commands/network.mjs

commit 13b423a
Author: Jeromy Cannon <jeromy@swirldslabs.com>
Date:   Thu Jan 25 22:56:19 2024 +0000

    fix: add flag for fsnetman to delete PVCs on uninstall (#693)

    Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>

commit d5cf3be
Author: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Date:   Fri Jan 26 09:51:58 2024 +1100

    ci: output docker info for debugging

    Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>

commit 526d22f
Author: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Date:   Fri Jan 26 08:27:17 2024 +1100

    ci: use node_image: kindest/node:v1.27.1

    Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>

commit 9eeb733
Author: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Date:   Thu Jan 25 10:48:27 2024 +1100

    fix: command name

    Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>

commit b6121dc
Author: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Date:   Thu Jan 25 10:46:19 2024 +1100

    fix: update command description for consistency

    Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>

commit c5fd507
Author: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Date:   Thu Jan 25 10:46:02 2024 +1100

    fix: rename chart command to network

    Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>

commit b2250cb
Author: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Date:   Thu Jan 25 10:04:25 2024 +1100

    feat(cli): use kubernetes javascript client instead of invoking kubctl CLI (#673)

    Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>

commit 1772906
Author: Jeromy Cannon <jeromy@swirldslabs.com>
Date:   Wed Jan 24 17:25:22 2024 +0000

    chore: switch back to acme-cluster-issuer from repo now that changes have be… (#691)

    Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>

commit f1191e4
Author: Jeromy Cannon <jeromy@swirldslabs.com>
Date:   Wed Jan 24 16:28:21 2024 +0000

    chore: feedback from PR review for hedera-explorer chart changes (#690)

    Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>

Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
jeromy-cannon added a commit that referenced this pull request Jan 29, 2024
commit c48943b
Author: Jeromy Cannon <jeromy@swirldslabs.com>
Date:   Fri Jan 26 21:07:50 2024 +0000

    more info to help debug

    Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>

commit deb9e55
Author: Jeromy Cannon <jeromy@swirldslabs.com>
Date:   Fri Jan 26 20:28:51 2024 +0000

    force node image for kind

    Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>

commit 0f6052d
Author: Jeromy Cannon <jeromy@swirldslabs.com>
Date:   Fri Jan 26 20:01:18 2024 +0000

    remove single threading of workflows

    Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>

commit 05ac373
Author: Jeromy Cannon <jeromy@swirldslabs.com>
Date:   Fri Jan 26 19:57:24 2024 +0000

    downgrade kind to v0.19.0

    Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>

commit 78e994a
Author: Jeromy Cannon <jeromy@swirldslabs.com>
Date:   Fri Jan 26 19:37:52 2024 +0000

    update test to get away from old deprecated repo

    Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>

commit e973a0d
Author: Jeromy Cannon <jeromy@swirldslabs.com>
Date:   Fri Jan 26 18:53:11 2024 +0000

    updated helm caching workflow step

    Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>

commit 28a7529
Author: Jeromy Cannon <jeromy@swirldslabs.com>
Date:   Fri Jan 26 17:43:55 2024 +0000

    updates based on parameter changes

    Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>

commit c38a194
Author: Jeromy Cannon <jeromy@swirldslabs.com>
Date:   Fri Jan 26 17:37:34 2024 +0000

    fixed bug with set-json

    Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>

commit ba87c3c
Author: Jeromy Cannon <jeromy@swirldslabs.com>
Date:   Fri Jan 26 17:17:02 2024 +0000

    enablePrometheusSvcMonitor

    Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>

commit 2eedc70
Author: Jeromy Cannon <jeromy@swirldslabs.com>
Date:   Fri Jan 26 17:16:44 2024 +0000

    remove unused cloud.s3/gcs.enabled

    Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>

commit 244b6b4
Author: Jeromy Cannon <jeromy@swirldslabs.com>
Date:   Fri Jan 26 17:04:37 2024 +0000

    Revert "fix charts to properly use cloud.s3/gcs.enabled settings"

    This reverts commit 173ac33.

    Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>

commit 110b950
Author: Jeromy Cannon <jeromy@swirldslabs.com>
Date:   Fri Jan 26 16:55:33 2024 +0000

    fix charts to properly use cloud.s3/gcs.enabled settings

    Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>

commit b5a8fd0
Author: Jeromy Cannon <jeromy@swirldslabs.com>
Date:   Fri Jan 26 15:13:28 2024 +0000

    add hederaExplorerTlsLoadBalancerIp and hederaExplorerTlsHostName

    Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>

commit 91d163e
Author: Jeromy Cannon <jeromy@swirldslabs.com>
Date:   Fri Jan 26 14:53:26 2024 +0000

    update cluster issuer type

    Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>

commit 55fb30e
Author: Jeromy Cannon <jeromy@swirldslabs.com>
Date:   Fri Jan 26 14:15:55 2024 +0000

    remove acmeClusterIssuer

    Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>

commit 2d8458c
Author: Jeromy Cannon <jeromy@swirldslabs.com>
Date:   Fri Jan 26 14:14:09 2024 +0000

    removed tlsClusterIssuerNamespace

    Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>

commit 17cc975
Author: Jeromy Cannon <jeromy@swirldslabs.com>
Date:   Fri Jan 26 14:12:18 2024 +0000

    removed self signed cluster issuer

    Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>

commit 8f37d96
Author: Jeromy Cannon <jeromy@swirldslabs.com>
Date:   Fri Jan 26 14:09:06 2024 +0000

    flag reminder TODO for this PR

    Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>

commit 86931fc
Author: Jeromy Cannon <jeromy@swirldslabs.com>
Date:   Fri Jan 26 14:07:34 2024 +0000

    remove enableTls

    Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>

commit 7dada78
Author: Jeromy Cannon <jeromy@swirldslabs.com>
Date:   Fri Jan 26 13:50:52 2024 +0000

    remove Envoy Gateway references in fsnetman

    Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>

commit 99c255a
Merge: 0e1ac7a fc7ff7d
Author: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Date:   Fri Jan 26 17:07:00 2024 +1100

    Merge branch 'kind-setup-experiement' into 670-cli-rename-the-existing-chart-command

commit 0e1ac7a
Author: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Date:   Fri Jan 26 13:44:24 2024 +1100

    style: fix spotless error

    Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>

commit ac7ae5c
Author: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Date:   Fri Jan 26 13:33:18 2024 +1100

    ci: ensure we pull correct kindest/node image before fsnetman e2e tests

    Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>

commit 0a74d51
Author: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Date:   Fri Jan 26 13:24:38 2024 +1100

    ci: let jest force exit rather than hanging on errors

    Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>

commit fc7ff7d
Author: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Date:   Fri Jan 26 12:19:19 2024 +1100

    ci: add dependencies

    Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>

commit d4851c8
Author: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Date:   Fri Jan 26 12:09:57 2024 +1100

    ci: fsnetman should depend on chart tests

    Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>

commit 68ebf98
Author: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Date:   Fri Jan 26 11:59:10 2024 +1100

    ci: fix if check

    Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>

commit 96d8ee0
Author: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Date:   Fri Jan 26 12:31:16 2024 +1100

    fix: add missing lines

    Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>

commit d8af4b8
Author: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Date:   Fri Jan 26 11:21:31 2024 +1100

    ci: rename variables for clarity

    Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>

commit ee3c7d1
Author: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Date:   Fri Jan 26 11:10:12 2024 +1100

    ci: fix changed file check

    Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>

commit f412c4e
Author: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Date:   Fri Jan 26 11:03:51 2024 +1100

    ci: attempt to fix access to input arg

    Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>

commit b4fdfb0
Author: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Date:   Fri Jan 26 10:54:27 2024 +1100

    ci: do not run java unit tests if no relevant files are changed

    Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>

commit 69ddc8a
Merge: d5cf3be 13b423a
Author: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Date:   Fri Jan 26 10:05:04 2024 +1100

    Merge branch 'main' into 670-cli-rename-the-existing-chart-command

    Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>

    # Conflicts:
    #	.github/workflows/zxc-compile-code.yaml
    #	.github/workflows/zxc-fsnetman-tests.yaml
    #	.github/workflows/zxc-helm-chart-tests.yaml
    #	fullstack-network-manager/src/commands/network.mjs

commit 13b423a
Author: Jeromy Cannon <jeromy@swirldslabs.com>
Date:   Thu Jan 25 22:56:19 2024 +0000

    fix: add flag for fsnetman to delete PVCs on uninstall (#693)

    Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>

commit d5cf3be
Author: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Date:   Fri Jan 26 09:51:58 2024 +1100

    ci: output docker info for debugging

    Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>

commit 526d22f
Author: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Date:   Fri Jan 26 08:27:17 2024 +1100

    ci: use node_image: kindest/node:v1.27.1

    Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>

commit 9eeb733
Author: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Date:   Thu Jan 25 10:48:27 2024 +1100

    fix: command name

    Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>

commit b6121dc
Author: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Date:   Thu Jan 25 10:46:19 2024 +1100

    fix: update command description for consistency

    Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>

commit c5fd507
Author: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Date:   Thu Jan 25 10:46:02 2024 +1100

    fix: rename chart command to network

    Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>

commit b2250cb
Author: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Date:   Thu Jan 25 10:04:25 2024 +1100

    feat(cli): use kubernetes javascript client instead of invoking kubctl CLI (#673)

    Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>

commit 1772906
Author: Jeromy Cannon <jeromy@swirldslabs.com>
Date:   Wed Jan 24 17:25:22 2024 +0000

    chore: switch back to acme-cluster-issuer from repo now that changes have be… (#691)

    Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>

commit f1191e4
Author: Jeromy Cannon <jeromy@swirldslabs.com>
Date:   Wed Jan 24 16:28:21 2024 +0000

    chore: feedback from PR review for hedera-explorer chart changes (#690)

    Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>

Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CLI: Use Javascript native Kubernetes API Client instead of executing the Kube Control CLI command
3 participants