fix: update configurations for mirror uploader sidecars #138
Conversation
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
leninmehedy
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #138 +/- ##
=========================================
Coverage 51.79% 51.79%
Complexity 139 139
=========================================
Files 36 36
Lines 668 668
Branches 73 73
=========================================
Hits 346 346
Misses 290 290
Partials 32 32 |
| image: {{ $.Values.infrastructure.docker.registry }}/{{ $.Values.infrastructure.docker.images.root }} | ||
| image: {{ $.Values.infrastructure.docker.images.root }} | ||
| command: [ "/bin/sh" ] | ||
| args: [ "-c", "while true; do echo root:heartbeat; sleep 10;done" ] |
There was a problem hiding this comment.
We are having this sleep block to keep the root container running.
There was a problem hiding this comment.
This behavior is incorrect as the root container should be our standard image running the full init process. If we are using the ubi8-init-dind or ubi8-init-java17 images then we should not be overriding the entrypoint/command.
There was a problem hiding this comment.
yes, this was just a temporary change. The root image didn't have an entry-point so it was terminating. I'll remove it with my next PR.
Signed-off-by: Deepak Mishra <deepak@swirldslabs.com>
|
Kudos, SonarCloud Quality Gate passed!
|
## [0.2.0](v0.1.2...v0.2.0) (2023-07-05) ### Features * add github templates ([#124](#124)) ([7990742](7990742)) * add otel collector sidecar container ([#134](#134)) ([09de701](09de701)) * add semantic-release based CI pipelines ([#136](#136)) ([76055e0](76055e0)) * add SLF4J logging to fullstack-helm-client module ([#137](#137)) ([4115810](4115810)) * boilerplate helm chart ([#121](#121)) ([70c66ca](70c66ca)) * implement mirror.py container support (via side car) ([#135](#135)) ([c8ea9e2](c8ea9e2)) * publish the helm client to maven central ([#123](#123)) ([6b40d2d](6b40d2d)) * relocates the docker image definition and adds a new image definition ([#126](#126)) ([db59e7c](db59e7c)) ### Bug Fixes * update configurations for mirror uploader sidecars ([#138](#138)) ([118662f](118662f))
|
🎉 This PR is included in version 0.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Description
This pull request changes the following:
Related Issues
Previously
network-node-*containers were crashing and now with the updated config these are running as expected: