Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement mirror.py container support (via side car) #135

Merged
merged 4 commits into from
Jun 29, 2023

Conversation

deepak-swirlds
Copy link
Contributor

Description

This pull request changes the following:

  • introducing uploader side cars with real configuration
  • make them optional via configuration

Related Issues

Signed-off-by: Deepak Mishra <deepak@swirldslabs.com>
@deepak-swirlds deepak-swirlds force-pushed the 112-implement-mirror-py-container-support branch from ec0cdf4 to b3c0a48 Compare June 29, 2023 11:39
@github-actions
Copy link

github-actions bot commented Jun 29, 2023

Unit Test Results

35 tests  ±0   32 ✔️ ±0   29s ⏱️ ±0s
  8 suites ±0     3 💤 ±0 
  8 files   ±0     0 ±0 

Results for commit 3994546. ± Comparison against base commit dc0a27a.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Merging #135 (3994546) into main (dc0a27a) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #135   +/-   ##
=========================================
  Coverage     51.79%   51.79%           
  Complexity      139      139           
=========================================
  Files            36       36           
  Lines           668      668           
  Branches         73       73           
=========================================
  Hits            346      346           
  Misses          290      290           
  Partials         32       32           

Impacted file tree graph

Signed-off-by: Deepak Mishra <deepak@swirldslabs.com>
Signed-off-by: Deepak Mishra <deepak@swirldslabs.com>
@deepak-swirlds deepak-swirlds force-pushed the 112-implement-mirror-py-container-support branch from fbda634 to 3994546 Compare June 29, 2023 19:51
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@nathanklick nathanklick merged commit c8ea9e2 into main Jun 29, 2023
@nathanklick nathanklick deleted the 112-implement-mirror-py-container-support branch June 29, 2023 23:26
swirlds-automation added a commit that referenced this pull request Jul 5, 2023
## [0.2.0](v0.1.2...v0.2.0) (2023-07-05)

### Features

* add github templates ([#124](#124)) ([7990742](7990742))
* add otel collector sidecar container ([#134](#134)) ([09de701](09de701))
* add semantic-release based CI pipelines ([#136](#136)) ([76055e0](76055e0))
* add SLF4J logging to fullstack-helm-client module ([#137](#137)) ([4115810](4115810))
* boilerplate helm chart ([#121](#121)) ([70c66ca](70c66ca))
* implement mirror.py container support (via side car) ([#135](#135)) ([c8ea9e2](c8ea9e2))
* publish the helm client to maven central ([#123](#123)) ([6b40d2d](6b40d2d))
* relocates the docker image definition and adds a new image definition ([#126](#126)) ([db59e7c](db59e7c))

### Bug Fixes

* update configurations for mirror uploader sidecars ([#138](#138)) ([118662f](118662f))
@swirlds-automation
Copy link
Contributor

🎉 This PR is included in version 0.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Charts[Network Node]: Implement mirror.py container support
3 participants