Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misc NDM Improvement #55

Merged
merged 18 commits into from
Jul 3, 2023
Merged

Misc NDM Improvement #55

merged 18 commits into from
Jul 3, 2023

Commits on May 29, 2023

  1. scripts: make generate-manifest work 

        - we could mount `manifest` so that we can make generate-manifest
      applied easily

Signed-off-by: Vicente Cheng <vicente.cheng@suse.com>
    @Vicente-Cheng
    Vicente-Cheng committed May 29, 2023
    Configuration menu
    Copy the full SHA
    2b1f22c View commit details
    Browse the repository at this point in the history

  2. controller: rename the mount operation more clear 

        - Also, add some logs to make debugging easy.

Signed-off-by: Vicente Cheng <vicente.cheng@suse.com>
    @Vicente-Cheng
    Vicente-Cheng committed May 29, 2023
    Configuration menu
    Copy the full SHA
    d0b2ff2 View commit details
    Browse the repository at this point in the history

  3. common: misc improvement and cleanup 

        - remove the redundant code
    - move util function together
    - refine the blkid command
    - improve the logger and comment

Signed-off-by: Vicente Cheng <vicente.cheng@suse.com>
    @Vicente-Cheng
    Vicente-Cheng committed May 29, 2023
    Configuration menu
    Copy the full SHA
    73f3a49 View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2023

  1. blockdevice: inactive device instead delete 

    Signed-off-by: Vicente Cheng <vicente.cheng@suse.com>
    @Vicente-Cheng
    Vicente-Cheng committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    5d261bc View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2023

  1. CRD: add corrupted status 

        - That would be give a chance to run e2fsck
    - Also change the DevPath to the current host path

Signed-off-by: Vicente Cheng <vicente.cheng@suse.com>
    @Vicente-Cheng
    Vicente-Cheng committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    df0b3f8 View commit details
    Browse the repository at this point in the history

  2. controller: add corrupted disk handling 

    Signed-off-by: Vicente Cheng <vicente.cheng@suse.com>
    @Vicente-Cheng
    Vicente-Cheng committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    ce2537d View commit details
    Browse the repository at this point in the history

  3. controller: remove scanner polling 

        - now we are triggered by uevent
    - minor log improvement

Signed-off-by: Vicente Cheng <vicente.cheng@suse.com>
    @Vicente-Cheng
    Vicente-Cheng committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    011065c View commit details
    Browse the repository at this point in the history

  4. ci: add single disk and hotplug test 

        - SingleDisk: autoprovision, unprovision, provision
    - Hotplug: add, remove

    Some minor changes including:
    - run ci-integration test directly
    - improve debug information when test fail

Signed-off-by: Vicente Cheng <vicente.cheng@suse.com>
    @Vicente-Cheng
    Vicente-Cheng committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    88c6481 View commit details
    Browse the repository at this point in the history

  5. bump golang, wrangler and client-go 

      - golang to v1.19
  - wrangler to v1.1.1
  - client-go to v0.24.13
  - longhorn to v1.4.2, also bump to v1beta2 api
  - golangci-lint to v1.52.0

  Also, minor fix the ci complain

Signed-off-by: Vicente Cheng <vicente.cheng@suse.com>
    @Vicente-Cheng
    Vicente-Cheng committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    2d6e13f View commit details
    Browse the repository at this point in the history

  6. CRD: add repaired to FileSystem Spec 

    Signed-off-by: Vicente Cheng <vicente.cheng@suse.com>
    @Vicente-Cheng
    Vicente-Cheng committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    11e3ddd View commit details
    Browse the repository at this point in the history

  7. ci: Always get NDM log 

        - That would be helpful for debugging
    - Add more check for integration tests
    - Using longhorn v1.4.2

Signed-off-by: Vicente Cheng <vicente.cheng@suse.com>
    @Vicente-Cheng
    Vicente-Cheng committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    22adf70 View commit details
    Browse the repository at this point in the history

  8. controller/node: correct the checking condition when OnRemove 

    Signed-off-by: Vicente Cheng <vicente.cheng@suse.com>
    @Vicente-Cheng
    Vicente-Cheng committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    cb6307d View commit details
    Browse the repository at this point in the history

  9. common: rename util to utils 

      - Wraper the cond lock for caller
  - Use block channel for waiting scanner stop
  - Improve the log message with uevent

Signed-off-by: Vicente Cheng <vicente.cheng@suse.com>
    @Vicente-Cheng
    Vicente-Cheng committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    92b5d07 View commit details
    Browse the repository at this point in the history

  10. common: remove the deprecated package io/ioutil 

      - now some functions are replaced on standard library `os`

Signed-off-by: Vicente Cheng <vicente.cheng@suse.com>
    @Vicente-Cheng
    Vicente-Cheng committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    80a8731 View commit details
    Browse the repository at this point in the history

  11. controller: should check DiskAddedToNode for corner case 

        We need to check the `DiskAddedToNode` with the provision device
    because we may fail to update the device.
    That means the device status is not `Provisioned`, but the LH
    node already has the disk.
    We would not do the next update to make the device `Provisioned`.

Signed-off-by: Vicente Cheng <vicente.cheng@suse.com>
    @Vicente-Cheng
    Vicente-Cheng committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    088a67e View commit details
    Browse the repository at this point in the history

  12. README: add Appendix for libvirt disk 

        - Add xml sample to let user to add disk w/ WWN

Signed-off-by: Vicente Cheng <vicente.cheng@suse.com>
    @Vicente-Cheng
    Vicente-Cheng committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    23a1460 View commit details
    Browse the repository at this point in the history

  13. golangci: add gosec to linter 

        - change json format to yaml
    - skip G204 (gosec)
    - fix others lint errors

Signed-off-by: Vicente Cheng <vicente.cheng@suse.com>
    @Vicente-Cheng
    Vicente-Cheng committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    f3dfff4 View commit details
    Browse the repository at this point in the history

  14. ci: add upgrade 

        - Add upgrade test on CI. The detail steps as below

      1. Install latest version
      2. Add disk
      3. Upgrade to the develping image
      4. Run integration test

Signed-off-by: Vicente Cheng <vicente.cheng@suse.com>
    @Vicente-Cheng
    Vicente-Cheng committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    73f17bd View commit details
    Browse the repository at this point in the history