-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Misc NDM Improvement #55
Merged
Vicente-Cheng
merged 18 commits into
harvester:master
from
Vicente-Cheng:wip-NDM-improvement
Jul 3, 2023
Merged
Misc NDM Improvement #55
Vicente-Cheng
merged 18 commits into
harvester:master
from
Vicente-Cheng:wip-NDM-improvement
Jul 3, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vicente-Cheng
force-pushed
the
wip-NDM-improvement
branch
12 times, most recently
from
March 28, 2023 11:20
f45112c
to
7311c01
Compare
Vicente-Cheng
force-pushed
the
wip-NDM-improvement
branch
3 times, most recently
from
March 28, 2023 15:47
7356be2
to
cd3680d
Compare
Vicente-Cheng
force-pushed
the
wip-NDM-improvement
branch
from
April 6, 2023 03:33
cd3680d
to
ff66ddc
Compare
Vicente-Cheng
force-pushed
the
wip-NDM-improvement
branch
8 times, most recently
from
April 7, 2023 07:21
b267e2f
to
4f9b796
Compare
Vicente-Cheng
force-pushed
the
wip-NDM-improvement
branch
from
April 21, 2023 02:41
4f9b796
to
0c90444
Compare
Vicente-Cheng
force-pushed
the
wip-NDM-improvement
branch
7 times, most recently
from
July 3, 2023 06:01
67c0b8e
to
3136f34
Compare
Update Try to attach some disks in a very short time, but only some are created:
Block devices (please ignore node3)
Virtual disks:
|
Vicente-Cheng
force-pushed
the
wip-NDM-improvement
branch
from
July 3, 2023 07:23
3136f34
to
4305d57
Compare
bk201
reviewed
Jul 3, 2023
- That would be give a chance to run e2fsck - Also change the DevPath to the current host path Signed-off-by: Vicente Cheng <vicente.cheng@suse.com>
Signed-off-by: Vicente Cheng <vicente.cheng@suse.com>
- now we are triggered by uevent - minor log improvement Signed-off-by: Vicente Cheng <vicente.cheng@suse.com>
- SingleDisk: autoprovision, unprovision, provision - Hotplug: add, remove Some minor changes including: - run ci-integration test directly - improve debug information when test fail Signed-off-by: Vicente Cheng <vicente.cheng@suse.com>
- golang to v1.19 - wrangler to v1.1.1 - client-go to v0.24.13 - longhorn to v1.4.2, also bump to v1beta2 api - golangci-lint to v1.52.0 Also, minor fix the ci complain Signed-off-by: Vicente Cheng <vicente.cheng@suse.com>
Signed-off-by: Vicente Cheng <vicente.cheng@suse.com>
- That would be helpful for debugging - Add more check for integration tests - Using longhorn v1.4.2 Signed-off-by: Vicente Cheng <vicente.cheng@suse.com>
Signed-off-by: Vicente Cheng <vicente.cheng@suse.com>
- Wraper the cond lock for caller - Use block channel for waiting scanner stop - Improve the log message with uevent Signed-off-by: Vicente Cheng <vicente.cheng@suse.com>
- now some functions are replaced on standard library `os` Signed-off-by: Vicente Cheng <vicente.cheng@suse.com>
We need to check the `DiskAddedToNode` with the provision device because we may fail to update the device. That means the device status is not `Provisioned`, but the LH node already has the disk. We would not do the next update to make the device `Provisioned`. Signed-off-by: Vicente Cheng <vicente.cheng@suse.com>
- Add xml sample to let user to add disk w/ WWN Signed-off-by: Vicente Cheng <vicente.cheng@suse.com>
- change json format to yaml - skip G204 (gosec) - fix others lint errors Signed-off-by: Vicente Cheng <vicente.cheng@suse.com>
- Add upgrade test on CI. The detail steps as below 1. Install latest version 2. Add disk 3. Upgrade to the develping image 4. Run integration test Signed-off-by: Vicente Cheng <vicente.cheng@suse.com>
Vicente-Cheng
force-pushed
the
wip-NDM-improvement
branch
from
July 3, 2023 08:19
4305d57
to
73f17bd
Compare
bk201
approved these changes
Jul 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This was referenced Jul 3, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
blockdevices
that would cause the data to be lost when it add back.Solution:
blockdevices
CR.corrupted
. For thecorrupted
device, we could choose the force format or try to use e2fsck to repair.Related Issue:
harvester/harvester#3218
harvester/harvester#3412
harvester/harvester#4016
Test plan:
case 1:
blockdevices
status is inactiveblockdevices
status is active and should work again.case 2:
NOTE1: Please update the blockdevices CRD (on this PR) before we do this test
NOTE2: Please ensure you use the SCSI disk with wwn or the filesystem UUID will be erased when we try to break the filesystem.
dd if=/dev/zero of=/dev/sda bs=512k count=1 oflag=sync
Status.Filesystem.Corrupted
is true